Skip to content

fix: remove dead re-exports of WrapperConfig component types#3161

Merged
lpcox merged 2 commits into
mainfrom
fix/remove-dead-type-reexports
May 14, 2026
Merged

fix: remove dead re-exports of WrapperConfig component types#3161
lpcox merged 2 commits into
mainfrom
fix/remove-dead-type-reexports

Conversation

@lpcox
Copy link
Copy Markdown
Collaborator

@lpcox lpcox commented May 14, 2026

Summary

Remove 7 unused type re-exports from src/types/index.ts:

  • ContainerImageOptions
  • NetworkOptions
  • VolumeOptions
  • SecurityOptions
  • ApiProxyOptions
  • RateLimitOptions
  • RuntimeOptions

These types are only used as intersection operands within src/types/wrapper-config.ts to compose the WrapperConfig union type. They are never imported by any code outside src/types/.

Closes #3156

Remove 7 unused type re-exports from src/types/index.ts:
ContainerImageOptions, NetworkOptions, VolumeOptions,
SecurityOptions, ApiProxyOptions, RateLimitOptions, RuntimeOptions.

These types are only used as intersection operands within
src/types/wrapper-config.ts and are never imported externally.

Closes #3156

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@lpcox lpcox requested a review from Mossaka as a code owner May 14, 2026 15:59
Copilot AI review requested due to automatic review settings May 14, 2026 15:59
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes unused WrapperConfig component type re-exports from the public src/types barrel to reduce dead exported API surface flagged by the Export Audit workflow (#3156).

Changes:

  • Removed seven type re-exports (*Options) from src/types/index.ts, leaving WrapperConfig as the exported composite type from wrapper-config.
Show a summary per file
File Description
src/types/index.ts Drops unused public barrel re-exports of WrapperConfig component option types to shrink exported type surface.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread src/types/index.ts Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

🔬 Smoke Test Results

Test Status
GitHub MCP connectivity ❌ (401 - unauthenticated MCP)
GitHub.com HTTP connectivity ⚠️ (template var unexpanded)
File write/read ⚠️ (template var unexpanded)

Overall: FAIL — GitHub MCP returned 401 (bad credentials); workflow template variables ${{ steps.smoke-data.outputs.* }} were not substituted before agent invocation.

/cc @lpcox

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test: Copilot BYOK (Offline) Mode

Test Result
GitHub MCP connectivity ❌ 401 Unauthorized
GitHub.com HTTP ❌ Template vars not expanded
File write/read ❌ Template vars not expanded
BYOK inference (api-proxy → api.githubcopilot.com)

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

Overall: FAIL — Pre-computed test data (${{ steps.smoke-data.outputs.* }}) was not substituted before agent invocation; GitHub MCP returned 401.

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

GitHub API — HTTP 401: Bad credentials (gh CLI not authenticated in workflow context)
Playwright — Page title contains "GitHub" ✓
File verify — smoke-test-claude-25871062457.txt exists with expected content ✓

Overall: FAIL (1 of 3 tests failed)

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

  • GitHub MCP Testing: ❌ (Tools unavailable)
  • GitHub.com Connectivity: ❌ (SSL connect error)
  • File Writing Testing: ✅
  • Bash Tool Testing: ✅

Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test

PRs: fix(entrypoint): preserve setup-* PATH ordering in fallback hostedtoolcache scan | Remove dead re-export barrel src/types/config.ts
GitHub MCP: ❌ | safeinputs-gh: ❌ | Playwright: ✅ | Tavily: ❌
File write: ✅ | Bash read: ✅ | Discussion: ❌ | Build: ✅
Overall status: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

Chroot Version Comparison Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.3
Node.js v24.15.0 v20.20.2
Go go1.22.12 go1.22.12

Overall: ❌ Not all versions match — Python and Node.js differ between host and chroot environments.

Tested by Smoke Chroot

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak 1/1 passed ✅ PASS
Deno std 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1 passed ✅ PASS
Go env 1 passed ✅ PASS
Go uuid 1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx All passed ✅ PASS
Node.js execa All passed ✅ PASS
Node.js p-limit All passed ✅ PASS
Rust fd 1 passed ✅ PASS
Rust zoxide 1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #3161 · ● 10.7M ·

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results

Check Result
Redis PING ❌ timeout/no response
PostgreSQL pg_isready ❌ no response
PostgreSQL SELECT 1 ❌ no response

Overall: FAILhost.docker.internal is unreachable from this runner environment. Service containers are not accessible.

🔌 Service connectivity validated by Smoke Services

@lpcox lpcox merged commit 315874c into main May 14, 2026
65 of 68 checks passed
@lpcox lpcox deleted the fix/remove-dead-type-reexports branch May 14, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Export Audit] Dead re-exports of WrapperConfig component types from types/index.ts

2 participants