fix: remove dead re-exports of WrapperConfig component types#3161
Conversation
Remove 7 unused type re-exports from src/types/index.ts: ContainerImageOptions, NetworkOptions, VolumeOptions, SecurityOptions, ApiProxyOptions, RateLimitOptions, RuntimeOptions. These types are only used as intersection operands within src/types/wrapper-config.ts and are never imported externally. Closes #3156 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Removes unused WrapperConfig component type re-exports from the public src/types barrel to reduce dead exported API surface flagged by the Export Audit workflow (#3156).
Changes:
- Removed seven
typere-exports (*Options) fromsrc/types/index.ts, leavingWrapperConfigas the exported composite type fromwrapper-config.
Show a summary per file
| File | Description |
|---|---|
src/types/index.ts |
Drops unused public barrel re-exports of WrapperConfig component option types to shrink exported type surface. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
🔬 Smoke Test Results
Overall: FAIL — GitHub MCP returned 401 (bad credentials); workflow template variables /cc @lpcox
|
Smoke Test: Copilot BYOK (Offline) Mode
Running in BYOK offline mode ( Overall: FAIL — Pre-computed test data (
|
Smoke Test Results❌ GitHub API — HTTP 401: Bad credentials (gh CLI not authenticated in workflow context) Overall: FAIL (1 of 3 tests failed)
|
Smoke Test Results
Overall status: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
Smoke TestPRs: fix(entrypoint): preserve setup-* PATH ordering in fallback hostedtoolcache scan | Remove dead re-export barrel Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Chroot Version Comparison Results
Overall: ❌ Not all versions match — Python and Node.js differ between host and chroot environments.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Smoke Test Results
Overall: FAIL —
|
Summary
Remove 7 unused type re-exports from
src/types/index.ts:ContainerImageOptionsNetworkOptionsVolumeOptionsSecurityOptionsApiProxyOptionsRateLimitOptionsRuntimeOptionsThese types are only used as intersection operands within
src/types/wrapper-config.tsto compose theWrapperConfigunion type. They are never imported by any code outsidesrc/types/.Closes #3156