Remove unused wrapper-config sub-interface exports from public type surface#3211
Conversation
wrapper-config sub-interface exports from public type surface
There was a problem hiding this comment.
Pull request overview
This PR reduces the exported TypeScript public API surface by removing named sub-interface type re-exports from WrapperConfig’s module, while keeping the composed WrapperConfig type intact and still available via the types barrel.
Changes:
- Removed seven named type re-exports (
*Options) fromsrc/types/wrapper-config.ts. - Retained internal type imports to keep
WrapperConfigcomposition unchanged.
Show a summary per file
| File | Description |
|---|---|
src/types/wrapper-config.ts |
Removes unused public sub-interface re-exports while preserving the WrapperConfig composed type. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
| @@ -5,14 +5,6 @@ | |||
| * This file re-exports those interfaces and composes the final WrapperConfig type. | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@copilot address review feedback |
Addressed in commit |
Smoke Test Results✅ Playwright: Navigated to github.com, page title contains "GitHub" Total: 2/3 PASS (GitHub API auth appears to be environment configuration issue, not engine failure)
|
🧪 Copilot Smoke Test Results
Overall: PARTIAL — File I/O works; GitHub MCP auth unavailable in this environment; pre-step template variables were not expanded by the runner.
|
Smoke Test: Copilot BYOK (Offline) Mode
Running in BYOK offline mode ( Overall: FAIL — GitHub MCP returned 401 and workflow template variables were not substituted before agent invocation.
|
|
Codex smoke: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Chroot Smoke Test Results
Result: FAILED — Python and Node.js versions differ between host and chroot.
|
|
Smoke test results: FAIL (Tools missing) Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
Smoke Test: GitHub Actions Services Connectivity
Overall: FAIL —
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Bug Fix
What was the bug?
src/types/index.tspublicly re-exportedwrapper-configtypes that included seven sub-interfaces with no known consumers outsidesrc/types/. This inflated the public API surface and created avoidable export-audit noise.How did you fix it?
src/types/wrapper-config.ts:ContainerImageOptions,NetworkOptions,VolumeOptions,SecurityOptions,ApiProxyOptions,RateLimitOptions,RuntimeOptions.WrapperConfigcomposition intact; only the extra named re-exports were removed.src/types/index.tsstill re-exportsWrapperConfigviaexport type * from './wrapper-config', but without exposing the unused convenience types.Testing
Not part of the issue scope; this change is limited to export surface cleanup.