Narrow log-discovery API: make isContainerRunning test-helper only

[Copilot]

src/logs/log-discovery.ts exported isContainerRunning even though it is only used internally (plus white-box tests), which unnecessarily expanded the module API surface. This change removes it from the public export surface while preserving direct test access via the existing testHelpers pattern.

• API surface cleanup

  • Removed export from isContainerRunning in src/logs/log-discovery.ts.
  • Kept behavior unchanged for internal call sites (discoverLogSources, validateSource).

• Test-only access pattern

  • Added testHelpers export in log-discovery.ts:
    • export const testHelpers = { isContainerRunning };
  • Aligns with established repository convention for exposing internals to tests without promoting them to first-class API.

• Test updates

  • Updated src/logs/log-discovery.test.ts to import testHelpers and call testHelpers.isContainerRunning(...) instead of importing isContainerRunning directly.

// log-discovery.ts
async function isContainerRunning(containerName: string): Promise<boolean> {
  // ...
}

/** @internal Exposed only for unit tests — not part of the public API. */
// ts-prune-ignore-next
export const testHelpers = { isContainerRunning };

[github-actions]

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	95.98%	96.06%	📈 +0.08%
Statements	95.81%	95.88%	📈 +0.07%
Functions	97.36%	97.36%	➡️ +0.00%
Branches	89.48%	89.52%	📈 +0.04%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
src/config-writer.ts	83.0% → 85.6% (+2.54%)	83.0% → 85.6% (+2.54%)

---

Coverage comparison generated by scripts/ci/compare-coverage.ts

[Copilot]

Pull request overview

This pull request narrows the src/logs/log-discovery.ts module’s public API by making isContainerRunning module-private while still allowing white-box unit tests to call it via the repository’s established testHelpers export pattern.

Changes:

• Removed the direct export from isContainerRunning, making it internal-only for production code paths.
• Added export const testHelpers = { isContainerRunning } to preserve test access without promoting the function as first-class API.
• Updated unit tests to reference testHelpers.isContainerRunning(...) instead of importing isContainerRunning directly.

Show a summary per file

File	Description
src/logs/log-discovery.ts	Makes isContainerRunning private and exposes it only via testHelpers for unit tests.
src/logs/log-discovery.test.ts	Updates tests to use testHelpers.isContainerRunning after API surface narrowing.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 0

[github-actions]

Smoke Test Results

✅ API verification: 2 recent PRs found
✅ Playwright check: PASS — GitHub title correct
✅ File verify: Test marker exists

PASS — Claude validation complete

💥 [THE END] — Illustrated by Smoke Claude

[github-actions]

🔬 Smoke Test Results

Test	Result
GitHub MCP connectivity	✅
GitHub.com HTTP connectivity	✅
File write/read	✅

Overall: PASS

PR: Narrow log-discovery API: make isContainerRunning test-helper only — author @Copilot, assignees @lpcox @Copilot

📰 BREAKING: Report filed by Smoke Copilot

[github-actions]

🔥 Smoke Test: Copilot BYOK (Offline) Mode

Test	Result
GitHub MCP (list PRs)	✅ PR #3522 fetched successfully
GitHub.com Connectivity	⚠️ Pre-step data not injected (${{ steps.smoke-data.outputs.SMOKE_HTTP_CODE }} unresolved)
File Write/Read	⚠️ Pre-step data not injected (SMOKE_FILE_PATH unresolved)
BYOK Inference (this response)	✅ Agent running via api-proxy → api.githubcopilot.com

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com.

Overall: PARTIAL — BYOK inference path works; pre-step smoke data was not interpolated into the prompt.

cc @lpcox (reviewer), @Copilot (assignee)

🔑 BYOK report filed by Smoke Copilot BYOK

[github-actions]

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	All passed	✅ PASS
Node.js	execa	✅	All passed	✅ PASS
Node.js	p-limit	✅	All passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #3530 · ● 5.7M · ◷

[github-actions]

Smoke test result summary: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

[github-actions]

Smoke Codex: FAIL
PRs: Optimize Smoke Claude workflow token footprint by removing Playwright and constraining turns; Reduce test-coverage-improver token burn by narrowing file access and preloading target sources
✅ GitHub PR review
❌ safeinputs-gh query (tool unavailable)
✅ Playwright title check
❌ Tavily search (no tools exposed)
✅ file/bash check; ✅ discussion comment via fallback; ✅ npm build

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

[github-actions]

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌
Node.js	v24.15.0	v22.22.3	❌
Go	go1.22.12	go1.22.12	✅

Overall: ❌ Not all versions match — Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot

[github-actions]

Smoke Test: GitHub Actions Services Connectivity

Check	Result
Redis PING (host.docker.internal:6379)	❌ No response (timeout)
PostgreSQL pg_isready (host.docker.internal:5432)	❌ No response
PostgreSQL SELECT 1	❌ Connection timeout

Overall: FAIL — Service containers are not reachable via host.docker.internal (resolves to 172.17.0.1 but no services responding on ports 6379/5432).

🔌 Service connectivity validated by Smoke Services