Grant Smoke Claude artifact-read permission#3632
Conversation
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Updates the Smoke Claude agentic workflow permissions so the agent job can consistently download Actions artifacts (specifically the activation artifact), aligning it with the other smoke workflows and preventing pre-agent failures.
Changes:
- Add
actions: readto the source workflow permissions in.github/workflows/smoke-claude.md. - Add
actions: readto the compiled workflow’sagentjob permissions in.github/workflows/smoke-claude.lock.yml. - Extend the CI test to assert the presence of
actions: readin both source and compiled workflow files.
Show a summary per file
| File | Description |
|---|---|
| scripts/ci/smoke-claude-workflow.test.ts | Adds assertions intended to prevent regressions in workflow permissions/config. |
| .github/workflows/smoke-claude.md | Grants actions: read at the source workflow level. |
| .github/workflows/smoke-claude.lock.yml | Grants actions: read to the agent job so artifact download can succeed. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 1
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Smoke Test Results
Status: cc
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@copilot recompile smoke claude |
Recompiled |
|
@copilot compile smoke claude |
Compiled |
Smoke Test Results ✅
Overall: All smoke test validations passed. Claude engine is ready.
|
✅ Smoke Test: Copilot BYOK (Offline) Mode — PASS
Note: Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com PR Author:
|
|
Merged PRs: ✅ Refactor agent volume assembly into focused mount modules; Refactor Squid config generation into focused modules Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Gemini Engine Smoke Test ResultsPR Titles Reviewed:
Test Results:
Overall Status: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
Service Connectivity Test Results❌ Redis - Connection timeout (no PONG response) Overall Result: ❌ FAILServices on
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS Summary:
|
The scheduled
Smoke Claudeworkflow was failing before agent execution because theagentjob could not download the activation artifact. This updates the workflow permissions so the job can read Actions artifacts consistently with the other smoke workflows.Root cause
Smoke Claudegrantedcontents,issues, andpull-requestsaccess, but notactions: read.Download activation artifacteven though theactivationjob had already uploaded the artifact.Workflow change
actions: readto the source workflow in.github/workflows/smoke-claude.md..github/workflows/smoke-claude.lock.yml.Regression coverage
scripts/ci/smoke-claude-workflow.test.tsto assert that both the source workflow and compiled workflow retainactions: read.