Trim unused exports from option-parsers barrel#3760
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
This PR narrows the src/option-parsers.ts facade (barrel) API by removing two re-exports (validateAllowHostServicePorts, escapeShellArg) that are intended to be consumed via direct imports from their underlying parser modules instead of the facade.
Changes:
- Removed
validateAllowHostServicePortsandescapeShellArgfrom thesrc/option-parsers.tsre-export surface. - Updated the facade contract test (
src/option-parsers-reexports.test.ts) to stop asserting those two re-exports.
Show a summary per file
| File | Description |
|---|---|
| src/option-parsers.ts | Removes two symbols from the barrel’s public re-export list to reduce facade surface area. |
| src/option-parsers-reexports.test.ts | Aligns re-export assertions with the reduced barrel exports. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 2
|
✅ All checks passed
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Smoke Test Results ✅ GitHub MCP: Fetched PR #3766 "fix: use module-level mock for fs.existsSync in config-writer test" Status: PARTIAL PASS (MCP verified, file test failed) cc:
|
Smoke Test: Copilot BYOK (Offline)✅ GitHub MCP — Latest PR: #3766 (fix: use module-level mock for fs.existsSync in config-writer test) Mode: BYOK offline (COPILOT_OFFLINE=true) via api-proxy sidecar
|
|
Smoke test Codex: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Smoke Test Results (Gemini)
Overall Status: FAIL PR Titles:
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
Service Connectivity Test Results❌ Redis: Connection timeout/error Overall: FAIL — Services on host.docker.internal are not reachable from AWF sandbox
|
Chroot Version Comparison Test ResultsThe chroot environment test has been executed. Here are the runtime version comparisons:
Overall Result: ❌ FAILED - Not all runtimes match between host and chroot environments. Analysis
The test suite expects all runtime versions to match exactly between the host and chroot environments to ensure consistent behavior. The Python and Node.js mismatches indicate that the chroot environment is not properly mirroring the host system runtimes.
|
🏗️ Build Test Suite ResultsAll build tests completed successfully across all ecosystems!
Overall: 8/8 ecosystems passed — ✅ PASS Summary:
All 18 test projects built and passed tests successfully.
|
The
src/option-parsers.tsfacade was exporting two symbols that had no external barrel consumers:validateAllowHostServicePortsandescapeShellArg. This PR narrows the barrel API to currently used exports while preserving direct imports from source parser modules.Barrel API surface cleanup
validateAllowHostServicePortsfrom thehost-port-parsersre-export block.escapeShellArgfrom theshell-utilsre-export block.Facade contract test alignment
src/option-parsers-reexports.test.tsto stop asserting re-exports for the removed symbols.applyHostServicePortsConfig,joinShellArgs) intact.