Skip to content

Remove unused src/services/agent-environment.ts barrel export#3824

Open
Copilot wants to merge 2 commits into
mainfrom
copilot/remove-unused-export-agent-environment
Open

Remove unused src/services/agent-environment.ts barrel export#3824
Copilot wants to merge 2 commits into
mainfrom
copilot/remove-unused-export-agent-environment

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 26, 2026

Export audit flagged src/services/agent-environment.ts as dead API surface: it re-exported buildAgentEnvironment, but no code imported from that path. Consumers already use buildAgentEnvironment via src/services/agent-service.ts.

  • What changed

    • Deleted the unused barrel file:
      • src/services/agent-environment.ts
  • API surface impact

    • Removes an unreferenced export path that was introduced during earlier refactoring.
    • Keeps the existing canonical import path unchanged (src/services/agent-service.ts).
  • Illustrative diff

    // removed file: src/services/agent-environment.ts
    export { buildAgentEnvironment } from './agent-environment/environment-builder';

Copilot AI changed the title [WIP] Remove unused export from agent-environment barrel file Remove unused src/services/agent-environment.ts barrel export May 26, 2026
Copilot finished work on behalf of lpcox May 26, 2026 00:13
Copilot AI requested a review from lpcox May 26, 2026 00:13
@lpcox lpcox marked this pull request as ready for review May 26, 2026 00:45
Copilot AI review requested due to automatic review settings May 26, 2026 00:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an unused barrel export (src/services/agent-environment.ts) that re-exported buildAgentEnvironment, reducing dead API surface while preserving the canonical export path via src/services/agent-service.ts.

Changes:

  • Deleted the unused src/services/agent-environment.ts re-export file.
Show a summary per file
File Description
src/services/agent-environment.ts Removed an unreferenced barrel export for buildAgentEnvironment.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions
Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 96.54% 96.61% 📈 +0.07%
Statements 96.38% 96.47% 📈 +0.09%
Functions 97.99% 98.19% 📈 +0.20%
Branches 90.78% 90.82% 📈 +0.04%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/config-writer.ts 89.3% → 90.9% (+1.65%) 89.3% → 90.9% (+1.65%)
🗑️ Removed Files (1 files)
  • src/services/agent-environment.ts

Coverage comparison generated by scripts/ci/compare-coverage.ts

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test (Claude) — ✅ PASS

  • ✅ GitHub API: 2 recent PR entries found
  • ✅ GitHub check (playwright): PASS
  • ✅ File verify: smoke-test-claude-26425052440.txt exists

Total: PASS

💥 [THE END] — Illustrated by Smoke Claude

@github-actions
Copy link
Copy Markdown
Contributor

🔬 Smoke Test Results

Test Result
GitHub MCP connectivity ✅ PR list fetched successfully
GitHub.com HTTP connectivity ⚠️ Template vars not resolved (pre-step skipped)
File write/read ⚠️ Template vars not resolved (pre-step skipped)

PR: Remove unused src/services/agent-environment.ts barrel export
Author: @Copilot | Assignees: @lpcox, @Copilot

Overall: PARTIAL — MCP connectivity confirmed ✅; HTTP/file tests could not be evaluated (GitHub Actions template expressions were not substituted before agent invocation).

📰 BREAKING: Report filed by Smoke Copilot

@github-actions
Copy link
Copy Markdown
Contributor

🔥 Smoke Test: Copilot BYOK (Offline) Mode

Test Result
GitHub MCP connectivity ✅ PR list fetched successfully
GitHub.com HTTP ⚠️ Pre-step data unavailable (template vars not expanded)
File write/read ⚠️ Pre-step data unavailable (template vars not expanded)
BYOK inference (agent → api-proxy → api.githubcopilot.com) ✅ Responding now

Running in BYOK offline mode (COPILOT_OFFLINE=true) via api-proxy → api.githubcopilot.com

Overall: PARTIAL — BYOK inference and MCP confirmed ✅; pre-step smoke data not injected into prompt.

CC: @lpcox @Copilot

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions
Copy link
Copy Markdown
Contributor

PRs:
fix(api-proxy): prevent stream_options injection into OpenAI Responses API requests
Filter unresolvable model aliases from /reflect and models.json
✅ GitHub PR review
✅ GitHub/gh-aw-firewall PR query
✅ Playwright GitHub title check
✅ smoke test file write/read
✅ Build npm ci && npm run build
✅ Discussion query/comment
Overall: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions
Copy link
Copy Markdown
Contributor

Chroot Smoke Test Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.13 Python 3.12.3 ❌ NO
Node.js v24.15.0 v22.22.3 ❌ NO
Go go1.22.12 go1.22.12 ✅ YES

⚠️ Not all tests passed. Python and Node.js versions differ between host and chroot environments.

Tested by Smoke Chroot

@github-actions
Copy link
Copy Markdown
Contributor

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A ✅ PASS
.NET json-parse N/A ✅ PASS
Go color 1/1 passed ✅ PASS
Go env 1/1 passed ✅ PASS
Go uuid 1/1 passed ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx all passed ✅ PASS
Node.js execa all passed ✅ PASS
Node.js p-limit all passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Generated by Build Test Suite for issue #3824 · sonnet46 1.1M ·

@github-actions
Copy link
Copy Markdown
Contributor

Smoke Test Results — FAIL

Check Result
Redis PING ❌ Connection timeout
PostgreSQL pg_isready ❌ No response
PostgreSQL SELECT 1 ❌ No response

host.docker.internal resolves to 172.17.0.1 but all ports are unreachable. Service containers appear to not be running or are blocked by the network firewall.

Overall: FAIL

🔌 Service connectivity validated by Smoke Services

@github-actions
Copy link
Copy Markdown
Contributor

Smoke test pass

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • localhost

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "localhost"

See Network Configuration for more information.

💎 Faceted by Smoke Gemini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Export Audit] Dead barrel file src/services/agent-environment.ts with unused export

3 participants