feat: add --tty option for interactive tools and update docker config#51
Merged
feat: add --tty option for interactive tools and update docker config#51
Conversation
Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
Contributor
Test Coverage Report
Coverage ThresholdsThe project has the following coverage thresholds configured:
Coverage report generated by `npm run test:coverage` |
Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
The args.length === 1 check is correct and necessary for preserving shell variables ($HOME, $(command), etc.) that must expand in the container, not on the host. Root cause analysis: - shell-quote library would expand variables on HOST machine - GitHub Actions commands contain $GITHUB_WORKSPACE, $HOME, etc - These must expand INSIDE the container, not before - Docker Compose $$$$ escaping requires literal $ preservation Solution: Keep single-argument passthrough, add comprehensive docs Changes: - Enhanced documentation in src/cli.ts explaining behavior - Added JSDoc to test runner explaining string vs array - Added test cases for variable preservation - Updated docs/usage.md with environment variable examples This ensures shell variables expand correctly in the container environment while maintaining backward compatibility. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiaxiao (mossaka) Zhou duibao55328@gmail.com