Skip to content

fix(agent): enable direct api-proxy access and remove api key from env#807

Merged
lpcox merged 2 commits intoclaude/fix-github-actions-workflow-againfrom
claude/fix-github-actions-workflow-yet-again
Feb 13, 2026
Merged

fix(agent): enable direct api-proxy access and remove api key from env#807
lpcox merged 2 commits intoclaude/fix-github-actions-workflow-againfrom
claude/fix-github-actions-workflow-yet-again

Conversation

@Claude
Copy link
Contributor

@Claude Claude AI commented Feb 13, 2026

The agent container was unable to connect to api-proxy because iptables redirected all HTTP/HTTPS traffic to Squid, and ANTHROPIC_API_KEY was incorrectly exposed to the agent container instead of isolated to api-proxy.

Changes

  • containers/agent/setup-iptables.sh: Add NAT RETURN rule and FILTER ACCEPT rules to bypass Squid for api-proxy traffic (ports 10000, 10001)

    • Conditional on AWF_ENABLE_API_PROXY environment variable
    • Implements correct architecture: agent → api-proxy (direct) → Squid → internet
  • src/docker-manager.ts: Set AWF_ENABLE_API_PROXY='1' in agent environment when config.enableApiProxy is true

  • scripts/ci/postprocess-smoke-workflows.ts: Strip ANTHROPIC_API_KEY from agent environment in compiled workflows

    • Removes security vulnerability where API key was accessible to agent
    • Key now only accessible to api-proxy sidecar

Before/After

Before: All agent HTTP/HTTPS traffic (including api-proxy) redirected to Squid

agent → iptables DNAT → Squid → api-proxy ❌

After: Agent connects directly to api-proxy, api-proxy routes through Squid

agent → api-proxy → Squid → internet ✅

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/github/gh-aw-firewall/actions/runs/21975677690
    • Triggering command: /usr/bin/gh gh run view 21975677690 --repo github/gh-aw-firewall --log (http block)

If you need me to access, download, or install something from one of these locations, you can either:

- Add iptables bypass for api-proxy in setup-iptables.sh
- Pass AWF_ENABLE_API_PROXY env var from docker-manager.ts
- Remove ANTHROPIC_API_KEY from agent env in workflows
- Update postprocess script to strip API key from compiled workflows

Fixes agent->api-proxy connectivity and security vulnerability where
API key was exposed to agent container instead of isolated to api-proxy.
@Claude Claude AI changed the title [WIP] Fix failing GitHub Actions workflow agent fix(agent): enable direct api-proxy access and remove api key from env Feb 13, 2026
@Claude Claude AI requested a review from lpcox February 13, 2026 05:41
@lpcox lpcox marked this pull request as ready for review February 13, 2026 05:43
Copilot AI review requested due to automatic review settings February 13, 2026 05:43
@lpcox lpcox merged commit e54a36d into claude/fix-github-actions-workflow-again Feb 13, 2026
@lpcox lpcox deleted the claude/fix-github-actions-workflow-yet-again branch February 13, 2026 05:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical security and connectivity issue with the api-proxy sidecar feature by enabling direct agent-to-api-proxy communication and removing API key exposure from the agent container.

Purpose: The agent container was unable to connect to api-proxy because iptables redirected all HTTP/HTTPS traffic through Squid, breaking the intended architecture where the agent connects directly to api-proxy. Additionally, ANTHROPIC_API_KEY was incorrectly exposed to the agent container, violating the security isolation principle where API keys should only exist in the api-proxy sidecar.

Changes:

  • Added iptables NAT RETURN and FILTER ACCEPT rules to bypass Squid for api-proxy traffic (ports 10000, 10001)
  • Set AWF_ENABLE_API_PROXY='1' environment variable in agent container when api-proxy is enabled
  • Removed ANTHROPIC_API_KEY from agent environment in compiled Claude-based smoke test workflows

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/docker-manager.ts Sets AWF_ENABLE_API_PROXY='1' environment variable in agent container when config.enableApiProxy is true, enabling iptables configuration for direct api-proxy access
containers/agent/setup-iptables.sh Adds conditional NAT RETURN and FILTER ACCEPT rules to allow agent to connect directly to api-proxy (bypassing Squid), resolving connectivity issues while maintaining security through port restrictions
scripts/ci/postprocess-smoke-workflows.ts Implements regex-based removal of ANTHROPIC_API_KEY from agent environment in compiled workflows, addressing security concern where API keys were accessible to agent container
.github/workflows/smoke-claude.lock.yml Removes ANTHROPIC_API_KEY from validation and agent execution steps, as workflows use CLAUDE_CODE_OAUTH_TOKEN instead
.github/workflows/security-guard.lock.yml Removes ANTHROPIC_API_KEY from validation and agent execution steps, consistent with OAuth token authentication approach
.github/workflows/secret-digger-claude.lock.yml Removes ANTHROPIC_API_KEY from validation and agent execution steps, aligning with security isolation requirements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

lpcox added a commit that referenced this pull request Feb 13, 2026
…ng (#802)

* Initial plan

* fix(ci): add BASE_URL environment variables for CODEX api-proxy routing

CODEX was not being directed to use the api-proxy because the
OPENAI_BASE_URL and ANTHROPIC_BASE_URL environment variables were
not explicitly set in the smoke-codex workflow.

While AWF automatically sets these variables when generating the
docker-compose configuration (if API keys are present), explicitly
setting them in the workflow env ensures they are available to the
CODEX agent for routing API calls through the api-proxy sidecar.

This fix adds:
- OPENAI_BASE_URL=http://api-proxy:10000
- ANTHROPIC_BASE_URL=http://api-proxy:10001

to the 'Run Codex' step environment variables.

Fixes job failure in run 63483600453.

* fix(ci): remove API keys from agent env when api-proxy is enabled (#803)

* Initial plan

* fix(ci): remove API keys from agent env when api-proxy is enabled

When api-proxy is enabled (indicated by BASE_URL environment variables),
API keys should NOT be exposed to the agent container for security.
The api-proxy sidecar holds the credentials and injects auth headers.

Previously, the workflow was passing both:
- CODEX_API_KEY and OPENAI_API_KEY (should NOT be in agent env)
- OPENAI_BASE_URL and ANTHROPIC_BASE_URL (should be in agent env)

This defeated the security isolation provided by api-proxy.

Changes:
- Removed CODEX_API_KEY and OPENAI_API_KEY from agent environment block
- Kept OPENAI_BASE_URL and ANTHROPIC_BASE_URL for routing to api-proxy
- The awf CLI still receives keys via `sudo -E` and `--env-all`
- awf passes keys only to api-proxy container, not agent container

Security model:
- awf reads keys from host environment (process.env)
- awf passes keys only to api-proxy sidecar (src/docker-manager.ts:908-909)
- Agent only receives BASE_URL variables (src/docker-manager.ts:948-955)
- api-proxy injects auth headers and routes through Squid

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix(firewall): add api-proxy to allowed domains when enabled (#804)

* Initial plan

* fix(firewall): add api-proxy to allowed domains when enabled

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix(squid): handle bare hostnames without leading dot for api-proxy (#805)

* Initial plan

* fix(squid): handle bare hostnames without leading dot for api-proxy

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix(agent): enable direct api-proxy access and remove api key from env (#807)

* Initial plan

* fix(agent): enable direct api-proxy access and remove api key from env

- Add iptables bypass for api-proxy in setup-iptables.sh
- Pass AWF_ENABLE_API_PROXY env var from docker-manager.ts
- Remove ANTHROPIC_API_KEY from agent env in workflows
- Update postprocess script to strip API key from compiled workflows

Fixes agent->api-proxy connectivity and security vulnerability where
API key was exposed to agent container instead of isolated to api-proxy.

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>

* fix: pass ANTHROPIC_API_KEY to validation in all Claude workflows (#808)

* Initial plan

* fix: pass ANTHROPIC_API_KEY to validation step in smoke-claude workflow

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix: pass ANTHROPIC_API_KEY to validation in all Claude workflows

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix: only enable api-proxy when API keys are provided (#810)

* Initial plan

* fix: only enable api-proxy when API keys are provided

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* feat(workflow): enable api-proxy for smoke-claude workflow

- Add --enable-api-proxy flag to awf command
- Add --anthropic-api-key flag to pass API key to api-proxy sidecar
- Add ANTHROPIC_API_KEY to env block for agent step
- API key is shared with api-proxy, kept out of agent container
- Agent uses ANTHROPIC_BASE_URL to direct requests to api-proxy

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* refactor(workflow): remove redundant --enable-api-proxy flag

The --enable-api-proxy flag defaults to true (src/cli.ts:724), so it
doesn't need to be explicitly specified. The api-proxy sidecar will
automatically deploy when API keys are present.

See docs/api-proxy-sidecar.md:51 which states "The API proxy is
enabled by default and automatically deploys when API keys are present"

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix: remove unknown --anthropic-api-key flag from smoke-claude workflow (#811)

* Initial plan

* fix: remove unknown --anthropic-api-key flag from smoke-claude workflow

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix: use api-proxy IP address instead of hostname for BASE_URL (#813)

* Initial plan

* fix: use api-proxy IP address instead of hostname for BASE_URL

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix: use api-proxy IP address instead of hostname for BASE_URL (#813) (#815)

* Initial plan

* fix: use api-proxy IP address instead of hostname for BASE_URL (#813)

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix(api-proxy): use IP address for API base URLs to avoid DNS issues

In chroot mode, Docker container hostname resolution can fail because
the DNS resolver may not properly reach Docker's embedded DNS. Use the
api-proxy IP address directly (e.g., http://172.30.0.30:10001) instead
of the hostname (http://api-proxy:10001) to eliminate DNS resolution as
a failure point.

Also add test coverage for the host-iptables api-proxy ACCEPT rule.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: exclude API keys from agent when api-proxy is enabled (#814)

* Initial plan

* fix: exclude API keys from agent when api-proxy is enabled

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>

* fix(agent): use AWF_API_PROXY_IP env var for api-proxy iptables rules (#817)

* Initial plan

* fix(agent): use AWF_API_PROXY_IP env var for api-proxy iptables

Move api-proxy iptables rules to use pre-set AWF_API_PROXY_IP environment
variable instead of dynamic hostname resolution, and place FILTER rules in
the correct position (after NAT setup, before final DROP rule).

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* Add debug logging for BASE_URL environment variables in agent container (#816)

* Initial plan

* feat: add debug logging for BASE_URL environment variables

Add logging to display ANTHROPIC_BASE_URL and OPENAI_BASE_URL values
that are set for the agent container. This helps debug configuration
issues when running Claude Code CLI in the workflow.

The logging is added after the Docker Compose config is generated,
showing whether BASE_URL variables are set or using defaults.

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* fix: simplify api-proxy iptables bypass condition (#819)

* Initial plan

* fix: simplify api-proxy iptables bypass condition

The NAT bypass for api-proxy traffic was checking both AWF_ENABLE_API_PROXY
and AWF_API_PROXY_IP, but this was too strict. When the HTTP_PROXY
environment variable is set, HTTP clients will send requests through the
proxy unless NO_PROXY is configured or iptables rules prevent it.

The issue was that the NAT bypass required both flags, causing traffic
to 172.30.0.30 (api-proxy) to be sent through Squid when it should go
directly. Squid then blocked these requests because the IP address wasn't
in the domain whitelist.

The fix simplifies the condition to only check AWF_API_PROXY_IP, matching
the pattern used for the OUTPUT FILTER ACCEPT rules (lines 285-289).
This ensures that when AWF_API_PROXY_IP is set, traffic to that IP
bypasses Squid at the NAT level, preventing HTTP clients from routing
through the proxy regardless of HTTP_PROXY settings.

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

* Initial plan (#818)

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>

* fix: add api-proxy IP to squid allowlist (#820)

* Initial plan

* fix: add api-proxy IP to squid allowlist

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Co-authored-by: Landon Cox <landon.cox@microsoft.com>
Co-authored-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants