Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates documentation to match existing implementation details surfaced by the nightly docs reconciliation workflow, reducing user confusion around config validation and container runtime behavior.
Changes:
- Documented that mount
sourceanddestpaths must be absolute in mount specs. - Updated
DOCKER_API_VERSIONdocs to reflect daemon-version detection with a universal1.44fallback.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Adds the absolute-path requirement for mount source/dest in the validation rules section. |
| AGENTS.md | Corrects DOCKER_API_VERSION documentation to match run_containerized.sh behavior (daemon query; fallback 1.44). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly documentation reconciliation workflow identified two discrepancies between documentation and code implementation.
Changes
README.md: Added absolute path requirement for mount specifications in validation rules
/)internal/config/rules/rules.go:156-184per MCP Gateway spec v1.8.0 section 4.1.5AGENTS.md: Updated
DOCKER_API_VERSIONdocumentation to reflect actual implementationrun_containerized.sh:240-244behaviorExample
Users attempting relative paths in mount specifications will now understand why validation fails:
{ "mounts": [ "data:/app/data:ro" // ❌ Fails: source must be absolute ] }Should be:
{ "mounts": [ "/host/data:/app/data:ro" // ✅ Valid: both paths absolute ] }Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
example.com/tmp/go-build573668252/b279/launcher.test /tmp/go-build573668252/b279/launcher.test -test.testlogfile=/tmp/go-build573668252/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true rtcfg HEAD x_amd64/compile(dns block)invalid-host-that-does-not-exist-12345.com/tmp/go-build573668252/b264/config.test /tmp/go-build573668252/b264/config.test -test.testlogfile=/tmp/go-build573668252/b264/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/cgo 64/src/math/exp_amd64.s 64/bin/as(dns block)nonexistent.local/tmp/go-build573668252/b279/launcher.test /tmp/go-build573668252/b279/launcher.test -test.testlogfile=/tmp/go-build573668252/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true rtcfg HEAD x_amd64/compile(dns block)slow.example.com/tmp/go-build573668252/b279/launcher.test /tmp/go-build573668252/b279/launcher.test -test.testlogfile=/tmp/go-build573668252/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true rtcfg HEAD x_amd64/compile(dns block)this-host-does-not-exist-12345.com/tmp/go-build573668252/b288/mcp.test /tmp/go-build573668252/b288/mcp.test -test.testlogfile=/tmp/go-build573668252/b288/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/cgo lkem/cast.go x_amd64/compile(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This section details on the original issue you should resolve
<issue_title>📚 Documentation Reconciliation Report - 2026-02-22</issue_title>
<issue_description>## Summary
Found 1 discrepancy and 1 minor internal-doc inaccuracy between documentation and implementation during nightly reconciliation check.
Important Issues 🟡
1. Mount Specification Validation — Missing Absolute Path Requirement
Location:
README.md, Validation Rules section under "Server Configuration Fields → mounts"Problem: The documentation states mount specifications must follow
"source:dest:mode"format and lists these constraints:However, the code also requires that both source and destination must be absolute paths (starting with
/). This constraint is not mentioned in the README.Actual Behavior: The validation code in
internal/config/rules/rules.go:156-183(per "MCP Gateway specification v1.8.0 section 4.1.5") enforces:/)/)Users attempting
"./(redacted) or"(redacted) will receive:Impact: Users who read the documentation and try relative paths will get unexpected validation errors without any hint from the docs that absolute paths are required.
Suggested Fix: Update the Validation Rules bullet for mounts in README.md from:
to:
Code Reference:
internal/config/rules/rules.go:123-196(MountFormatfunction)Minor Issues 🔵
2. AGENTS.md — DOCKER_API_VERSION Documentation Outdated
Location:
AGENTS.md, Environment Variables sectionProblem:
AGENTS.mdstates:Actual Behavior:
run_containerized.shuses1.44as the fallback for all architectures (both arm64 and amd64):README.mdalready correctly documents this as "falls back to1.44if detection fails."AGENTS.mdis inconsistent with bothREADME.mdand the implementation.Impact: AI agents using
AGENTS.mdas a reference may be confused about the architecture-specific API versions.Suggested Fix: Update
AGENTS.mdto:Code Reference:
run_containerized.sh:228-245Documentation Completeness
Missing Documentation
customSchemasfield in JSON stdin format (StdinConfig.CustomSchemas) exists in code but is undocumented (this appears intentional as an advanced/experimental feature)Outdated Documentation
AGENTS.mdDOCKER_API_VERSION mentions architecture-specific fallback values (1.43 arm64, 1.44 amd64) that no longer reflect the code (both use 1.44)Accurate Sections ✅
internal/cmd/flags_*.goenvutil.GetEnvStringcalls)127.0.0.1:3000, log dir/tmp/gh-aw/mcp-logs, payload dir/tmp/jq-payloads, threshold10240) all match code constants1.25.0matchesgo.modbuild,test,test-unit,test-integration,test-all,lint,coverage,install,format,cleancontainerfor stdio,urlfor http) match codepayloadSizeThresholdcorrectly documented as not supported in JSON stdin formatgo.modhttps://github.com/github/gh-aw/blob/main/docs/src/content/docs/reference/mcp-gateway.mdreturns HTTP 200Tested Commands
...