Skip to content

Remove local container build from smoke-copilot workflow#1736

Merged
lpcox merged 1 commit intomainfrom
smoke/allowonly-guard
Mar 10, 2026
Merged

Remove local container build from smoke-copilot workflow#1736
lpcox merged 1 commit intomainfrom
smoke/allowonly-guard

Conversation

@lpcox
Copy link
Collaborator

@lpcox lpcox commented Mar 10, 2026

Use standard GHCR image instead of building locally. Go setup retained for serena tool.

Use standard GHCR image instead of building locally. Go setup
retained for serena tool.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 10, 2026 17:30
@lpcox lpcox merged commit 02b1591 into main Mar 10, 2026
5 checks passed
@lpcox lpcox deleted the smoke/allowonly-guard branch March 10, 2026 17:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Smoke Copilot workflow to stop building an MCP Gateway container locally and instead rely on a prebuilt GHCR image, with the compiled lock workflow regenerated accordingly.

Changes:

  • Removed Docker Buildx + local docker build steps from smoke-copilot.md.
  • Regenerated smoke-copilot.lock.yml with a newer gh-aw compiler/action version, reflecting the removal of the local build step and other emitted workflow changes.
  • Enabled failure reporting as issues in the compiled workflow (GH_AW_FAILURE_REPORT_AS_ISSUE: "true").

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/smoke-copilot.md Removes local container build steps; continues to reference GHCR image for the sandbox MCP gateway.
.github/workflows/smoke-copilot.lock.yml Regenerated workflow output (gh-aw v0.57.1), removing the build steps and introducing additional compiled-behavior changes.
Comments suppressed due to low confidence (1)

.github/workflows/smoke-copilot.lock.yml:898

  • The compiled workflow no longer provisions any safe-inputs tools/servers (no safeinputs MCP server in mcpServers), but smoke-copilot.md and shared imports still instruct the agent to use safeinputs-gh, safeinputs-make, and github-*-query safe-input tools. This will likely cause the Copilot run to fail with “missing tool” errors. Either re-enable safe-inputs tool generation in the workflow compile output, or update the smoke test instructions/imports to use the actually available tools (e.g., bash/github MCP) and ensure gh authentication is covered.
          {
            "mcpServers": {
              "agenticworkflows": {
                "type": "stdio",
                "container": "alpine:latest",
                "entrypoint": "/opt/gh-aw/gh-aw",
                "entrypointArgs": ["mcp-server", "--validate-actor"],
                "mounts": ["/opt/gh-aw:/opt/gh-aw:ro", "/usr/bin/gh:/usr/bin/gh:ro", "\${GITHUB_WORKSPACE}:\${GITHUB_WORKSPACE}:rw", "/tmp/gh-aw:/tmp/gh-aw:rw"],
                "args": ["--network", "host", "-w", "\${GITHUB_WORKSPACE}"],
                "env": {
                  "DEBUG": "*",
                  "GITHUB_TOKEN": "\${GITHUB_TOKEN}",
                  "GITHUB_ACTOR": "\${GITHUB_ACTOR}",
                  "GITHUB_REPOSITORY": "\${GITHUB_REPOSITORY}"
                }
              },
              "github": {
                "type": "stdio",
                "container": "ghcr.io/github/github-mcp-server:v0.32.0",
                "env": {
                  "GITHUB_LOCKDOWN_MODE": "$GITHUB_MCP_LOCKDOWN",
                  "GITHUB_PERSONAL_ACCESS_TOKEN": "\${GITHUB_MCP_SERVER_TOKEN}",
                  "GITHUB_READ_ONLY": "1",
                  "GITHUB_TOOLSETS": "repos,pull_requests"
                }
              },
              "playwright": {
                "type": "stdio",
                "container": "mcr.microsoft.com/playwright/mcp",
                "args": ["--init", "--network", "host", "--security-opt", "seccomp=unconfined", "--ipc=host"],
                "entrypointArgs": ["--output-dir", "/tmp/gh-aw/mcp-logs/playwright", "--no-sandbox"],
                "mounts": ["/tmp/gh-aw/mcp-logs:/tmp/gh-aw/mcp-logs:rw"]
              },
              "safeoutputs": {
                "type": "http",
                "url": "http://host.docker.internal:$GH_AW_SAFE_OUTPUTS_PORT",
                "headers": {
                  "Authorization": "\${GH_AW_SAFE_OUTPUTS_API_KEY}"
                }
              },
              "serena": {
                "type": "stdio",
                "container": "ghcr.io/github/serena-mcp-server:latest",
                "args": ["--network", "host"],
                "entrypoint": "serena",
                "entrypointArgs": ["start-mcp-server", "--context", "codex", "--project", "\${GITHUB_WORKSPACE}"],
                "mounts": ["\${GITHUB_WORKSPACE}:\${GITHUB_WORKSPACE}:rw"]
              }
            },

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 1288 to 1297
GH_AW_RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
GH_AW_AGENT_CONCLUSION: ${{ needs.agent.result }}
GH_AW_WORKFLOW_ID: "smoke-copilot"
GH_AW_SECRET_VERIFICATION_RESULT: ${{ needs.activation.outputs.secret_verification_result }}
GH_AW_CHECKOUT_PR_SUCCESS: ${{ needs.agent.outputs.checkout_pr_success }}
GH_AW_INFERENCE_ACCESS_ERROR: ${{ needs.agent.outputs.inference_access_error }}
GH_AW_SAFE_OUTPUT_MESSAGES: "{\"footer\":\"\\u003e 📰 *BREAKING: Report filed by [{workflow_name}]({run_url})*\",\"runStarted\":\"📰 BREAKING: [{workflow_name}]({run_url}) is now investigating this {event_type}. Sources say the story is developing...\",\"runSuccess\":\"📰 VERDICT: [{workflow_name}]({run_url}) has concluded. All systems operational. This is a developing story. 🎤\",\"runFailure\":\"📰 DEVELOPING STORY: [{workflow_name}]({run_url}) reports {status}. Our correspondents are investigating the incident...\"}"
GH_AW_GROUP_REPORTS: "false"
GH_AW_FAILURE_REPORT_AS_ISSUE: "true"
GH_AW_TIMEOUT_MINUTES: "15"
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes workflow behavior beyond “remove local container build”: it bumps the gh-aw compiler/action version and enables GH_AW_FAILURE_REPORT_AS_ISSUE. Please confirm this behavior change is intended and update the PR description accordingly (or revert if out of scope).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants