fix: type mismatch in LogDifcFilteredItem causes build failure#2080
Merged
lpcox merged 1 commit intofeat/difc-filtered-item-loggingfrom Mar 18, 2026
Merged
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
lpcox
March 18, 2026 01:12
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a compile-time type mismatch in JSONL logging by routing DIFC-filtered entries through the JSONL logger’s generic entry writer, allowing non-RPC JSONL records to be logged alongside RPC messages.
Changes:
- Update
LogDifcFilteredItemto calllogger.logEntry(entry)instead oflogger.LogMessage(entry)to avoid passing a non-*JSONLRPCMessagetype into the RPC-only method.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
171
to
173
| if logger == nil { | ||
| return | ||
| } |
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LogDifcFilteredItemwas passing*JSONLFilteredItemtologger.LogMessage, which only accepts*JSONLRPCMessage, causing a compile error.Change
internal/logger/jsonl_logger.go: Replacelogger.LogMessage(entry)withlogger.logEntry(entry)inLogDifcFilteredItem.logEntryacceptsinterface{}and is the underlying methodLogMessagealready delegates to — making it the correct call site for non-RPC entry types.