Fix duplicate test functions in config validation tests#4156
Merged
Conversation
TestValidateTrustedBots, TestValidateGatewayConfig_OpenTelemetry, and TestValidateGatewayConfig_TrustedBots were declared in both validation_otel_test.go and validation_gateway_coverage_test.go. The gateway coverage versions are more comprehensive (extra edge cases), so remove the duplicates from validation_otel_test.go. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes duplicate test function declarations in internal/config to resolve go vet redeclaration failures, keeping the more comprehensive test coverage in validation_gateway_coverage_test.go.
Changes:
- Deleted the duplicate
TestValidateTrustedBotsfromvalidation_otel_test.go. - Deleted the duplicate
TestValidateGatewayConfig_OpenTelemetryandTestValidateGatewayConfig_TrustedBotsfromvalidation_otel_test.go. - Left brief in-file pointers indicating where the tests now live.
Show a summary per file
| File | Description |
|---|---|
| internal/config/validation_otel_test.go | Removes duplicate test functions that were redeclared in validation_gateway_coverage_test.go, resolving go vet failures. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three test functions were declared in both
validation_otel_test.goandvalidation_gateway_coverage_test.go, causinggo vetto fail with redeclaration errors:TestValidateTrustedBotsTestValidateGatewayConfig_OpenTelemetryTestValidateGatewayConfig_TrustedBotsThe
validation_gateway_coverage_test.goversions are more comprehensive (extra edge cases like tab-only entries, invalid spanId, service name), so this PR removes the duplicates fromvalidation_otel_test.go.Verified:
make agent-finishedpasses (format, build, lint, all tests).