[log] Add debug logging to cmd/tracing_helpers.go#4173
Merged
Conversation
Log tracing provider initialization, fallback, and shutdown events using the existing cmd package debugLog variable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds debug-level observability around OpenTelemetry tracing provider initialization and shutdown in the cmd package, using the existing debugLog namespace.
Changes:
- Add debug logs before/after
tracing.InitProviderand when falling back to the no-op provider. - Add debug logs before/after shutdown and when shutdown returns an error.
Show a summary per file
| File | Description |
|---|---|
| internal/cmd/tracing_helpers.go | Adds debug logging around tracing provider init (including fallback) and shutdown paths. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 5 debug logging calls to
internal/cmd/tracing_helpers.gousing the existingdebugLogvariable from thecmdpackage (logger.New("cmd:root")).Changes
File:
internal/cmd/tracing_helpers.goinitTracingProviderWithFallbackshutdownTracingProviderWithTimeoutWhy This Matters
These functions handle critical startup and shutdown lifecycle events for OpenTelemetry tracing. With
DEBUG=cmd:*, developers can now observe:Validation
go build ./...✅go vet ./internal/cmd/...✅go test ./internal/cmd/...✅ (all tests pass)Quality Checklist
debugLoglogger (no new logger declaration needed)pkg:filenameconvention (cmd:root)