[log] Add debug logging to difc/pipeline_decisions#4457
Merged
Conversation
Log each pipeline decision function's inputs and result to help troubleshoot DIFC enforcement behavior during development. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds debug-level observability to DIFC pipeline branching by introducing a dedicated logger in internal/difc/pipeline_decisions.go, making it easier to trace why specific enforcement paths were taken at runtime.
Changes:
- Added a
difc:pipeline_decisionsdebug logger using the project’sinternal/loggerframework. - Logged inputs and boolean outcomes for the four key pipeline decision helpers.
Show a summary per file
| File | Description |
|---|---|
| internal/difc/pipeline_decisions.go | Introduces a package-level debug logger and emits decision-tracing logs from pipeline predicate functions. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds debug logging to
internal/difc/pipeline_decisions.gousing the project's logger framework.Changes
var logPipeline = logger.New("difc:pipeline_decisions")logger declarationimportforgithub.com/github/gh-aw-mcpg/internal/loggerShouldBypassCoarseDeny— logs operation type and bypass decisionShouldCallLabelResponse— logs operation, enforcement mode, and resultShouldBlockFilteredResponse— logs mode, filtered count, and block decisionShouldAccumulateReadLabels— logs operation, enforcement mode, and accumulate decisionWhy This File
These four functions control critical DIFC pipeline branching:
Logging their inputs and decisions helps troubleshoot unexpected DIFC enforcement behavior during development and production debugging.
Validation
go build ./...— passesgo vet ./...— passesgo test ./internal/difc/...— passes