[log] Add debug logging to container detection#488
Merged
Conversation
Contributor
Author
Smoke Test ResultsLast 2 Merged PRs:
Test Results: Overall: PASS cc: @github-actions
|
Contributor
Author
Smoke Test Results - Copilot EnginePRs Tested: #502 (fixed agent prompt), #500 (changed debug env var) ✅ GitHub MCP Overall Status: PASS ✅ cc @github-actions[bot]
|
Contributor
Author
Smoke Test: Copilot - ✅ PASSPRs Reviewed:
Test Results: Run: https://github.com/githubnext/gh-aw-mcpg/actions/runs/21553349035
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive debug logging to
internal/tty/container.goto improve troubleshooting and development visibility when detecting container environments.Changes
Enhanced the
IsRunningInContainer()function with 6 meaningful debug log statements:/.dockerenvfile is found/proc/1/cgroupcontains container indicators/proc/1/cgroupread failsRUNNING_IN_CONTAINER=trueLogging Details
tty:container(followspkg:filenameconvention)github.com/githubnext/gh-aw-mcpg/internal/loggerTesting
The changes follow the project's logging guidelines from AGENTS.md:
tty:container)Debug Output
When running with
DEBUG=tty:* ./awmg, you'll see:Or in non-container environments:
This provides valuable insight into how the container detection logic executes in different environments.