[log] Add debug logging to LoadGatewayTLS#5971
Merged
Merged
Conversation
Enhance LoadGatewayTLS with additional logging to improve observability during TLS setup: - Log leaf certificate count after server key pair is loaded - Log success when CA pool is built (mTLS path) - Log when one-way TLS is configured (no client certs required) - Log final TLS configuration summary with mtls status Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds debug logging in LoadGatewayTLS to improve observability around gateway TLS and mTLS setup.
Changes:
- Logs certificate chain count after loading the server key pair.
- Logs CA pool creation and one-way TLS path selection.
- Logs final TLS configuration readiness and mTLS status.
Show a summary per file
| File | Description |
|---|---|
internal/server/gateway_tls.go |
Adds debug logs throughout TLS configuration loading. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
| return nil, fmt.Errorf("failed to load server TLS certificate/key: %w", err) | ||
| } | ||
| logGatewayTLS.Print("server TLS key pair loaded") | ||
| logGatewayTLS.Printf("server TLS key pair loaded: leafCertCount=%d", len(serverCert.Certificate)) |
| logGatewayTLS.Print("one-way TLS configured: client certificates not required") | ||
| } | ||
|
|
||
| logGatewayTLS.Printf("gateway TLS configuration ready: minVersion=TLS1.2, mtls=%v", caPath != "") |
Collaborator
|
@copilot address the review feedback |
- Rename leafCertCount to certChainLen to accurately reflect that len(serverCert.Certificate) is the DER cert chain length, not a leaf count - Replace hard-coded "TLS1.2" with tls.VersionName(cfg.MinVersion) so the logged value always reflects the actual configured minimum version
Contributor
Both issues addressed in the latest commit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhances
internal/server/gateway_tls.gowith additional debug logging calls inLoadGatewayTLSto improve observability during TLS configuration setup.Changes
File modified:
internal/server/gateway_tls.goLog calls added/improved:
Validation
go build ./...passesgo vet ./...passesLogger
Reuses existing
var logGatewayTLS = logger.New("server:tls")— no new logger declaration needed.