Reconcile AGENTS/CONTRIBUTING docs with current config and auth behavior#6018
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix missing GH_TOKEN in AGENTS.md environment variables
Reconcile AGENTS/CONTRIBUTING docs with current config and auth behavior
May 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reconciles AGENTS.md and CONTRIBUTING.md with actual behavior surfaced by the nightly docs reconciliation: clarifies the GitHub token fallback priority, fills in missing JSON-stdin/TOML quick-reference fields, and adds make help to the contributor command list.
Changes:
- Clarify
GITHUB_PERSONAL_ACCESS_TOKENas third-priority and addGH_TOKENas lowest-priority fallback, matchinginternal/envutil/github.go. - Note additional optional JSON-stdin fields (
entrypoint,entrypointArgs,mounts,connectTimeout) and point todocs/CONFIGURATION.md/config.example.tomlfor full coverage. - Document
make helpinCONTRIBUTING.md.
Show a summary per file
| File | Description |
|---|---|
| AGENTS.md | Aligns token priority docs with LookupGitHubToken and broadens JSON/TOML field references. |
| CONTRIBUTING.md | Adds make help to the documented build/dev command set. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly docs reconciliation flagged drift between
AGENTS.md/CONTRIBUTING.mdand the implemented behavior. The main gaps were token fallback priority clarity and missing quick-reference mentions for supported config fields andmake help.Auth token priority alignment (
AGENTS.md)GITHUB_PERSONAL_ACCESS_TOKENas the third-priority fallback.GH_TOKENas the lowest-priority fallback (GitHub CLI-provided token path).JSON stdin/TOML quick-reference completeness (
AGENTS.md)entrypoint,entrypointArgs,mountsconnectTimeoutdocs/CONFIGURATION.mdconfig.example.tomlkeepalive_interval,sequential_launch,guards_mode.Make target discoverability (
CONTRIBUTING.md)make helpto the documented command set so contributors can enumerate available targets directly.