Skip to content

docs: reconcile documentation with implementation (9 discrepancies)#6686

Merged
lpcox merged 4 commits into
mainfrom
copilot/fix-docs-auth-token-vars
May 29, 2026
Merged

docs: reconcile documentation with implementation (9 discrepancies)#6686
lpcox merged 4 commits into
mainfrom
copilot/fix-docs-auth-token-vars

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 29, 2026

Nightly reconciliation identified 9 documentation gaps where implementation behavior wasn't reflected in README.md, AGENTS.md, or docs/ENVIRONMENT_VARIABLES.md.

README.md

  • Authentication — New section with token priority table (GITHUB_MCP_SERVER_TOKENGITHUB_TOKENGITHUB_PERSONAL_ACCESS_TOKENGH_TOKEN), matching internal/envutil/github.go:29–32
  • Tracing — New section with OTEL_EXPORTER_OTLP_ENDPOINT, OTEL_EXPORTER_OTLP_HEADERS, OTEL_SERVICE_NAME vars, matching internal/cmd/tracing.go and internal/tracing/config_resolver.go
  • Gateway Configuration — New section with key gateway fields table including trusted_bots / trustedBots; links to docs/CONFIGURATION.md for rate_limit_threshold, rate_limit_cooldown, and the full field list
  • Env var pointer — Broadened "Containerized-only startup env vars" line to "A complete reference for all environment variables — including guard policy, TLS, tracing, authentication tokens, and containerized deployment"

AGENTS.md

  • Config Examples — Added note pointing to docs/CONFIGURATION.md for trusted_bots, rate_limit_threshold, rate_limit_cooldown
  • TOML args example — Added -e NO_COLOR=1 -e TERM=dumb to match config.example.toml best practice; prevents ANSI codes from breaking JSON parsing
  • make test-all — Both Quick Start and All Tests descriptions updated to mention the implicit binary build step

docs/ENVIRONMENT_VARIABLES.md

  • TAVILY_API_KEY — Added to Test/Development Overrides; enables real Tavily API tests in test/integration/ (skipped when absent)
  • HOST/MODE attribution — Containerized Deployment Variables section updated: both run.sh and run_containerized.sh read MCP_GATEWAY_HOST and MCP_GATEWAY_MODE (previously attributed only to run_containerized.sh)

Copilot AI linked an issue May 29, 2026 that may be closed by this pull request
Fix 9 discrepancies identified in nightly reconciliation report:

Critical:
- README.md: Add Authentication section with GitHub token priority order
  (GITHUB_MCP_SERVER_TOKEN > GITHUB_TOKEN > GITHUB_PERSONAL_ACCESS_TOKEN > GH_TOKEN)
- README.md: Add Tracing section with OTEL_EXPORTER_OTLP_ENDPOINT,
  OTEL_EXPORTER_OTLP_HEADERS, OTEL_SERVICE_NAME env var references
- README.md: Broaden line ~62 pointer to docs/ENVIRONMENT_VARIABLES.md
  from 'containerized-only' to 'complete reference for all env vars'

Important:
- README.md: Add Gateway Configuration section with trusted_bots field table
- AGENTS.md: Add note in Config Examples pointing to docs/CONFIGURATION.md
  for full field list including trusted_bots, rate_limit_threshold, rate_limit_cooldown
- docs/ENVIRONMENT_VARIABLES.md: Add TAVILY_API_KEY under Test/Development Overrides
- docs/ENVIRONMENT_VARIABLES.md: Update Containerized Deployment Variables to
  note that both run.sh and run_containerized.sh use HOST and MODE

Minor:
- AGENTS.md: Add -e NO_COLOR=1 -e TERM=dumb to TOML args example
- AGENTS.md: Update make test-all descriptions to mention implicit build step
Copilot AI changed the title [WIP] Fix documentation for auth token environment variables docs: reconcile documentation with implementation (9 discrepancies) May 29, 2026
Copilot finished work on behalf of lpcox May 29, 2026 12:58
Copilot AI requested a review from lpcox May 29, 2026 12:58
@lpcox lpcox marked this pull request as ready for review May 29, 2026 13:09
Copilot AI review requested due to automatic review settings May 29, 2026 13:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documentation-only reconciliation that closes 9 gaps identified by the nightly docs reconciler, aligning README.md, AGENTS.md, and docs/ENVIRONMENT_VARIABLES.md with the current implementation of token lookup, tracing, gateway configuration, container runtime variables, and the test/build targets.

Changes:

  • README gains Authentication, Tracing, and Gateway Configuration sections (token priority, OTEL vars, key gateway fields including trusted_bots).
  • AGENTS.md clarifies make test-all build behavior and adds NO_COLOR=1/TERM=dumb to the GitHub stdio Docker example, plus a pointer to docs/CONFIGURATION.md for the full field list.
  • docs/ENVIRONMENT_VARIABLES.md adds TAVILY_API_KEY and re-attributes MCP_GATEWAY_HOST/MCP_GATEWAY_MODE to both run.sh and run_containerized.sh.
Show a summary per file
File Description
README.md Adds Authentication, Tracing, and Gateway Configuration sections; broadens env-vars pointer line.
AGENTS.md Notes test-all build behavior, expands GitHub stdio args with NO_COLOR/TERM, adds a CONFIGURATION.md pointer.
docs/ENVIRONMENT_VARIABLES.md Adds TAVILY_API_KEY row; clarifies that MCP_GATEWAY_HOST/MCP_GATEWAY_MODE are read by both run.sh and run_containerized.sh.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 2

Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated
lpcox and others added 2 commits May 29, 2026 06:14
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@lpcox lpcox merged commit f0178ab into main May 29, 2026
3 checks passed
@lpcox lpcox deleted the copilot/fix-docs-auth-token-vars branch May 29, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📚 Documentation Reconciliation Report - 2026-05-28

3 participants