[test-improver] Improve tests for tracing package

[github-actions]

Test Improvements: tracing package

Files Analyzed

• Test Files: internal/tracing/parse_headers_test.go, internal/tracing/http_test.go
• Package: internal/tracing

Improvements Made

1. Increased Coverage

• ✅ Added TestParseOTLPHeadersWithDecoder_InvalidPercentEncoding — exercises the url.PathUnescape error branch in parseOTLPHeadersWithDecoder (previously uncovered). Verifies the raw value is preserved when percent-decoding fails (e.g. %GZ is not valid percent-encoding).

• ✅ Added TestParseOTLPHeadersWithDecoder_ValidPercentEncoding — documents and verifies that well-formed percent-encoded values are decoded when decodeValues=true.

• ✅ Added TestParseOTLPHeadersWithDecoder_NoDecoding — documents and verifies that percent-encoded values are preserved as-is when decodeValues=false.

• ✅ Added TestWrapHTTPHandler_PatternMethodMismatch_ClearsRoute — exercises the else { route = "" } branch in WrapHTTPHandler (previously uncovered). This path is triggered when r.Pattern contains a method prefix that differs from the actual request method.

• Previous Coverage: 96.4%

• New Coverage: 97.6%

• Improvement: +1.2%

2. Better Testing Patterns

• ✅ New tests use table-driven style where multiple variants are needed
• ✅ Tests include descriptive names following Test<Func>_<Scenario> convention
• ✅ Tests are independent with no side effects

Test Execution

All tests pass:

ok  	github.com/github/gh-aw-mcpg/internal/tracing	0.017s	coverage: 97.6% of statements

All other Go tests continue to pass (make test-all).

Why These Changes?

The internal/tracing package had two meaningful uncovered branches:

1. parseOTLPHeadersWithDecoder — The url.PathUnescape error path was untested. This is a real defensive code path that protects against invalid percent-encoded OTLP header values arriving via the OTEL_EXPORTER_OTLP_HEADERS environment variable.

2. WrapHTTPHandler — The route = "" else-branch when the pattern's HTTP method doesn't match the request method was untested. While this rarely occurs in normal mux routing, it is a defensive code path worth covering.

---

Generated by Test Improver Workflow
Focuses on better patterns, increased coverage, and more stable tests

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• index.crates.io

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "index.crates.io"

See Network Configuration for more information.

Generated by Test Improver · sonnet46 4.9M · ◷

[Copilot]

Pull request overview

This PR improves unit test coverage in internal/tracing by adding targeted tests for previously uncovered defensive branches in OTLP header parsing and HTTP handler route extraction.

Changes:

• Added coverage for parseOTLPHeadersWithDecoder percent-decoding behavior (valid decode, invalid decode fallback, and no-decoding mode).
• Added coverage for the WrapHTTPHandler branch where r.Pattern contains a mismatched HTTP method prefix (forcing route = "").

Show a summary per file

File	Description
internal/tracing/parse_headers_test.go	Adds tests for percent-decoding success/failure and decode toggle behavior in OTLP header parsing.
internal/tracing/http_test.go	Adds a new test to hit the defensive route = "" branch when the request pattern’s method mismatches the request method.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 6

[lpcox]

@copilot address review feedback

[Copilot]

@copilot address review feedback

Addressed in 435c8a8. The tracing HTTP mismatch test now asserts the emitted span omits http.route while still checking the defensive no-panic path, and the branch passes targeted and full repo validation.