Skip to content

Document --otlp-sample-rate in tracing docs#6798

Merged
lpcox merged 2 commits into
mainfrom
copilot/fix-otlp-sample-rate-documentation
May 31, 2026
Merged

Document --otlp-sample-rate in tracing docs#6798
lpcox merged 2 commits into
mainfrom
copilot/fix-otlp-sample-rate-documentation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 31, 2026

Nightly docs reconciliation found a minor drift: --otlp-sample-rate exists in CLI (internal/cmd/tracing.go) but was not discoverable in user-facing docs. This PR reconciles tracing documentation so the sampling control is visible where OTLP configuration is described.

  • README: Tracing flag discoverability

    • Added --otlp-sample-rate <float> to the Tracing section alongside existing OTLP env var guidance.
    • Documented accepted range (0.0–1.0) and default (1.0).
  • CONTRIBUTING: Advanced flag usage

    • Added an explicit advanced CLI example showing tracing endpoint + sample rate configuration.
./awmg --config config.toml --otlp-endpoint http://localhost:4318 --otlp-sample-rate 0.25

Copilot AI linked an issue May 31, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix documentation for --otlp-sample-rate flag Document --otlp-sample-rate in tracing docs May 31, 2026
Copilot finished work on behalf of lpcox May 31, 2026 13:27
Copilot AI requested a review from lpcox May 31, 2026 13:27
@lpcox lpcox marked this pull request as ready for review May 31, 2026 13:46
Copilot AI review requested due to automatic review settings May 31, 2026 13:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reconciles user-facing tracing documentation with the existing CLI support for configuring OTLP sampling.

Changes:

  • Adds --otlp-sample-rate <float> documentation to the README tracing section, including range and default.
  • Adds an advanced CONTRIBUTING example showing OTLP endpoint and sample rate usage together.
Show a summary per file
File Description
README.md Documents the OTLP sample rate flag alongside tracing configuration guidance.
CONTRIBUTING.md Adds an example command for enabling OTLP tracing with a 25% sample rate.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@lpcox lpcox merged commit 7f25713 into main May 31, 2026
16 checks passed
@lpcox lpcox deleted the copilot/fix-otlp-sample-rate-documentation branch May 31, 2026 13:50
@github-actions github-actions Bot mentioned this pull request Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

📚 Documentation Reconciliation Report - 2026-05-30

3 participants