Collapse RPC logging split API and remove duplicated tag-branching

[Copilot]

RPC request/response logging exposed split APIs for with/without agent tags, which forced repeated shouldAttachTags branching in connection logging. This change collapses logging to a single request/response API with optional tag slices and removes duplicate branching at call sites.

• Logger API consolidation (internal/logger/rpc_logger.go)

  • Reduced 4 public wrappers (LogRPC* + LogRPC*WithAgentSnapshot) to 2 public functions:
    • LogRPCRequest(..., agentSecrecy, agentIntegrity []string)
    • LogRPCResponse(..., err, agentSecrecy, agentIntegrity []string)
  • Kept tag attachment optional via nil slices.

• Connection logging deduplication (internal/mcp/connection_logging.go, internal/mcp/connection.go)

  • Removed repeated if shouldAttachTags branches from outbound/inbound logging paths.
  • Introduced snapshot-to-tags extraction once and passed a nil-or-real snapshot through logging calls.
  • Simplified helper signatures by removing the boolean branch-control parameter where snapshot nilability already encodes intent.

• Call-site and test alignment

  • Updated logger call sites and tests to use the unified API.
  • Renamed/adjusted test cases and comments that referenced removed split-wrapper functions.

// Before: branch at every call site
if shouldAttachTags {
    logger.LogRPCRequestWithAgentSnapshot(dir, serverID, method, payload, snapshot.Secrecy, snapshot.Integrity)
} else {
    logger.LogRPCRequest(dir, serverID, method, payload)
}

// After: single call, optional tags
secrecy, integrity := snapshotTags(snapshot) // nil,nil when no snapshot
logger.LogRPCRequest(dir, serverID, method, payload, secrecy, integrity)

[Copilot]

Pull request overview

This PR simplifies RPC request/response logging by collapsing split “with/without agent tags” logger APIs into a single API that accepts optional tag slices, and then removes duplicated tag-attachment branching in MCP connection logging.

Changes:

• Consolidated LogRPCRequest/LogRPCResponse into unified functions that accept optional agentSecrecy/agentIntegrity slices.
• Removed repeated shouldAttach* branching at connection logging call sites by passing a nil-or-real *AgentTagsSnapshot and extracting tags once.
• Updated MCP and logger tests/comments to align with the unified logging API.

Show a summary per file

File	Description
internal/logger/rpc_logger.go	Collapses RPC request/response logging APIs to accept optional agent tag slices.
internal/logger/rpc_logger_test.go	Updates tests to call unified APIs; keeps coverage for tagged/untagged JSONL behavior.
internal/mcp/connection.go	Deduplicates tag-attachment branching by selecting a nil-or-real logging snapshot once.
internal/mcp/connection_logging.go	Introduces snapshotTags helper and removes duplicated logger branching in request/response logging helpers.
internal/mcp/connection_logging_test.go	Updates helper calls to the new snapshot-based signature.
internal/mcp/sdk_method_dispatch_test.go	Updates test comments to reflect unified optional-tag logging behavior.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 6/6 changed files
• Comments generated: 0