fix(schema): add timeout fields to embedded JSON schema#6908
Merged
Conversation
Add connectTimeout, connect_timeout, toolTimeout, and tool_timeout to the httpServerConfig schema definition. Add toolTimeout and tool_timeout to stdioServerConfig. These fields are already supported by the config loader but were missing from the schema, causing validation failures for configs using legacy snake_case timeout fields. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the embedded MCP Gateway JSON Schema to recognize timeout fields that are already supported by the stdin config loader, preventing schema validation from rejecting otherwise-valid configurations (notably legacy snake_case timeout keys).
Changes:
- Add
connectTimeout/connect_timeoutandtoolTimeout/tool_timeoutto the HTTP server schema definition. - Add
toolTimeout/tool_timeoutto the stdio server schema definition. - Reformat several schema arrays for readability/consistency.
Show a summary per file
| File | Description |
|---|---|
| internal/config/schema/mcp-gateway-config.schema.json | Adds missing timeout fields (including legacy aliases) to the embedded schema so schema-validation matches supported stdin config fields. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
connectTimeout,connect_timeout,toolTimeout, andtool_timeoutto the HTTP server schema definition, andtoolTimeout/tool_timeoutto the stdio server schema. These fields are already supported by the config loader but were missing from the embedded schema, causing validation to reject configs that use legacy snake_case timeout fields.Failing test fixed:
TestLoadFromStdin_HTTPServerWithLegacySnakeCaseTimeoutFields