refactor: remove direct pflag import from tracing.go

[Copilot]

internal/cmd/tracing.go was the only file in the package with a direct github.com/spf13/pflag import, solely because registerTracingFlags accepted *pflag.FlagSet while every other flag-registration helper in the package accepts *cobra.Command.

Changes

• internal/cmd/tracing.go — change registerTracingFlags signature from *pflag.FlagSet → *cobra.Command; call cmd.Flags() internally; drop pflag import
• internal/cmd/proxy.go — update call site: registerTracingFlags(cmd.Flags(), …) → registerTracingFlags(cmd, …)
• internal/cmd/tracing_helpers_test.go, flags_tracing_test.go — update test call sites to match new signature

// Before
func registerTracingFlags(flags *pflag.FlagSet, ...) {
    flags.StringVar(...)
}
// Called as: registerTracingFlags(cmd.Flags(), &otlpEndpoint, ...)

// After — no pflag import needed
func registerTracingFlags(cmd *cobra.Command, ...) {
    flags := cmd.Flags()
    flags.StringVar(...)
}
// Called as: registerTracingFlags(cmd, &otlpEndpoint, ...)

[Copilot]

Pull request overview

This PR refactors tracing flag registration in internal/cmd to align with the package’s existing pattern of registering flags via *cobra.Command, eliminating the only direct pflag import in the package.

Changes:

• Refactor registerTracingFlags to accept *cobra.Command and call cmd.Flags() internally.
• Update the proxy command and tests to call registerTracingFlags(cmd, ...) instead of passing cmd.Flags().
• Demote github.com/spf13/pflag in go.mod from a direct requirement to an indirect dependency (still pulled in via cobra).

Show a summary per file

File	Description
internal/cmd/tracing.go	Updates registerTracingFlags signature to take *cobra.Command and removes direct pflag import.
internal/cmd/proxy.go	Updates tracing flag registration call site to pass the command instead of its FlagSet.
internal/cmd/tracing_helpers_test.go	Updates test call site to match the new registerTracingFlags signature.
internal/cmd/flags_tracing_test.go	Updates multiple test call sites to match the new registerTracingFlags signature.
go.mod	Moves spf13/pflag to indirect to reflect no direct imports in this module.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 5/5 changed files
• Comments generated: 0