[test-improver] Improve tests for mcp pagination helpers

[github-actions]

File Analyzed

• Test File: internal/mcp/pagination_test.go
• Package: internal/mcp

Improvements Made

1. Increased Coverage

Three new tests added to cover previously-untested error paths in the generic helpers callParamMethod and listMCPItems:

• ✅ TestCallParamMethod_UnmarshalError — covers the unmarshalParams error branch, reached by injecting a non-nil sdk.ClientSession{} so requireSession() passes, then passing a channel value that json.Marshal cannot encode
• ✅ TestCallParamMethod_FnError — covers the fn(params) error return path in callParamMethod
• ✅ TestListMCPItems_PaginateError — covers the paginateAll error propagation path in listMCPItems

Previous Coverage:

Function	Before	After
callParamMethod	77.8%	100.0%
listMCPItems	85.7%	100.0%
internal/mcp total	84.0%	84.5%

2. Cleaner Test Structure

• Uses t.Run-style subtests where applicable
• Follows existing table-driven and named-test conventions in the file
• Uses require.Error / assert.ErrorIs for precise error assertions

Test Execution

All Go tests pass:

ok  github.com/github/gh-aw-mcpg/internal/mcp  2.3s

Why These Changes?

callParamMethod and listMCPItems are generic helpers used by all MCP list/call operations. Their error-handling branches were not directly tested — coverage came only from higher-level tests that happened to reach the happy path. The new tests exercise the error paths directly using a zero-value sdk.ClientSession{} pointer (sufficient to pass the nil check in requireSession) and unmarshalable inputs, making the coverage complete without requiring a real MCP server connection.

---

Generated by Test Improver Workflow
Focuses on better patterns, increased coverage, and more stable tests

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• index.crates.io

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "index.crates.io"

See Network Configuration for more information.

Generated by Test Improver · sonnet46 3.8M · ◷

[Copilot]

Pull request overview

This PR improves unit test coverage for the generic MCP pagination/helpers in internal/mcp, specifically exercising previously untested error paths to ensure failures are propagated correctly.

Changes:

• Added a test covering parameter marshaling failure in callParamMethod (via an unmarshalable channel value).
• Added a test covering propagation of handler (fn) errors in callParamMethod.
• Added a test covering pagination/fetch error propagation through listMCPItems.

Show a summary per file

File	Description
internal/mcp/pagination_test.go	Adds targeted tests for error branches in callParamMethod and listMCPItems to increase coverage and improve confidence in error propagation.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 1