Refactor MCP list methods via shared generic SDK pagination adapter

[Copilot]

listTools, listResources, and listPrompts had the same cursor-pagination closure structure repeated with only SDK types changed. This PR removes that structural duplication while preserving existing list behavior and result shapes.

• Core refactor

  • Added listSDKItems in internal/mcp/pagination.go to adapt SDK list responses into paginatedPage and delegate to listMCPItems.
  • Keeps pagination/session/response marshalling logic centralized in one path.

• Connection method simplification

  • Updated internal/mcp/connection_methods.go:
    • listTools
    • listResources
    • listPrompts
  • Each method now provides typed adapters (list, toPage, buildResult) instead of duplicating the full closure pattern.

• Coverage update

  • Added TestListSDKItems_NilSession in internal/mcp/pagination_test.go to verify session precondition failure short-circuits before invoking the SDK list callback.

return listSDKItems(c, "tools",
	func(cursor string) (*sdk.ListToolsResult, error) {
		return c.getSDKSession().ListTools(c.ctx, &sdk.ListToolsParams{Cursor: cursor})
	},
	func(result *sdk.ListToolsResult) paginatedPage[*sdk.Tool] {
		return paginatedPage[*sdk.Tool]{Items: result.Tools, NextCursor: result.NextCursor}
	},
	func(items []*sdk.Tool) *sdk.ListToolsResult {
		return &sdk.ListToolsResult{Tools: items}
	},
)

[lpcox]

@copilot fix the failing lint ci check

[Copilot]

Pull request overview

This PR refactors MCP cursor-based list operations to remove duplicated pagination glue across listTools, listResources, and listPrompts, while preserving response shapes and centralizing pagination/session validation in the existing listMCPItems flow.

Changes:

• Added a new generic adapter listSDKItems to bridge SDK list responses into the existing listMCPItems pagination/marshalling pipeline.
• Simplified listTools, listResources, and listPrompts to provide small typed adapters (list, toPage, buildResult) instead of repeating the full pagination closure pattern.
• Added a unit test to verify listSDKItems short-circuits on missing session before invoking the SDK list callback.

Show a summary per file

File	Description
internal/mcp/pagination.go	Introduces listSDKItems as a thin generic adapter on top of listMCPItems.
internal/mcp/pagination_test.go	Adds coverage ensuring session precondition failure prevents invoking the provided SDK list function.
internal/mcp/connection_methods.go	Refactors listTools/listResources/listPrompts to use listSDKItems and remove duplicated pagination boilerplate.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 0

[Copilot]

@copilot fix the failing lint ci check

Fixed in the latest commit. The lint failure was S1016 in pagination_test.go:339 — staticcheck flagged the struct literal used to copy fakeListResult into paginatedPage[fakeItem]. Since the two types have identical field layouts, it's replaced with a direct type conversion: paginatedPage[fakeItem](result).