[test] Add tests for strutil.CopyTrimmedStringIntMap

[github-actions]

Test Coverage Improvement: CopyTrimmedStringIntMap

Function Analyzed

• Package: internal/strutil
• Function: CopyTrimmedStringIntMap
• Previous Coverage: 0%
• New Coverage: 100%
• Package Coverage: 92.0% → 100.0%
• Complexity: Low (2 branches: empty-input guard + key-trimming loop)

Why This Function?

CopyTrimmedStringIntMap had 0% coverage despite being a utility used throughout the codebase for defensive map copying. It was the only uncovered function in the internal/strutil package (all other functions were already at 100%).

The function has clear testable behaviour:

• Early-return nil for nil/empty inputs
• Key whitespace trimming via strings.TrimSpace
• Defensive (independent) copy semantics

Tests Added

• ✅ nil input returns nil
• ✅ empty map returns nil
• ✅ single entry with clean key
• ✅ leading / trailing whitespace trimmed from key
• ✅ tab and newline characters trimmed from key
• ✅ internal whitespace in key is preserved (only edges trimmed)
• ✅ multiple entries, all keys trimmed
• ✅ integer edge cases: zero, negative, max int32
• ✅ whitespace-only key becomes empty-string key
• ✅ defensive copy: changes to the copy do not affect the original
• ✅ changes to the original do not affect the copy
• ✅ nil and empty inputs both produce nil (documented contract)

Coverage Report

Before: 92.0% (strutil package) — CopyTrimmedStringIntMap 0%
After:  100.0% (strutil package) — CopyTrimmedStringIntMap 100%
Improvement: +8% package / +100% function

Test Execution

=== RUN   TestCopyTrimmedStringIntMap
--- PASS: TestCopyTrimmedStringIntMap (0.00s)
=== RUN   TestCopyTrimmedStringIntMap_IsDefensiveCopy
--- PASS: TestCopyTrimmedStringIntMap_IsDefensiveCopy (0.00s)
=== RUN   TestCopyTrimmedStringIntMap_NilNotSameAsEmpty
--- PASS: TestCopyTrimmedStringIntMap_NilNotSameAsEmpty (0.00s)
PASS
ok  github.com/github/gh-aw-mcpg/internal/strutil  0.006s  coverage: 100.0% of statements

---

Generated by Test Coverage Improver
Next run will target the next most complex under-tested function

Warning

Firewall blocked 9 domains

The following domains were blocked by the firewall during workflow execution:

• go.opentelemetry.io
• go.yaml.in
• golang.org
• google.golang.org
• gopkg.in
• goproxy.cn
• goproxy.io
• proxy.golang.org
• releaseassets.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "go.opentelemetry.io"
    - "go.yaml.in"
    - "golang.org"
    - "google.golang.org"
    - "gopkg.in"
    - "goproxy.cn"
    - "goproxy.io"
    - "proxy.golang.org"
    - "releaseassets.githubusercontent.com"

See Network Configuration for more information.

Generated by Test Coverage Improver · sonnet46 5.8M · ◷

[Copilot]

Pull request overview

Adds unit tests to fully cover internal/strutil.CopyTrimmedStringIntMap, validating the function’s key-trimming behavior and defensive-copy semantics so the internal/strutil package reaches full statement coverage.

Changes:

• Introduces table-driven tests for nil/empty inputs and multiple whitespace-trimming cases.
• Adds a defensive-copy test to ensure the returned map is independent of the input map.
• Adds a small contract test asserting both nil and empty inputs return nil.

Show a summary per file

File	Description
internal/strutil/copy_trimmed_string_int_map_test.go	Adds comprehensive tests covering key trimming, nil/empty behavior, and defensive copy semantics for CopyTrimmedStringIntMap.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 2