[test] Add tests for launcher.handleErrorState and launcher.clearServerForRestart

[github-actions]

Test Coverage Improvement: launcher error-handling paths

Functions Analyzed

Function	File	Previous Coverage	New Coverage
handleErrorState	internal/launcher/health_monitor.go	74.1%	100%
clearServerForRestart	internal/launcher/launcher.go	75%	100%
Package total	internal/launcher	93.7%	96.0%

Why These Functions?

Both functions had two-to-four statement blocks that were never exercised:

• clearServerForRestart — the if conn, ok := l.connections[serverID]; ok { conn.Close(); delete(...) } branch was dead because existing tests never established a live connection before calling the function.
• handleErrorState — two paths were unreached:
  1. The inner if consecutiveFailures >= maxConsecutiveRestartFailures log printed when a restart attempt bumps the counter exactly to the cap (not from already being at the cap).
  2. The success path (consecutiveFailures = 0 + info log) when GetOrLaunch succeeds after clearing the error state.

Tests Added

TestClearServerForRestart_WithExistingConnection

• Obtains a real *mcp.Connection from an HTTP mock MCP server via GetOrLaunch
• Verifies the connection is stored in l.connections
• Calls clearServerForRestart and asserts the connection is closed and removed
• ✅ Covers launcher.go lines 345–348

TestHealthMonitor_ErrorStateReachesMaxFailures

• Sets consecutiveFailures = maxConsecutiveRestartFailures - 1 (= 2)
• Calls checkAll() against a failing server
• Asserts the counter increments to exactly maxConsecutiveRestartFailures (= 3)
• ✅ Covers health_monitor.go lines 122–126

TestHealthMonitor_SuccessfulRestartResetsFailureCounter

• Places a server in error state with a non-zero failure count
• Calls checkAll() with a live HTTP mock backend so GetOrLaunch succeeds
• Asserts consecutiveFailures is reset to 0 and server state is running
• ✅ Covers health_monitor.go lines 130–132

Coverage Report

Before: 93.7% (launcher package)
After:  96.0% (launcher package)
Improvement: +2.3 pp

handleErrorState:    74.1% → 100%
clearServerForRestart: 75%  → 100%

Test Execution

All tests pass (17 s, 0 failures):

ok  github.com/github/gh-aw-mcpg/internal/launcher  16.879s

---

Generated by Test Coverage Improver — next run will target the next most complex under-tested function

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

• go.opentelemetry.io
• go.yaml.in
• golang.org
• google.golang.org
• gopkg.in
• proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "go.opentelemetry.io"
    - "go.yaml.in"
    - "golang.org"
    - "google.golang.org"
    - "gopkg.in"
    - "proxy.golang.org"

See Network Configuration for more information.

Generated by Test Coverage Improver · sonnet46 14M · ◷

[Copilot]

Pull request overview

Adds targeted unit tests to improve coverage of internal/launcher error-handling and restart paths, specifically exercising previously-uncovered branches in HealthMonitor.handleErrorState and Launcher.clearServerForRestart.

Changes:

• Adds a test covering clearServerForRestart behavior when a cached HTTP backend connection exists.
• Adds tests covering handleErrorState when restart failures hit the max cap, and when a subsequent restart succeeds and resets the counter.
• Uses an HTTP mock MCP server to obtain real *mcp.Connection instances for the new coverage paths.

Show a summary per file

File	Description
internal/launcher/health_monitor_test.go	Adds new tests to cover handleErrorState and clearServerForRestart branches using failing stdio configs and an HTTP mock MCP server.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 3

[lpcox]

@copilot resolve the merge conflicts in this pull request and address review feedback

[Copilot]

@copilot resolve the merge conflicts in this pull request and address review feedback

Resolved the merge conflict with main and addressed the launcher test review feedback in commit bc7c70aa (added missing defer l.Close() in the affected tests and updated the test comment to match assertions).