refactor: extract registrationErrors helper to deduplicate error-tracking in tool registration

[Copilot]

registerAllToolsSequential and registerAllToolsParallel both contained the same 3-part pattern: declare failedServers []string, accumulate failures, call logRegistrationIncomplete. Any change to failure-tracking semantics had to be applied in two places.

Changes

• New registrationErrors type — encapsulates failed []string + total int with record(serverID) and finish() methods; finish() owns the incomplete-registration log message
• Removed logRegistrationIncomplete — its logic is now solely in registrationErrors.finish()
• Refactored both registration functions to use errs.record() / errs.finish(); each still logs at its own level (LogError vs LogErrorToServer)
• Removed redundant failureCount in the parallel path — replaced by len(errs.failed)

type registrationErrors struct {
    failed []string
    total  int
}

func (e *registrationErrors) record(serverID string) {
    e.failed = append(e.failed, serverID)
}

func (e *registrationErrors) finish() {
    if len(e.failed) > 0 {
        logger.LogError("backend", "Tool registration incomplete: %d of %d backends failed: %v — ...",
            len(e.failed), e.total, e.failed)
    }
}

[Copilot]

Pull request overview

This PR refactors backend tool-registration failure tracking in the unified server by extracting shared “failed server accumulation + final summary log” logic into a dedicated helper type, reducing duplication between sequential and parallel registration paths.

Changes:

• Introduced a registrationErrors helper type to centralize failure tracking (record) and final summary logging (finish).
• Removed the now-redundant logRegistrationIncomplete helper function.
• Simplified the parallel registration summary by deriving the failure count from len(errs.failed).

Show a summary per file

File	Description
internal/server/tool_registry.go	Deduplicates tool-registration error tracking/logging across sequential and parallel registration implementations.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0