Skip to content

Tighten Go Logger workflow scope and validation behavior#7891

Merged
lpcox merged 5 commits into
mainfrom
copilot/aw-fix-go-logger-enhancement
Jun 21, 2026
Merged

Tighten Go Logger workflow scope and validation behavior#7891
lpcox merged 5 commits into
mainfrom
copilot/aw-fix-go-logger-enhancement

Conversation

Copilot AI commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

The Go Logger Enhancement workflow was over-exploring the repository, drifting into unrelated baseline failures, and expanding scope beyond the intended single-file logging change. This updates the workflow prompt so runs stay narrow, cache-aware, and resilient to unrelated repo breakage.

  • Scope control

    • Limit candidate exploration to at most 3 files before selecting a target.
    • Stop searching once 1 strong candidate is identified.
    • Require skipping files already recorded in cache-memory.
  • Validation behavior

    • Instruct the agent to detect pre-existing repo-wide failures before validating its change.
    • Prefer package-scoped go test / go vet first for the edited file’s package.
    • Allow repo-wide checks only when the baseline is clean or the failure is clearly related to the edited file.
  • Guardrails against unrelated fixes

    • Explicitly forbid widening scope to “fix the build” in untouched files.
    • Clarify that unrelated baseline failures should be reported as blockers, not folded into the PR.
  • Compiled workflow update

    • Regenerate go-logger.lock.yml to reflect the prompt changes.

Example of the new validation guidance:

1. Record whether repo-wide verification is already broken before your edit.
2. Run targeted validation for the package you changed first:
   go test ./path/to/package
   go vet ./path/to/package
3. Run repo-wide tests only when they were green before your change, or when a failure clearly points to your edited file.

GitHub Advanced Security started work on behalf of lpcox June 21, 2026 16:03 View session
GitHub Advanced Security finished work on behalf of lpcox June 21, 2026 16:04
Copilot AI changed the title [WIP] Fix Go Logger Enhancement workflow failure Tighten Go Logger workflow scope and validation behavior Jun 21, 2026
Copilot AI requested a review from lpcox June 21, 2026 16:09
Copilot finished work on behalf of lpcox June 21, 2026 16:09
GitHub Advanced Security started work on behalf of lpcox June 21, 2026 16:22 View session
GitHub Advanced Security finished work on behalf of lpcox June 21, 2026 16:23
@lpcox lpcox marked this pull request as ready for review June 21, 2026 17:10
Copilot AI review requested due to automatic review settings June 21, 2026 17:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens the Go Logger Enhancement agent workflow guidance to reduce unnecessary repository exploration, avoid scope creep into unrelated baseline failures, and introduce a more resilient validation sequence (package-scoped checks first), then regenerates the compiled lock workflow accordingly.

Changes:

  • Add explicit guardrails to cap candidate exploration and stop searching once a strong target file is found (while excluding cache-memory processed files).
  • Update validation guidance to detect pre-existing repo-wide failures and prefer package-scoped go test/go vet before broader checks.
  • Regenerate .github/workflows/go-logger.lock.yml to reflect the updated prompt/compiler output.
Show a summary per file
File Description
.github/workflows/go-logger.md Tightens agent prompt constraints (exploration cap, no unrelated fixes) and refines validation guidance toward package-scoped checks first.
.github/workflows/go-logger.lock.yml Regenerated compiled workflow reflecting the prompt changes and updated compiler/runtime wiring.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 7

Comment thread .github/workflows/go-logger.md Outdated
Comment on lines 224 to 228
2. **Run targeted validation for the package you changed first:**
```bash
go build -o awmg
go test ./path/to/package
go vet ./path/to/package
```
Comment thread .github/workflows/go-logger.lock.yml Outdated
# - actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6.4.0
# - actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
# - github/gh-aw-actions/setup@5c2fe865bb4dc46e1450f6ee0d0541d759aea73a # v0.79.6
# - github/gh-aw-actions/setup@v0.79.8
Comment on lines 94 to 97
- name: Setup Scripts
id: setup
uses: github/gh-aw-actions/setup@5c2fe865bb4dc46e1450f6ee0d0541d759aea73a # v0.79.6
uses: github/gh-aw-actions/setup@v0.79.8
with:
Comment on lines 387 to 390
- name: Setup Scripts
id: setup
uses: github/gh-aw-actions/setup@5c2fe865bb4dc46e1450f6ee0d0541d759aea73a # v0.79.6
uses: github/gh-aw-actions/setup@v0.79.8
with:
Comment on lines 1040 to 1043
- name: Setup Scripts
id: setup
uses: github/gh-aw-actions/setup@5c2fe865bb4dc46e1450f6ee0d0541d759aea73a # v0.79.6
uses: github/gh-aw-actions/setup@v0.79.8
with:
Comment on lines 1232 to 1235
- name: Setup Scripts
id: setup
uses: github/gh-aw-actions/setup@5c2fe865bb4dc46e1450f6ee0d0541d759aea73a # v0.79.6
uses: github/gh-aw-actions/setup@v0.79.8
with:
Comment thread .github/workflows/go-logger.lock.yml Outdated
# gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"36616a1939cae5940683f6897a9488aabab85682acc513d372ee612a0f928cb1","body_hash":"ede9106c8085562d4939456899283f909b2a2beeddc3912e74c1e383f4747cc5","compiler_version":"v0.79.6","strict":true,"agent_id":"copilot","engine_versions":{"copilot":"1.0.60"}}
# gh-aw-manifest: {"version":1,"secrets":["COPILOT_GITHUB_TOKEN","GH_AW_CI_TRIGGER_TOKEN","GH_AW_GITHUB_MCP_SERVER_TOKEN","GH_AW_GITHUB_TOKEN","GITHUB_TOKEN"],"actions":[{"repo":"actions/cache","sha":"27d5ce7f107fe9357f9df03efb73ab90386fccae","version":"v5.0.5"},{"repo":"actions/checkout","sha":"df4cb1c069e1874edd31b4311f1884172cec0e10","version":"v6.0.3"},{"repo":"actions/download-artifact","sha":"3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c","version":"v8.0.1"},{"repo":"actions/github-script","sha":"3a2844b7e9c422d3c10d287c895573f7108da1b3","version":"v9.0.0"},{"repo":"actions/setup-go","sha":"4a3601121dd01d1626a1e23e37211e3254c1c06c","version":"v6.4.0"},{"repo":"actions/upload-artifact","sha":"043fb46d1a93c77aae656e7c1c64a875d1fc6a0a","version":"v7.0.1"},{"repo":"github/gh-aw-actions/setup","sha":"5c2fe865bb4dc46e1450f6ee0d0541d759aea73a","version":"v0.79.6"}],"containers":[{"image":"ghcr.io/github/gh-aw-firewall/agent:0.27.2","digest":"sha256:f88e5b17b6b7a600117bc121114d6ce2155c88c983c0c939c5df884f730fa1d6","pinned_image":"ghcr.io/github/gh-aw-firewall/agent:0.27.2@sha256:f88e5b17b6b7a600117bc121114d6ce2155c88c983c0c939c5df884f730fa1d6"},{"image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.2","digest":"sha256:ee39841d980878ebbb87592903b06d31a1af500c71525c9616f7e8e2a27041a4","pinned_image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.2@sha256:ee39841d980878ebbb87592903b06d31a1af500c71525c9616f7e8e2a27041a4"},{"image":"ghcr.io/github/gh-aw-firewall/squid:0.27.2","digest":"sha256:2e3a717e5f19a654cd9a2263beb52012b56bcb68562ec5ae2e42f9d156b49591","pinned_image":"ghcr.io/github/gh-aw-firewall/squid:0.27.2@sha256:2e3a717e5f19a654cd9a2263beb52012b56bcb68562ec5ae2e42f9d156b49591"},{"image":"ghcr.io/github/gh-aw-mcpg:v0.3.25","digest":"sha256:c10331ad17668ef89f38f5e356678788a40b0cd5fef96e8f92e1d9c1de47cbaa","pinned_image":"ghcr.io/github/gh-aw-mcpg:v0.3.25@sha256:c10331ad17668ef89f38f5e356678788a40b0cd5fef96e8f92e1d9c1de47cbaa"},{"image":"ghcr.io/github/github-mcp-server:v1.1.2","digest":"sha256:30197479d8036c7811892bc07e06f9a05c9ef3cdd79bc59f256d50647f95788c","pinned_image":"ghcr.io/github/github-mcp-server:v1.1.2@sha256:30197479d8036c7811892bc07e06f9a05c9ef3cdd79bc59f256d50647f95788c"}]}
# gh-aw-metadata: {"schema_version":"v4","frontmatter_hash":"36616a1939cae5940683f6897a9488aabab85682acc513d372ee612a0f928cb1","body_hash":"9c5d3f1ae16c62e3ff587bd182ad322fa9b0a641f13be30be1d5e9c13e05ec41","compiler_version":"v0.79.8","strict":true,"agent_id":"copilot","engine_versions":{"copilot":"1.0.60"}}
# gh-aw-manifest: {"version":1,"secrets":["COPILOT_GITHUB_TOKEN","GH_AW_CI_TRIGGER_TOKEN","GH_AW_GITHUB_MCP_SERVER_TOKEN","GH_AW_GITHUB_TOKEN","GITHUB_TOKEN"],"actions":[{"repo":"actions/cache","sha":"27d5ce7f107fe9357f9df03efb73ab90386fccae","version":"v5.0.5"},{"repo":"actions/checkout","sha":"df4cb1c069e1874edd31b4311f1884172cec0e10","version":"v6.0.3"},{"repo":"actions/download-artifact","sha":"3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c","version":"v8.0.1"},{"repo":"actions/github-script","sha":"3a2844b7e9c422d3c10d287c895573f7108da1b3","version":"v9.0.0"},{"repo":"actions/setup-go","sha":"4a3601121dd01d1626a1e23e37211e3254c1c06c","version":"v6.4.0"},{"repo":"actions/upload-artifact","sha":"043fb46d1a93c77aae656e7c1c64a875d1fc6a0a","version":"v7.0.1"},{"repo":"github/gh-aw-actions/setup","sha":"v0.79.8","version":"v0.79.8"}],"containers":[{"image":"ghcr.io/github/gh-aw-firewall/agent:0.27.2","digest":"sha256:f88e5b17b6b7a600117bc121114d6ce2155c88c983c0c939c5df884f730fa1d6","pinned_image":"ghcr.io/github/gh-aw-firewall/agent:0.27.2@sha256:f88e5b17b6b7a600117bc121114d6ce2155c88c983c0c939c5df884f730fa1d6"},{"image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.2","digest":"sha256:ee39841d980878ebbb87592903b06d31a1af500c71525c9616f7e8e2a27041a4","pinned_image":"ghcr.io/github/gh-aw-firewall/api-proxy:0.27.2@sha256:ee39841d980878ebbb87592903b06d31a1af500c71525c9616f7e8e2a27041a4"},{"image":"ghcr.io/github/gh-aw-firewall/squid:0.27.2","digest":"sha256:2e3a717e5f19a654cd9a2263beb52012b56bcb68562ec5ae2e42f9d156b49591","pinned_image":"ghcr.io/github/gh-aw-firewall/squid:0.27.2@sha256:2e3a717e5f19a654cd9a2263beb52012b56bcb68562ec5ae2e42f9d156b49591"},{"image":"ghcr.io/github/gh-aw-mcpg:v0.3.25","digest":"sha256:c10331ad17668ef89f38f5e356678788a40b0cd5fef96e8f92e1d9c1de47cbaa","pinned_image":"ghcr.io/github/gh-aw-mcpg:v0.3.25@sha256:c10331ad17668ef89f38f5e356678788a40b0cd5fef96e8f92e1d9c1de47cbaa"},{"image":"ghcr.io/github/github-mcp-server:v1.1.2","digest":"sha256:30197479d8036c7811892bc07e06f9a05c9ef3cdd79bc59f256d50647f95788c","pinned_image":"ghcr.io/github/github-mcp-server:v1.1.2@sha256:30197479d8036c7811892bc07e06f9a05c9ef3cdd79bc59f256d50647f95788c"}]}
@lpcox

lpcox commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

@copilot address review feedback to the .md file but ignore feedback on compiled .lock.yml files

Copilot AI commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

@copilot address review feedback to the .md file but ignore feedback on compiled .lock.yml files

Done. Updated the validation step in go-logger.md to replace the ./path/to/package placeholder with an explanation of how to derive the correct path from the edited file's directory, including a concrete example (internal/launcher/pool.go./internal/launcher). Lock file feedback ignored as requested.

Copilot finished work on behalf of lpcox June 21, 2026 17:17
GitHub Advanced Security started work on behalf of lpcox June 21, 2026 17:19 View session
GitHub Advanced Security finished work on behalf of lpcox June 21, 2026 17:20
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
GitHub Advanced Security started work on behalf of lpcox June 21, 2026 17:31 View session
GitHub Advanced Security finished work on behalf of lpcox June 21, 2026 17:32
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
GitHub Advanced Security started work on behalf of lpcox June 21, 2026 17:40 View session
GitHub Advanced Security finished work on behalf of lpcox June 21, 2026 17:42
@lpcox lpcox merged commit 790a8b7 into main Jun 21, 2026
27 checks passed
@lpcox lpcox deleted the copilot/aw-fix-go-logger-enhancement branch June 21, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants