Fix workflow documentation to use dynamic workspace paths #879
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update .github/agentics/language-support-tester.md to reference the workspace path from github-context instead of hardcoding /workspace/. This ensures the agent uses the correct runtime workspace path when locating test samples. Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Claude
AI
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Language Support Tester agent documentation to use the GitHub Actions runtime workspace path (from github-context) instead of hardcoded /workspace/ paths, ensuring the agent can reliably locate test samples across runner environments.
Changes:
- Replaced hardcoded
/workspace/...sample paths with a{workspace}/...placeholder. - Added guidance to use the workspace path provided in the prompt’s
github-context. - Updated the “Important Notes” section to match the dynamic workspace approach.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lpcox
added a commit
that referenced
this pull request
Feb 11, 2026
Issue #867 reports missing TypeScript/JavaScript and Python test samples for language support testing. These samples were added in PR #879 (commit 97784a4) on Feb 10, 2026 - one day after the issue was created. The issue remained open erroneously. ## Verification **JavaScript/TypeScript** (`test/serena-mcp-tests/samples/js_project/`): - `calculator.js` - Calculator class with methods (add, multiply, greet) - `utils.js` - formatNumber utility function - `package.json` - Project metadata for language server detection **Python** (`test/serena-mcp-tests/samples/python_project/`): - `calculator.py` - Calculator class with type hints and methods - `utils.py` - format_number utility function All files match specifications in `.github/agentics/language-support-tester.md`. No code changes required. <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>[language-support] TypeScript/JavaScript and Python test samples missing for language support testing</issue_title> > <issue_description>## Summary > > The language support tester workflow cannot fully test TypeScript/JavaScript and Python support because the required test sample directories do not exist in the repository. > > ## What Works > > ✅ **Go Language Support** - Successfully tested and verified: > - `find_symbol` correctly identifies functions in `main.go` and other Go files > - `get_symbols_overview` returns accurate symbol listings for Go files > - `find_referencing_symbols` successfully traces references across Go files > - Language server responds correctly to all queries > > ## What's Missing > > ❌ **TypeScript/JavaScript Test Samples** > - Expected location: `/workspace/test/serena-mcp-tests/samples/js_project/` > - Status: Directory does not exist > - Impact: Cannot test TypeScript/JavaScript language server functionality > > ❌ **Python Test Samples** > - Expected location: `/workspace/test/serena-mcp-tests/samples/python_project/` > - Status: Directory does not exist > - Impact: Cannot test Python language server functionality > > ## Steps to Reproduce > > 1. Run the language-support-tester workflow > 2. Attempt to activate TypeScript/JavaScript project at specified path > 3. Observe that the path does not exist > > ## Requested Fix > > Add test sample directories with minimal but sufficient code to test language server functionality: > > **JavaScript/TypeScript samples** (`test/serena-mcp-tests/samples/js_project/`): > - Simple function definitions > - Class with methods > - Import/export statements > - `package.json` for project detection > > **Python samples** (`test/serena-mcp-tests/samples/python_project/`): > - Simple function definitions (e.g., `format_number`) > - Class with methods (e.g., `Calculator` class with `add` method) > - Import statements > - Sufficient for testing `find_symbol`, `get_symbols_overview`, and `find_referencing_symbols` > > ## Testing Guidelines Reference > > From `.github/agentics/language-support-tester.md`: > - TypeScript/JavaScript: Test samples at `/workspace/test/serena-mcp-tests/samples/js_project/` > - Python: Test samples at `/workspace/test/serena-mcp-tests/samples/python_project/` with `calculator.py`, `utils.py` containing `Calculator` class, `add` method, `format_number` function > > ## Workaround > > Currently, only Go language support can be tested using the existing Go source files in the repository root and would-be `internal/` directory. > > > > > > AI generated by [Language Support Tester](https://github.com/github/gh-aw-mcpg/actions/runs/21822059652) > > - [x] expires <!-- gh-aw-expires: 2026-02-16T10:53:55.886Z --> on Feb 16, 2026, 10:53 AM UTC > > <!-- gh-aw-agentic-workflow: Language Support Tester, engine: copilot, run: https://github.com/github/gh-aw-mcpg/actions/runs/21822059652 --> > > <!-- gh-aw-workflow-id: language-support-tester --></issue_description> > > ## Comments on the Issue (you are @claude[agent] in this section) > > <comments> > </comments> > </details> <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes #867
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Language Support Tester workflow documentation hardcoded
/workspace/paths, preventing the agent from locating test samples at runtime. GitHub Actions workspace paths vary by environment (e.g.,/home/runner/work/{repo}/{repo}).Changes
.github/agentics/language-support-tester.md:/workspace/paths to{workspace}placeholdergithub-contextsectionThe agent now receives the actual runtime workspace path via
__GH_AW_GITHUB_WORKSPACE__in the github-context and can correctly construct paths to test samples:Notes
Test sample files already exist in the repository with expected content (
Calculatorclass,addmethod,format_numberfunction,package.json). No code changes required.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
example.com/tmp/go-build380999041/b279/launcher.test /tmp/go-build380999041/b279/launcher.test -test.testlogfile=/tmp/go-build380999041/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/cgo HEAD ache/go/1.25.6/x64/pkg/tool/linu-o it base64 /usr/bin/dirname/tmp/go-build380999041/b263/_pkg_.a 8.o comm�� /go-build Fix workflow docgithub.com/github/gh-aw-mcpg/internal/config x_amd64/vet(dns block)invalid-host-that-does-not-exist-12345.com/tmp/go-build380999041/b264/config.test /tmp/go-build380999041/b264/config.test -test.testlogfile=/tmp/go-build380999041/b264/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/c-c=4 kdf/cast.go ache/go/1.25.6/x-importcfg cal/bin/git base64 /usr/sbin/git 6.o -c 64/src/runtime/cgo tf "%s%s", sep, $0; sep=RS } x_amd64/compile --abbrev-ref HEAD /usr/bin/base64 x_amd64/compile(dns block)nonexistent.local/tmp/go-build380999041/b279/launcher.test /tmp/go-build380999041/b279/launcher.test -test.testlogfile=/tmp/go-build380999041/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/cgo HEAD ache/go/1.25.6/x64/pkg/tool/linu-o it base64 /usr/bin/dirname/tmp/go-build380999041/b263/_pkg_.a 8.o comm�� /go-build Fix workflow docgithub.com/github/gh-aw-mcpg/internal/config x_amd64/vet(dns block)slow.example.com/tmp/go-build380999041/b279/launcher.test /tmp/go-build380999041/b279/launcher.test -test.testlogfile=/tmp/go-build380999041/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 64/src/runtime/cgo HEAD ache/go/1.25.6/x64/pkg/tool/linu-o it base64 /usr/bin/dirname/tmp/go-build380999041/b263/_pkg_.a 8.o comm�� /go-build Fix workflow docgithub.com/github/gh-aw-mcpg/internal/config x_amd64/vet(dns block)this-host-does-not-exist-12345.com/tmp/go-build380999041/b288/mcp.test /tmp/go-build380999041/b288/mcp.test -test.testlogfile=/tmp/go-build380999041/b288/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true 737903/b083/_pkg_.a JWKP/08bK8wSDgKwIadp3JWKP x_amd64/vet cal/bin/git /unix /x64=/_/GOROOT x_amd64/vet o_.o�� ache/go/1.25.6/x-errorsas ache/go/1.25.6/x-ifaceassert x_amd64/vet 737903/b083/symabash HEAD ndor/bin/git x_amd64/vet(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt