Fix sibling smoke workflows#39
Merged
davidslater merged 3 commits intomainfrom May 8, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw-threat-detection/sessions/fffc39f9-00be-416a-8b22-e28c31f5dfda Co-authored-by: davidslater <12449447+davidslater@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
davidslater
May 7, 2026 23:42
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the generated containerized sibling smoke workflows so they parse correctly and show readable workflow names in GitHub Actions, and adds a top-level “Smoke” meta-workflow to dispatch all smoke workflows together.
Changes:
- Renames containerized sibling workflows to readable
Smoke <engine> Containerizednames. - Updates the containerized extraction step to use runtime
$RUNNER_TEMPexpansion in committed sibling workflows. - Adds a manual
Smokeworkflow that dispatches all base + containerized smoke workflows.
Show a summary per file
| File | Description |
|---|---|
| scripts/create-threat-detection-sibling-workflows.py | Updates sibling workflow names and attempts to adjust RUNNER_TEMP handling in generated steps. |
| README.md | Documents the new top-level Smoke meta-workflow dispatch behavior. |
| .github/workflows/smoke.yml | New meta-workflow that dispatches all six smoke workflows via gh workflow run. |
| .github/workflows/smoke-copilot-container.lock.yml | Renames workflow + switches temp-path handling to ${RUNNER_TEMP} in the container extraction step. |
| .github/workflows/smoke-claude-container.lock.yml | Renames workflow + switches temp-path handling to ${RUNNER_TEMP} in the container extraction step. |
| .github/workflows/smoke-codex-container.lock.yml | Renames workflow + switches temp-path handling to ${RUNNER_TEMP} in the container extraction step. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/6 changed files
- Comments generated: 2
Agent-Logs-Url: https://github.com/github/gh-aw-threat-detection/sessions/45ed7254-448f-42ba-bca7-cde1bad1b1c9 Co-authored-by: davidslater <12449447+davidslater@users.noreply.github.com>
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
${{...}}-looking RUNNER_TEMP source strings while preserving generated output.