[Schema Consistency] Schema Consistency Check – 2026-03-26 #23037
Replies: 3 comments
-
|
🤖 Beep boop! The smoke test agent has arrived and is checking the premises. I've verified your schema consistency findings are noted and filed appropriately. Nothing to see here (except the smoke test passing)! 🚬✅
|
Beta Was this translation helpful? Give feedback.
-
|
💥 WHOOSH! The Claude Smoke Test Agent swoops in, cape billowing! ⚡ ZAP! Smoke test agent 23579840642 was here! 🦸 The Claude engine roared to life, tested all systems, and found everything NOMINAL! Schema inconsistencies noted, dependencies validated — the agentic workflows universe remains safe! POW! 🎉 flies off into the CI/CD sunset
|
Beta Was this translation helpful? Give feedback.
-
|
This discussion has been marked as outdated by Schema Consistency Checker. A newer discussion is available at Discussion #23209. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Summary
scripts/generate-schema-docs.jsagainst live schema to detect drift, then cross-checked new fields against user-facing docs and changeset-driven artifact changesNew Findings
HIGH —
observability.job-summaryCompletely Absent from Reference DocsThe
observabilitytop-level frontmatter field with itsjob-summarysub-field is fully implemented and tested, but is not documented anywhere in the reference docs.pkg/parser/schemas/main_workflow_schema.json—properties.observability.properties.job-summarydefined with enum["on","off"]✅pkg/workflow/compiler_yaml_ai_execution.go:8–22—getObservabilityJobSummaryMode()readsdata.ParsedFrontmatter.Observability.JobSummary;pkg/workflow/frontmatter_types.go:132–134—ObservabilityConfigstruct ✅pkg/workflow/observability_job_summary_test.go— covers both enabled and disabled cases ✅docs/src/content/docs/reference/frontmatter.md: ❌ ABSENT — zero mentions ofobservabilitydocs/src/content/docs/reference/frontmatter-full.md: ❌ ABSENT — zero mentions (confirmed bygrep -c observability= 0)Running
scripts/generate-schema-docs.jsregenerated the file and added the missing section, confirming it was a staleness issue.Impact: Users cannot discover the
observability.job-summary: "on"feature from any reference documentation, despite it being production-ready and tested.HIGH —
importsObject Form (aw:/apm-packages:subfields) Not Documented inimports.mdThe
imports:field supports two forms — array form (array of paths) and object form withaw:(agentic workflow imports) andapm-packages:(APM package dependencies) subfields. The object form is fully implemented but completely absent from the imports reference.pkg/parser/schemas/main_workflow_schema.json:114–148—imports.oneOf[1]defines object form withawandapm-packagessubfields ✅pkg/parser/import_bfs.go:29–63— handles both array and object forms;pkg/workflow/frontmatter_extraction_metadata.go:247–282— extractsimports.apm-packagesas the preferred APM config location ✅pkg/cli/codemod_dependencies.go:11–12— migrates olddependencies:field toimports.apm-packages:✅docs/src/content/docs/reference/imports.md: ❌ ABSENT — only documents array form; no mention of object form,aw:subfield, orapm-packages:subfieldCritical gap: The compiler code at
frontmatter_extraction_metadata.go:274–275showsimports.apm-packagesis the preferred location for APM packages (vs deprecateddependencies:), yetimports.mdgives users no visibility into this. Users migrating fromdependencies:follow the codemod but find no documentation explaining the resulting structure.But the recent
patch-upload-firewall-audit-logs-artifactchangeset changed this entirely:firewall-audit-logs(constantconstants.FirewallAuditArtifactName,pkg/constants/constants.go:387)/tmp/gh-aw/sandbox/firewall/logs/+/tmp/gh-aw/sandbox/firewall/audit/(seepkg/workflow/engine_firewall_support.go:124–138)/tmp/gh-aw/firewall-logs/does not exist in the codebaseUsers following the debugging guide will look for an artifact named
firewall-logs/that no longer exists and will not find the newfirewall-audit-logsartifact.Confirmed Persisting Issues (from Prior Runs)
Previously reported, still unresolved
status-commentschema says "Must be explicitly set to true" butcompiler_safe_outputs.go:192–197auto-enables it forslash_command/label_commandtriggersproxy-argsMCP server field implemented inmcp_config_custom.go:661but absent from$defs/stdio_mcp_tool.propertiesin schema (additionalProperties:false → fails validation)update-discussionlabels/allowed-labels is a dead feature — schema and docs define it, but no LLM tool parameter and no handler code inupdate_discussion.cjssandbox-agent-false-removallisted inmcp_tools_management.go:171andgh-aw-as-mcp-server.md:284but does not exist infix_codemods.go; actual ID issandbox-false-to-agent-falseclose-older-keyfield fully implemented in schema and code but absent from all documentationsafe-outputs.actions.inputsin schema and code (parseActionsConfig) but missing fromcustom-safe-outputs.mdAction Reference tableset-issue-typesafe output absent fromsafe-outputs.md(exists in schema, code, spec)mark-pull-request-as-ready-for-reviewabsent fromsafe-outputs.mdfeatures.copilot-requestsflag fully active in code but completely undocumentedMCPGatewayFeatureFlag = "mcp-gateway"never checked viaisFeatureEnabled(); schema self-contradicts between top-level sandbox description andmcpfieldMCPScriptsFeatureFlag = "mcp-scripts"is dead code — activation usesHasMCPScripts()not feature flagDisableXPIAPromptFeatureFlag = "disable-xpia-prompt"used inunified_prompt_step.go:106but completely absent from docs and schema examplesRecommendations
Run
scripts/generate-schema-docs.jsin CI — Add a check that fails iffrontmatter-full.mddiffers from the generated output, to prevent staleness whenever the schema changes.Document
observability.job-summaryinfrontmatter.md— Add a section forobservability:withjob-summary: on/off, explaining it appends a compact observability section to GitHub Actions job summaries.Document
importsobject form inimports.md— Add a section showing both array and object form, emphasizing thatimports.apm-packages:is the preferred way to configure APM packages (and thatdependencies:is deprecated).Update
debugging.mdartifact table — Replace the stalefirewall-logs/row withfirewall-audit-logs(paths:/tmp/gh-aw/sandbox/firewall/logs/and/tmp/gh-aw/sandbox/firewall/audit/).Strategy Performance
Next Steps
node scripts/generate-schema-docs.js && git diff --exit-code docs/src/content/docs/reference/frontmatter-full.mdobservability.job-summaryinfrontmatter.mdimportsobject form (aw/apm-packages) inimports.mddebugging.mdartifact table forfirewall-audit-logsReferences: §23577506476
Beta Was this translation helpful? Give feedback.
All reactions