[repository-quality] Repository Quality Improvement Report — Deprecated API Alias Proliferation & Zombie Callsite Cleanup (2026-07-08)

[github-actions[bot]]

🎯 Repository Quality Improvement Report - Deprecated API Alias Proliferation & Zombie Callsite Cleanup

Analysis Date: 2026-07-08
Focus Area: Deprecated API Alias Proliferation & Zombie Callsite Cleanup
Strategy Type: Custom
Custom Area: Yes — This repo has accumulated multiple deprecated-but-still-called API aliases (Gemini→Antigravity rename, RequiredSubcommand→RequiredSubcommands field migration, inline-agents feature flag always-true guards) alongside a zombie no-op validator with unused parameters and a stale TODO comment that misleads readers about an already-implemented function. These represent technical debt patterns not captured by standard categories.

Executive Summary

An analysis of the pkg/workflow package reveals four distinct classes of stale code that impose ongoing maintenance cost and mislead readers. The Gemini→Antigravity engine rename is 80% complete at the type level (DefaultAntigravityAPITarget, GetAntigravityAPITarget added) but three production callsites still invoke the deprecated GetGeminiAPITarget wrapper, and two test files exercise the deprecated surface. The RequiredSubcommand field on PackageExtractor was deprecated in favour of RequiredSubcommands but pip.go and npm.go still set the singular field, preventing the slice-based path from being exercised.

The validateImportedStepsNoAgenticSecrets function is explicitly documented as a no-op since custom engine support was removed, yet it is still called with two meaningful parameters (engineConfig, engineSetting) that it discards entirely—creating a misleading call site. Finally, a // TODO: Job implementation is pending; buildEvalsJob currently returns nil comment in compiler_jobs.go:216 is factually incorrect: evals_job.go contains a 106-line fully-implemented buildEvalsJob that returns nil only when HasEvals() is false—the correct, expected behaviour.

Cleaning up these four issues removes ~120 lines of dead code, eliminates 3 deprecated function calls, migrates 3 struct field usages to the canonical form, and restores comment accuracy—all with zero functional change.

Full Analysis Report

Focus Area: Deprecated API Alias Proliferation & Zombie Callsite Cleanup

Current State Assessment

Metrics Collected:

Metric	Value	Status
Deprecated GetGeminiAPITarget production callsites	3	⚠️
Tests exercising deprecated GetGeminiAPITarget	3 test functions	⚠️
RequiredSubcommand (deprecated field) callsites outside package_extraction.go	3 (pip.go ×2, npm.go ×1)	⚠️
validateImportedStepsNoAgenticSecrets — no-op with unused params, still called	1 callsite	⚠️
Stale TODO: Job implementation is pending comment for fully-implemented function	1 (compiler_jobs.go:216)	❌
isFeatureEnabled("inline-agents") guards that always evaluate true	4 (compiler_activation_job_builder.go ×2, compiler_yaml_main_job.go ×2)	⚠️

Findings

Strengths

• DefaultAntigravityAPITarget and GetAntigravityAPITarget already exist as the canonical replacements—migration is straightforward alias substitution.
• RequiredSubcommands precedence logic already correctly handles the migration: getRequiredSubcommands() checks the slice first, then falls back to the singular field.
• The zombie validator has a clear, documented reason for its no-op state in its own doc comment.
• The features-inline-agents-removal codemod exists and is registered in fix_codemods.go:99—the codemod path is available for users, but the compiler-side guard code itself was never removed.

Areas for Improvement

• [HIGH] GetGeminiAPITarget deprecated alias called in awf_config.go:516,522 and domains.go:993 — callers should use GetAntigravityAPITarget directly.
• [HIGH] validateImportedStepsNoAgenticSecrets is a no-op zombie: defined in imported_steps_validation.go:41, called at compiler_orchestrator_engine.go:439. The call and the function body should be removed, along with the log line at 438.
• [MEDIUM] pip.go:50,72 and npm.go:37 set RequiredSubcommand (deprecated); should migrate to RequiredSubcommands: []string{"install"} and RequiredSubcommands: nil respectively.
• [MEDIUM] compiler_jobs.go:216 TODO comment is factually wrong — buildEvalsJob is fully implemented; the comment should be replaced with accurate documentation.
• [LOW] Four isFeatureEnabled(constants.FeatureFlag("inline-agents"), ...) guards in compiler_activation_job_builder.go and compiler_yaml_main_job.go always return true; the conditions should be simplified to unconditional calls.

Detailed Analysis

1. Gemini→Antigravity alias callsites (awf_config.go, domains.go)

engine_api_targets.go documents both deprecated symbols:

• DefaultGeminiAPITarget (line 212): // Deprecated: Use DefaultAntigravityAPITarget.
• GetGeminiAPITarget (line 242): // Deprecated: Use GetAntigravityAPITarget for new Antigravity engine workflows.

Despite this, awf_config.go:516,522 and domains.go:993 still call GetGeminiAPITarget. The function itself is a thin wrapper that delegates to GetAntigravityAPITarget, so replacing the three call sites is a purely mechanical name-swap with no logic change. Three test functions in awf_helpers_test.go (lines 1786, 1855, 1857) also exercise the deprecated symbol and should be renamed/retargeted.

2. Zombie validateImportedStepsNoAgenticSecrets (imported_steps_validation.go, compiler_orchestrator_engine.go)

// This validation is now a no-op since custom engine support has been removed.
// The function is kept for backwards compatibility but always returns nil.
func (c *Compiler) validateImportedStepsNoAgenticSecrets(engineConfig *EngineConfig, engineID string) error {
    importedStepsValidationLog.Print("Skipping validation: custom engine support removed")
    return nil
}

The "backwards compatibility" rationale is unfounded for an internal unexported-receiver method. No external package can call it. The function and its single callsite at compiler_orchestrator_engine.go:439 (plus the log line at 438) can be deleted entirely. The unused engineConfig and engineSetting variables passed to the call are still assigned at lines 20–21 of the surrounding context struct, but they are used by other functions — so only the dead callsite needs to be deleted, not the variables.

3. Stale TODO comment (compiler_jobs.go:216)

// TODO: Job implementation is pending; buildEvalsJob currently returns nil (no-op).
if evalsJob, err := c.buildEvalsJob(data); err != nil {

evals_job.go is a 106-line fully-implemented function that builds a complete job YAML struct with steps, permissions, conditions, and dependencies. It returns nil, nil only when data.Evals.HasEvals() is false—which is the correct early-exit pattern used by every other job builder. The comment should be replaced with an accurate description of the conditional skip behaviour.

4. RequiredSubcommand (deprecated field) still set in pip.go and npm.go

package_extraction.go:158 marks the field as // Deprecated: Use RequiredSubcommands for multiple subcommand support. The fallback logic at line 285 means current behaviour is preserved, but the deprecated field is never needed once callers use the slice form. pip.go sets RequiredSubcommand: "install" and RequiredSubcommand: "" (lines 50, 72); npm.go sets RequiredSubcommand: "" (line 37). All three can be migrated to RequiredSubcommands: []string{"install"} or omitting the field entirely.

5. Always-true inline-agents guards

features.go:26 short-circuits inline-agents to always return true. As a result, the four guards in compiler_activation_job_builder.go:970,976 and compiler_yaml_main_job.go:585,590 are dead conditions. The || len(data.Skills) > 0 clauses at lines 976 and 590 are also pure overhead since the left side always wins. Simplifying these to unconditional calls removes the misleading dead condition and makes the code self-documenting.

---

🤖 Tasks for Copilot Agent

NOTE TO PLANNER AGENT: Split the following tasks into individual work items.

Improvement Tasks

Task 1: Migrate deprecated GetGeminiAPITarget callsites to GetAntigravityAPITarget

Priority: High
Estimated Effort: Small
Focus Area: Deprecated API Alias Proliferation

Description: Replace all production callsites of the deprecated GetGeminiAPITarget function with GetAntigravityAPITarget (the canonical replacement documented in engine_api_targets.go). Update the corresponding test functions in awf_helpers_test.go to target GetAntigravityAPITarget and rename the test functions to reflect the new name. The deprecated GetGeminiAPITarget function itself and DefaultGeminiAPITarget constant can then be removed from engine_api_targets.go.

Acceptance Criteria:

• awf_config.go:516,522 — GetGeminiAPITarget replaced with GetAntigravityAPITarget
• domains.go:993 — GetGeminiAPITarget replaced with GetAntigravityAPITarget
• awf_helpers_test.go — TestGetGeminiAPITarget, TestAWFGeminiAPITargetFlags, TestGeminiEngineIncludesGeminiAPITarget retargeted to GetAntigravityAPITarget and renamed
• engine_api_targets.go — GetGeminiAPITarget function and DefaultGeminiAPITarget constant removed (or retain constant with a single //nolint:unused only if external package compatibility requires it)
• make fmt passes; go build ./... passes; existing tests pass

Code Region: pkg/workflow/awf_config.go, pkg/workflow/domains.go, pkg/workflow/engine_api_targets.go, pkg/workflow/awf_helpers_test.go

In the gh-aw repository, the `GetGeminiAPITarget` function and `DefaultGeminiAPITarget` constant in `pkg/workflow/engine_api_targets.go` are deprecated in favour of `GetAntigravityAPITarget` and `DefaultAntigravityAPITarget`. 

Replace the three production callsites:
- `pkg/workflow/awf_config.go` lines 516 and 522: change `GetGeminiAPITarget(config.WorkflowData, config.EngineName)` → `GetAntigravityAPITarget(config.WorkflowData, config.EngineName)`
- `pkg/workflow/domains.go` line 993: change `GetGeminiAPITarget(data, engineID)` → `GetAntigravityAPITarget(data, engineID)`

Update the three test functions in `pkg/workflow/awf_helpers_test.go` (starting at lines 1786, 1855, 1857) that exercise `GetGeminiAPITarget` to call `GetAntigravityAPITarget` instead, renaming the test functions accordingly (e.g., `TestGetGeminiAPITarget` → `TestGetAntigravityAPITarget`).

Finally, remove the deprecated `GetGeminiAPITarget` function (lines 241–274) and `DefaultGeminiAPITarget` constant (lines 211–213) from `engine_api_targets.go`. Run `make fmt` and verify `go build ./...` and tests pass.

---

Task 2: Delete the zombie validateImportedStepsNoAgenticSecrets function and its callsite

Priority: High
Estimated Effort: Small
Focus Area: Zombie Callsite Cleanup

Description: validateImportedStepsNoAgenticSecrets is explicitly documented as a no-op since custom engine support was removed. As an unexported receiver method it has no external callers. Delete the function body from imported_steps_validation.go, remove its callsite and the preceding log line from compiler_orchestrator_engine.go, and remove any associated test coverage if present.

Acceptance Criteria:

• imported_steps_validation.go — validateImportedStepsNoAgenticSecrets function (lines ~38–45) removed
• compiler_orchestrator_engine.go — callsite at line 439 and the orchestratorEngineLog.Printf("Validating imported steps...") line at 438 removed
• No other references to validateImportedStepsNoAgenticSecrets remain in the codebase
• go build ./... passes; existing tests pass

Code Region: pkg/workflow/imported_steps_validation.go, pkg/workflow/compiler_orchestrator_engine.go

In the gh-aw repository, `pkg/workflow/imported_steps_validation.go` contains a function `validateImportedStepsNoAgenticSecrets` that is explicitly documented as a no-op:

```go
// This validation is now a no-op since custom engine support has been removed.
// The function is kept for backwards compatibility but always returns nil.
func (c *Compiler) validateImportedStepsNoAgenticSecrets(engineConfig *EngineConfig, engineID string) error {
    importedStepsValidationLog.Print("Skipping validation: custom engine support removed")
    return nil
}

This is an unexported receiver method — "backwards compatibility" does not apply.

Delete the function from imported_steps_validation.go.

In pkg/workflow/compiler_orchestrator_engine.go, remove the callsite at approximately line 439:

orchestratorEngineLog.Printf("Validating imported steps for agentic secrets (strict=%v)", c.strictMode)
if err := c.validateImportedStepsNoAgenticSecrets(engineConfig, engineSetting); err != nil {
    orchestratorEngineLog.Printf("Imported steps validation failed: %v", err)
    return err
}

Verify there are no remaining references with grep -r validateImportedStepsNoAgenticSecrets .. Run make fmt and verify go build ./... and tests pass.

---

#### Task 3: Migrate `pip.go` and `npm.go` from deprecated `RequiredSubcommand` to `RequiredSubcommands`

**Priority**: Medium
**Estimated Effort**: Small
**Focus Area**: Deprecated Field Migration

**Description:** `PackageExtractor.RequiredSubcommand` is deprecated in favour of `RequiredSubcommands []string`. Three struct literals in `pip.go` (lines 50, 72) and `npm.go` (line 37) still set the deprecated field. Migrate them to the canonical `RequiredSubcommands` form. The deprecated field and its fallback path in `package_extraction.go:280–286` can be removed once all callsites are migrated; the `package_extraction_test.go` tests exercising the deprecated field path should also be updated.

**Acceptance Criteria:**
- [ ] `pip.go:50` — `RequiredSubcommand: "install"` replaced with `RequiredSubcommands: []string{"install"}`
- [ ] `pip.go:72` — `RequiredSubcommand: ""` field removed (zero value is default)
- [ ] `npm.go:37` — `RequiredSubcommand: ""` field removed (zero value is default)
- [ ] `package_extraction.go` — deprecated `RequiredSubcommand` field removed; `getRequiredSubcommands` fallback path at lines 280–286 simplified
- [ ] `package_extraction_test.go` — test cases using `RequiredSubcommand:` migrated to `RequiredSubcommands:` 
- [ ] `make fmt` passes; existing package extraction tests pass

**Code Region:** `pkg/workflow/pip.go`, `pkg/workflow/npm.go`, `pkg/workflow/package_extraction.go`, `pkg/workflow/package_extraction_test.go`

```markdown
In the gh-aw repository, `pkg/workflow/package_extraction.go` defines a deprecated `RequiredSubcommand string` field on `PackageExtractor` (line ~158), marked `// Deprecated: Use RequiredSubcommands for multiple subcommand support.`

Three struct literals still use the deprecated field:
- `pkg/workflow/pip.go:50`: `RequiredSubcommand: "install"` → change to `RequiredSubcommands: []string{"install"}`
- `pkg/workflow/pip.go:72`: `RequiredSubcommand: ""` → remove the field entirely (zero-value default)
- `pkg/workflow/npm.go:37`: `RequiredSubcommand: ""` → remove the field entirely

After updating those callsites, remove the deprecated `RequiredSubcommand` field from `PackageExtractor` in `package_extraction.go`, simplify the `getRequiredSubcommands` helper (lines ~280–286) to remove the fallback branch, and update all test cases in `package_extraction_test.go` that set `RequiredSubcommand:` to use `RequiredSubcommands:` instead. Run `make fmt` and verify tests pass.

---

Task 4: Fix stale TODO comment in compiler_jobs.go and simplify always-true inline-agents guards

Priority: Medium
Estimated Effort: Small
Focus Area: Dead Comment & Dead Condition Cleanup

Description: Two comment-level accuracy issues reduce code clarity. First, compiler_jobs.go:216 contains // TODO: Job implementation is pending; buildEvalsJob currently returns nil (no-op) which is factually incorrect — buildEvalsJob is fully implemented in evals_job.go. Second, four isFeatureEnabled(constants.FeatureFlag("inline-agents"), ...) guards in compiler_activation_job_builder.go and compiler_yaml_main_job.go always evaluate to true because features.go hardcodes the short-circuit, making the if conditions dead code.

Acceptance Criteria:

• compiler_jobs.go:216 — TODO comment replaced with an accurate description of the conditional skip (e.g., // Returns nil when no evals are declared in the workflow frontmatter.)
• compiler_activation_job_builder.go:970 — if isFeatureEnabled(constants.FeatureFlag("inline-agents"), ctx.data) replaced with unconditional call to generateRestoreInlineSubAgentsStep (or equivalent)
• compiler_activation_job_builder.go:976 — if isFeatureEnabled(...) || len(ctx.data.Skills) > 0 simplified (inline-agents condition always true; simplify or remove)
• compiler_yaml_main_job.go:585 — same inline-agents guard simplified
• compiler_yaml_main_job.go:590 — same inline-agents guard simplified
• All existing tests pass; make fmt passes

Code Region: pkg/workflow/compiler_jobs.go, pkg/workflow/compiler_activation_job_builder.go, pkg/workflow/compiler_yaml_main_job.go

Two separate dead-code issues in gh-aw's compiler layer need cleanup:

**Issue 1 — Stale TODO comment:**
`pkg/workflow/compiler_jobs.go` line 216 says:

// TODO: Job implementation is pending; buildEvalsJob currently returns nil (no-op).

This is wrong. `pkg/workflow/evals_job.go` contains a 106-line fully-implemented `buildEvalsJob` function. It returns `nil, nil` only when `data.Evals.HasEvals()` is false — the correct early-exit pattern. Replace the TODO with an accurate comment like:
```go
// Returns nil when no evals are declared in the workflow frontmatter (HasEvals == false).

Issue 2 — Always-true inline-agents guards:
pkg/workflow/features.go hardcodes inline-agents to always return true (line 26). As a result, four if isFeatureEnabled(constants.FeatureFlag("inline-agents"), ...) guards in compiler_activation_job_builder.go (lines ~970, 976) and compiler_yaml_main_job.go (lines ~585, 590) are dead conditions. Simplify each guard:

• Lines 970 and 585: Remove the if wrapper; call the guarded function unconditionally.
• Lines 976 and 590: The condition isFeatureEnabled(...) || len(...Skills) > 0 always has a true left side; simplify to unconditional call.

Run make fmt and verify all tests pass.

---

## 📊 Historical Context

<details>
<summary>Previous Focus Areas (last 5 runs)</summary>

| Date | Focus Area | Type | Custom | Key Outcomes |
|------|------------|------|--------|--------------|
| 2026-07-07 | Environment Variable Access Fragmentation | Custom | Y | 45 nolint suppressions, 6 duplicated env vars, envutil gaps |
| 2026-07-06 | Context-Blind Sleep Gap | Custom | Y | 4 functions / 7 time.Sleep calls uncancellable up to 60 min |
| 2026-07-03 | ADR-42150 dispatch-repository Key Canonicalization | Custom | Y | 5 underscore-form occurrences blocking ADR merge |
| 2026-07-02 | Remote Fetch API Context Gap | Custom | Y | 8 public wrappers strip caller context |
| 2026-07-01 | Codemod Registry Drift & Idempotency Coverage Gap | Custom | Y | 20/62 codemod IDs absent from ContainsExpectedCodemods |

</details>

---

## 🎯 Recommendations

### Immediate Actions (This Week)
1. Delete zombie `validateImportedStepsNoAgenticSecrets` and its callsite — Priority: High, zero-risk removal
2. Replace `GetGeminiAPITarget` callers with `GetAntigravityAPITarget` — Priority: High, pure alias swap

### Short-term Actions (This Month)
1. Migrate `pip.go`/`npm.go` to `RequiredSubcommands` and remove deprecated field — Priority: Medium
2. Fix stale `compiler_jobs.go` TODO and simplify inline-agents guards — Priority: Medium

### Long-term Actions (This Quarter)
1. Establish a policy for deprecated-but-retained symbols: add a minimum removal date comment (e.g., `// Remove after: 2026-Q4`) to all remaining deprecated symbols to enforce eventual cleanup.

---

## 📈 Success Metrics

- **Deprecated `GetGeminiAPITarget` callsites**: 3 → 0
- **No-op zombie functions**: 1 → 0
- **Deprecated `RequiredSubcommand` callsites**: 3 → 0
- **Always-true dead `if` conditions**: 4 → 0
- **Stale TODO accuracy**: 1 inaccurate → 0

---

## Next Steps

1. Review and prioritise the 4 tasks above
2. Assign tasks to Copilot coding agent via planner agent
3. Track progress on improvement items
4. Re-evaluate deprecated alias coverage in 30 days

**References:**
- [`[§28945619265]`](https://github.com/github/gh-aw/actions/runs/28945619265) — current workflow run

---

*Generated by Repository Quality Improvement Agent*




> Generated by [⚡ Repository Quality Improvement Agent](https://github.com/github/gh-aw/actions/runs/28945619265) · 99.3 AIC · ⌖ 18 AIC · ⊞ 6.6K · [◷](https://github.com/search?q=repo%3Agithub%2Fgh-aw+%22gh-aw-workflow-call-id%3A+github%2Fgh-aw%2Frepository-quality-improver%22&type=discussions)
> - [x] expires <!-- gh-aw-expires: 2026-07-09T13:29:59.290Z --> on Jul 9, 2026, 5:29 AM UTC-08:00

<!-- gh-aw-agentic-workflow: Repository Quality Improvement Agent, engine: copilot, version: 1.0.68, model: claude-sonnet-4.6, id: 28945619265, workflow_id: repository-quality-improver, run: https://github.com/github/gh-aw/actions/runs/28945619265 -->

<!-- gh-aw-workflow-id: repository-quality-improver -->
<!-- gh-aw-workflow-call-id: github/gh-aw/repository-quality-improver -->

[github-actions[bot]]

Smoke club grunt. Latest talk tapped. Test mark here.

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

• accounts.google.com
• android.clients.google.com
• clients2.google.com
• contentautofill.googleapis.com
• safebrowsingohttpgateway.googleapis.com
• www.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "safebrowsingohttpgateway.googleapis.com"
    - "www.google.com"

See Network Configuration for more information.

📰 BREAKING: Report filed by Smoke Copilot · 98.6 AIC · ⌖ 4.87 AIC · ⊞ 19.1K · ◷
_{Comment /smoke-copilot to run again
Add label smoke to run again}

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-07-09T13:29:59.290Z.

Closed by Workflow