[daily-compiler-quality] Daily Compiler Code Quality Report - 2026-07-09

[github-actions[bot]]

🔍 Compiler Code Quality Analysis Report

Analysis Date: 2026-07-09
Files Analyzed: compiler_orchestrator_engine.go, compiler_safe_outputs_job.go, compiler_yaml.go
Commit: f78aa11 — Add checkout.safe-output-github-app support for safe_outputs checkout auth
Overall Status: ⚠️ All three files meet the quality threshold but persistent structural issues need attention

---

Executive Summary

All three files analyzed today score at Good tier (79–86/100), clearing the 75-point human-written quality threshold. The codebase demonstrates consistently strong error-handling discipline and excellent test coverage (average test-to-source ratio: 1.55). However, two long-standing structural problems continue unaddressed across multiple analysis cycles: oversized functions and oversized files. compiler_yaml.go (1129 lines) and compiler_safe_outputs_job.go (995 lines) both significantly exceed the 800-line guideline, and their largest functions — generatePrompt (285 lines) and buildSafeOutputsJobFromParts (248 lines) — remain the highest-priority refactoring targets in the compiler.

The rotation now covers 12 of 12 tracked files at least once, with an overall corpus average of 82.4/100. Five files have reached Excellent tier (≥90), confirming that high-quality patterns are established — the gap is in applying them consistently to the larger, more complex files.

---

Files Analyzed Today

📁 Detailed File Analysis (3 files)

1. compiler_orchestrator_engine.go — Score: 86/100 ✅

Rating: Good · Size: 518 lines · Hash: f78aa11

Dimension	Score	Notes
Structure & Organization	22/25	Compact, focused; clean engineSetupResult struct
Readability	15/20	6.6% comment density is low for complex logic
Error Handling	18/20	5/6 fmt.Errorf use %w; one gap
Testing & Maintainability	17/20	Test ratio 1.49; test file exists
Patterns & Best Practices	14/15	Well-named methods; good Go idioms
Total	86/100	Stable (Δ 0)

Strengths: Compact file within budget; 83% error-wrapping rate; method names read as English sentences.

Issues:

1. applyEngineImportDefaults at 82 lines — split into mergeImportEngineConfig + fillImportEngineDefaults
2. Comment density 6.6% — below ideal for engine setup complexity
3. One bare fmt.Errorf without %w (security findings formatter)

---

2. compiler_safe_outputs_job.go — Score: 79/100 ✅

Rating: Good · Size: 995 lines · Hash: f78aa11

Dimension	Score	Notes
Structure & Organization	15/25	995 lines, 24% over limit; split still unaddressed
Readability	14/20	26.5% comment density excellent; functions too long
Error Handling	19/20	100% %w wrapping — best in class
Testing & Maintainability	18/20	Test ratio 1.58; comprehensive coverage
Patterns & Best Practices	13/15	Options-struct pattern idiomatic
Total	79/100	Stable (Δ 0)

Strengths: 100% error wrapping; 26.5% comment density; 1.58 test ratio; clean options-struct.

Issues:

1. buildSafeOutputsJobFromParts at 248 lines — largest function in corpus
2. buildSafeOutputsHandlerOutputsAndActionSteps at 221 lines — multi-responsibility
3. buildJobLevelSafeOutputEnvVars at 128 lines — should be split into 3 helpers

---

3. compiler_yaml.go — Score: 79/100 ✅

Rating: Good · Size: 1129 lines · Hash: f78aa11

Dimension	Score	Notes
Structure & Organization	17/25	1129 lines, 41% over limit
Readability	13/20	generatePrompt at 285 lines is critical
Error Handling	17/20	71% wrapping; 2 bare return err
Testing & Maintainability	19/20	Test ratio 1.58; zero TODOs
Patterns & Best Practices	13/15	strings.Builder, smart chunking
Total	79/100	Stable (Δ 0)

Strengths: Best test ratio; 24.4% comment density; zero TODOs/FIXMEs.

Issues:

1. generatePrompt at 285 lines — highest priority refactor
2. Two bare return err at lines 1042, 1049 without context
3. File at 1129 lines — most oversized in the corpus

---

Overall Corpus Statistics

File	Score	Rating	Δ	Lines
compiler_orchestrator.go	93	✅ Excellent	—	—
compiler_activation_job.go	91	✅ Excellent	—	—
compiler_jobs.go	89	✅ Excellent	—	—
compiler_safe_outputs.go	88	✅ Excellent	—	—
compiler.go	88	✅ Excellent	—	—
compiler_orchestrator_engine.go	86	✅ Good	0	518
compiler_orchestrator_frontmatter.go	84	✅ Good	—	—
compiler_orchestrator_workflow.go	82	✅ Good	—	—
compiler_orchestrator_tools.go	80	✅ Good	—	—
compiler_yaml.go	79	✅ Good	0	1129
compiler_safe_outputs_job.go	79	✅ Good	0	995
compiler_yaml_main_job.go	71	⚠️ Acceptable	—	—

Corpus avg: 82.4/100 · Meeting threshold (≥75): 11/12 (92%)

---

Top 3 Issues (Cross-File)

1. Oversized functions — generatePrompt (285 lines), buildSafeOutputsJobFromParts (248 lines), buildSafeOutputsHandlerOutputsAndActionSteps (221 lines). Each should be split into 2–3 helpers.
2. Oversized files — compiler_yaml.go (1129 lines, 41% over budget) and compiler_safe_outputs_job.go (995 lines, 24% over) need file-level splits.
3. Bare error returns — compiler_yaml.go lines 1042 and 1049 use return err without context (computeExpandedAllowedDomainsForSanitization, computeAllowedDomainsForSanitization).

Top 3 Strengths (Cross-File)

1. Error wrapping discipline — compiler_safe_outputs_job.go achieves 100% %w wrapping; engine and yaml files at 83%/71%.
2. Test coverage — All three files have dedicated _test.go files with ratios of 1.49–1.58.
3. Zero technical debt markers — No TODOs or FIXMEs across the analyzed files.

Recommended Action

Priority: Fix bare return err at compiler_yaml.go:1042,1049 (estimated 15 minutes). These propagate errors from domain-computation helpers without any context, making debugging harder. Wrap with:

return fmt.Errorf("failed to compute expanded allowed domains: %w", err)
return fmt.Errorf("failed to compute allowed domains: %w", err)

💾 Cache & Rotation Summary

Cache location: /tmp/gh-aw/cache-memory/compiler-quality/
Files tracked: 12 · Analyzed today: 3 · All files analyzed ≥ once: ✅ Yes
Next rotation: compiler_orchestrator.go, compiler_activation_job.go, compiler_jobs.go

---

Report generated by Daily Compiler Quality Check workflow · Analysis powered by Serena MCP Server

Generated by 📊 Daily Compiler Quality Check · 133.3 AIC · ⌖ 38.5 AIC · ⊞ 9.8K · ◷

• expires on Jul 9, 2026, 7:58 PM UTC-08:00