[terminal-stylist] Console Output Analysis: Patterns & Charmbracelet Best Practices

[github-actions[bot]]

Overview

This report analyzes console output patterns across all non-test Go files in pkg/, focusing on fmt.Print*, the console package, Lipgloss styling, and Huh form usage.

Key Metrics

Category	Count / Status
Files with raw fmt.Print*	3
Files using console.* helpers	widespread
Lipgloss usage	concentrated in pkg/console/, pkg/styles/, pkg/logger/
Huh usage	pkg/console/ wrappers + interactive CLI flows

Critical Bug 🐛

Double success prefix in pkg/cli/run_interactive.go:100:

console.FormatSuccessMessage("✓ Workflow dispatched successfully!")

FormatSuccessMessage already prepends ✓ , so the output renders as ✓ ✓ Workflow dispatched successfully!. Remove the manual prefix.

Recommendations

1. Fix double-prefix — pkg/cli/run_interactive.go:100: change "✓ Workflow dispatched successfully!" → "Workflow dispatched successfully!"
2. Standardize raw stdout writes — pkg/cli/status_command.go, logs_report.go, view_command.go: prefer explicit fmt.Fprint(os.Stdout, ...) with a comment, or route through console helpers
3. Add spacing helpers — reduce repeated fmt.Fprintln(os.Stderr, "") patterns by adding a console.Spacing() helper
4. Document output layers formally:
   • console.Format* → semantic user messages
   • console.Render* → structured/plain rendering
   • direct fmt.Fprint(os.Stdout, ...) → raw command output
5. TTY-gate logger colors — pkg/logger/logger.go:128,141 uses lipgloss.Fprintf without explicit TTY check

Detailed Findings

Good Patterns ✅

• TTY-gated styling: pkg/console/console.go:30-40, 197-268
• Centralized adaptive palette: pkg/styles/theme.go:67-107, 137-206 with light/dark variants and Windows background probe avoidance
• Shared themed forms: pkg/console/prompt_form.go:12-36 — all Huh forms get theme + accessibility centrally
• Huh theme mapped from app palette: pkg/styles/huh_theme.go:13-74 using lipgloss.LightDark(...) appropriately
• Non-TTY fallbacks: pkg/console/confirm.go:23-27, pkg/console/list.go:28-32, pkg/cli/interactive.go:111-113
• TTY-gated calendar styles: pkg/cli/compile_schedule_calendar.go:198-217

Inconsistencies / Anti-patterns ⚠️

Duplicate formatting responsibility

pkg/console/render.go emits markdown-like headings/bullets via raw fmt.Fprintf while other output uses console.Format*. These are parallel formatting systems. Treat RenderStruct as a serialization layer and document it as such.

Repeated blank-line management

Multiple files manually emit fmt.Fprintln(os.Stderr, "") for spacing:

• pkg/cli/run_interactive.go:78-80, 99-103
• pkg/cli/outcomes_history.go:171
• pkg/cli/mcp_inspect.go (many locations)

Raw fmt.Print without writer intent

• pkg/cli/view_command.go: fmt.Print(output) — no semantic layer
• pkg/cli/status_command.go: fmt.Print(console.RenderStruct(statuses))
• pkg/cli/logs_report.go: fmt.Print(console.RenderStruct(data))

Lipgloss Best-Practice Adherence

Strong: adaptive colors, TTY detection, LightDark usage in Huh theme, tree rendering styles in mcp_inspect.go.

Minor concern: pkg/logger/logger.go:128,141 — lipgloss.Fprintf without explicit TTY/color gating. If debug logs are redirected and DEBUG_COLORS is set, ANSI may leak.

Huh Form Usage Quality

Overall: good. Shared pkg/console/prompt_form.go wrapper ensures theme and accessibility. TTY fallbacks exist. Password masking used correctly. Verdict: consistent usage.

References: §29321202293

Generated by 💄 Terminal Stylist · 30.3 AIC · ⌖ 8.02 AIC · ⊞ 5.6K · ◷

• expires on Jul 15, 2026, 1:25 AM UTC-08:00