[daily-compiler-quality] Daily Compiler Code Quality Report - 2026-07-15

[github-actions[bot]]

🔍 Compiler Code Quality Analysis Report

Analysis Date: 2026-07-15
Files Analyzed: compiler_yaml.go, compiler.go, compiler_safe_outputs_job.go
Overall Status: ⚠️ All three files scored below the 75-point human-written quality threshold

---

Executive Summary

Today’s rotation targeted the two files with the most recent score declines (compiler.go: 84→78, compiler_safe_outputs_job.go: 84→78) and the file already flagged at 71 (compiler_yaml.go). After detailed analysis, all three files score in the 60–70 range — below the 75-point threshold — primarily due to oversized functions, missing error context wrapping, and absent test coverage.

The dominant issue is function length: generatePrompt (285 lines), buildSafeOutputsJobFromParts (248 lines), buildSafeOutputsHandlerOutputsAndActionSteps (221 lines), and CompileWorkflowData (172 lines) all far exceed the 50-line ideal. These mega-functions are the root cause of readability and maintainability concerns.

Error handling shows a split: compiler_safe_outputs_job.go wraps errors well, while compiler.go has 7 bare return err calls and zero fmt.Errorf(%w) wraps, stripping context from every error path in the main entry point.

---

Files Analyzed Today

📁 Detailed File Analysis

1. compiler_yaml.go — Score: 60/100 ⚠️

Size: 1262 lines | Functions: 20 | Test file: ❌ None

Dimension	Score	Notes
Structure & Organization	12/25	generatePrompt is 285 lines, generateWorkflowHeader is 173 lines
Readability	12/20	Clear naming; mega-functions obscure logic flow
Error Handling	13/20	5/7 errors wrapped with %w; 2 bare return err at lines 1175, 1182
Testing & Maintainability	8/20	No test file
Patterns & Best Practices	15/15	Consistent Go idioms, proper strings.Builder usage
Total	60/100	Needs Work

2. compiler.go — Score: 67/100 ⚠️

Size: 584 lines | Functions: 8 | Test file: ❌ None

Dimension	Score	Notes
Structure & Organization	16/25	CompileWorkflowData (172 lines), generateAndValidateYAML (119 lines)
Readability	14/20	Two exported functions have good godoc; internals mostly uncommented
Error Handling	10/20	7 bare return err, zero fmt.Errorf(%w) — no context added anywhere
Testing & Maintainability	14/20	No test file; good godoc on public API
Patterns & Best Practices	13/15	filepath.Clean path traversal guard is a positive signal
Total	67/100	Acceptable

3. compiler_safe_outputs_job.go — Score: 70/100 ⚠️

Size: 995 lines | Functions: 12 | Test file: ✅ 1574 lines (ratio 1.58)

Dimension	Score	Notes
Structure & Organization	14/25	buildSafeOutputsJobFromParts (248 lines), buildSafeOutputsHandlerOutputsAndActionSteps (221 lines)
Readability	14/20	Consistent build* naming; 4-value returns reduce clarity
Error Handling	18/20	5 fmt.Errorf(%w) wraps; 3 bare returns at shallow delegation points
Testing & Maintainability	17/20	Excellent: test ratio 1.58
Patterns & Best Practices	7/15	4-value returns signal missing struct abstractions
Total	70/100	Acceptable

---

Summary Table

File	Score	Prev	Trend	Top Issue
compiler_yaml.go	60/100	71	↓ -11	No tests; generatePrompt is 285 lines
compiler.go	67/100	78	↓ -11	Zero fmt.Errorf(%w) wraps in main entry point
compiler_safe_outputs_job.go	70/100	78	↓ -8	4-value returns; two 200+ line functions

Avg score: 66/100 · Files meeting threshold (≥75): 0/3

---

Top 3 Issues

1. Oversized functions — generatePrompt (285 lines), buildSafeOutputsJobFromParts (248 lines), CompileWorkflowData (172 lines) all exceed targets by 3–6×
2. Missing error context in compiler.go — 7 bare return err calls and zero fmt.Errorf(%w) wraps strip error origin from the main entry point
3. No test coverage for compiler_yaml.go and compiler.go — the two largest-scope files have zero automated tests, making refactoring high-risk

Top 3 Strengths

1. Consistent, descriptive naming (build*, generate*, compile*)
2. compiler_safe_outputs_job.go has excellent test coverage (ratio 1.58)
3. Exported entry points have clear godoc comments

---

Recommended Action

Priority 1 (High — 30 min): Add fmt.Errorf("...: %w", err) wrapping to all 7 bare return err calls in compiler.go. Minimal risk, immediate improvement to debuggability.

Priority 2 (Medium): Add smoke tests to a new compiler_test.go for CompileWorkflow / CompileWorkflowData — enables safe refactoring of CompileWorkflowData (172 lines).

Priority 3 (Low): Introduce a result struct for buildSafeOutputsHandlerOutputsAndActionSteps (currently returns 4 values) and split generatePrompt into logical sub-generators.

---

💾 Cache & Next Run

Git hash: 16cc279 | Cache: /tmp/gh-aw/cache-memory/compiler-quality/

Next rotation (by age):

1. compiler_orchestrator_workflow.go (last: 2026-07-09, score 82)
2. compiler_orchestrator_frontmatter.go (last: 2026-07-09, score 84)
3. compiler_orchestrator_tools.go (last: 2026-07-09, score 80)

Report generated by Daily Compiler Quality Check workflow · Powered by Serena MCP Server

Generated by 📊 Daily Compiler Quality Check · 39.7 AIC · ⌖ 9.02 AIC · ⊞ 9.8K · ◷

• expires on Jul 15, 2026, 7:42 PM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by Daily Compiler Quality Check.

A newer discussion is available at Discussion #45872.