[terminal-stylist] Terminal Stylist Analysis: Console Output Patterns in pkg/

[github-actions[bot]]

Summary

Scanned 1,106 non-test Go files under pkg/. The codebase has a strong console abstraction: pkg/console centralizes styling, TTY-aware rendering, tables, prompts, and spinners; pkg/styles centralizes adaptive colors/themes. Most CLI output uses these correctly. Only 3 raw fmt.Print* call sites exist in non-test production code, and all simply emit already-rendered console output. Manual ANSI is rare and confined to internal console/parser helpers.

Key Metrics

Metric	Value
Total files scanned	1,106
Files using console/lipgloss/huh correctly	~26
Files with issues	1
Raw fmt.Print* call sites	3 (all acceptable)

Console Package Analysis

pkg/console provides:

• TTY-aware styling helpers: FormatSuccessMessage, FormatInfoMessage, FormatWarningMessage, FormatError, section/table/list formatting
• Structured rendering: RenderStruct, RenderTable
• Interactive wrappers: NewForm, NewInputForm, NewSelectForm, NewConfirmForm, IsCancelled
• TTY-aware fallbacks: text confirm/list/input behavior when interactive UI is unavailable
• Spinner support with accessibility and TTY checks

Good patterns:

• pkg/console/console.go:44-60 gates ANSI on TTY and degrades stdout colors via environment-aware color handling.
• pkg/console/prompt_form.go:12-36 standardizes huh theme/accessibility.
• pkg/console/input.go, confirm.go, list.go guard interactive flows with TTY detection.

Lipgloss Usage

Mostly good and centralized.

Good examples:

• pkg/styles/theme.go:103-107 probes terminal background safely, with Windows guardrails.
• pkg/styles/huh_theme.go:13-80 uses lipgloss.LightDark for adaptive form theming.
• pkg/cli/compile_schedule_calendar.go:198-217 applies styles only when terminal output is detected.
• pkg/cli/gateway_logs_timeline_render.go:475-494 wraps styling in TTY checks for stream output.
• pkg/logger/logger.go:51-58,128-141 uses palette-based styles rather than hardcoded ANSI.

Minor concern:

• pkg/console/spinner.go:87,176,195,198,202 uses carriage-return/clear-line ANSI indirectly via constants. This is acceptable for spinner control, but it is one of the few manual terminal-control paths.

Huh Usage

Usage is consistent and correct.

• Interactive workflow authoring in pkg/cli/interactive.go, add_interactive_*.go, run_interactive.go
• Shared themed wrappers via pkg/console/prompt_form.go
• Secret/password entry with masking in pkg/console/input.go
• Confirm/select UIs with non-TTY fallback in pkg/console/confirm.go and pkg/console/list.go

Good examples:

• pkg/console/prompt_form.go:13-29 ensures all forms share styles.HuhTheme and accessibility mode.
• pkg/console/input.go:33 uses EchoModePassword correctly.
• pkg/console/spinner.go:117-122 explicitly avoids stealing input from subsequent huh forms.

Files with Issues

pkg/console/list.go:76 — fmt.Scanf anti-pattern

Uses fmt.Scanf("%d", &choice) in the non-TTY fallback, while the function otherwise accepts a reader abstraction. This bypasses dependency injection and may read from the wrong input source in scripted/non-interactive contexts.

Suggested fix: Use the injected reader (matching the confirm.go pattern) instead of fmt.Scanf.

Recommendations

1. Fix pkg/console/list.go:76 — replace fmt.Scanf with an injected reader to match confirm.go.
2. Keep routing output through pkg/console — the current abstraction is well-structured.
3. Continue avoiding raw ANSI outside low-level terminal control (spinner/parser internals only).
4. Acceptable fmt.Print pattern — using fmt.Print only to emit already-rendered console output is fine in:
   • pkg/cli/logs_report.go:554
   • pkg/cli/status_command.go:288
   • pkg/cli/view_command.go:168
5. Keep new color work in pkg/styles using adaptive colors — current code already avoids hardcoded terminal colors.

References: §29681321005

Generated by 💄 Terminal Stylist · 36.7 AIC · ⌖ 8.31 AIC · ⊞ 5.6K · ◷

• expires on Jul 20, 2026, 1:25 AM UTC-08:00

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-07-20T09:25:51.384Z.

Closed by Workflow