[sergo] Sergo Report: Registry Catch-up + Doc-Sync Root-Cause - 2026-07-21

[github-actions[bot]]

Executive Summary

R74 opened on a large registry jump: the custom-linter registry grew from 43 → 55 analyzers since the last recorded run (R60, 2026-07-08), with no Sergo memory updates in between. All prior Sergo issues are CLOSED (verified via gh api, latest #46708). This run audited the newest analyzer (sprintfbool, the 55th) and traced the recurring doc-sync drift to its root cause. 2 issues filed, both high-confidence and distinct.

Tool / Registry Updates

• Serena LSP tools: 23, stable (no change).
• Registry delta: 43 → 55 (grep -c Analyzer cmd/linters/main.go = 55). 12 linters added across the untracked R61–R73 window.
• Newest linter (55th): sprintfbool — flags fmt.Sprintf("%t", b) → strconv.FormatBool(b).

Strategy — 50/50 split

Cached (proven audit patterns): apply the accumulated new-linter correctness checklist — exact-type vs Underlying() (#44187), RunWithSuggestedFixes parity (#43313), IsPkgSelector vs syntactic match (#43934), alias-safe autofix (#45037), nolint+filecheck wiring, enforce-readiness (zero prod violations → CI).

New exploration: treat the recurring doc-sync drift (#40436/#45185/#46131/#46527/#46707) not as another symptom report but as a test-gap root-cause investigation — why do the guards keep passing while the docs drift?

Findings

1. sprintfbool is genuinely clean — all prior-bug classes avoided

Check	Location	Verdict
Exact bool (not Underlying())	sprintfbool.go:112	✅ named bool skipped → autofix always compiles (avoids #44187)
RunWithSuggestedFixes	sprintfbool_test.go:16	✅ closes #43313 parity gap
astutil.IsPkgSelector	sprintfbool.go:93	✅ not a syntactic X.Name match (avoids #43934)
Alias-safe qualifier	sprintfbool.go:419 ImportedAs+QualifierShadowed	✅ avoids #45037 hardcoded-default bug
nolint+filecheck	sprintfbool.go:36 Requires	✅ suppression + generated-file skip
Untyped literal	fixture badLiteral	✅ Sprintf("%t", true) flagged

The orphan-fmt-import removal logic (countPkgUsesInFile == targetCalls && all fixable) is sound. This linter has absorbed every lesson from the last ~15 runs.

2. Root cause: no test cross-checks the authoritative registry → filed #46977

Four documentation surfaces sit at three different counts, and every guard is green:

Surface	Location	Count
Registry (truth)	cmd/linters/main.go:78-132	55
doc.go header+bullets	pkg/linters/doc.go:3	54
README bullets/table	pkg/linters/README.md	54
spec_test hand-list	pkg/linters/spec_test.go:88 documentedAnalyzers()	46

• TestDocGo_CountMatchesBullets compares doc.go header to its own bullets (54==54) — never reads main.go.
• TestDocGo_AnalyzersMatchREADME compares doc.go to README — both omit sprintfbool, so equal.
• TestSpec_PublicAPI_* only checks the hand-list is a subset of reality (non-nil) — can't catch omissions.

Root cause: the registry is inlined in multichecker.Main(...) in package main (unimportable), so nothing can enumerate it. The symptom has been fixed ≥5 times without closing the gap.

3. sprintfbool enforce-readiness → filed #46978

grep -rn 'Sprintf("%t"' pkg cmd internal | grep -v testdata → only the linter's own doc strings match. Zero production violations. The analyzer is clean and RWSF-verified but absent from .github/workflows/cgo.yml:1208-1211 (24 enforced). Adding -sprintfbool to both LINTER_FLAGS invocations locks in the improvement with no risk today.

Generated Tasks

1. doc-sync guards never cross-check the analyzer registry — sprintfbool (55th, registered) is undocumented in doc.go/README/spec_t [Content truncated due to length] #46977 — Extract the registry into an exported All() []*analysis.Analyzer, consume it from both main.go and a bidirectional completeness test (registry == doc.go == README == spec-list). Immediate patch: doc.go→55 + sprintfbool bullet, README table/bullet/examples, documentedAnalyzers() entry.
2. sprintfbool (new 55th linter) enforce-readiness: clean, type-resolved, RWSF-verified, alias-safe, zero production violations — a [Content truncated due to length] #46978 — Add -sprintfbool to both cgo.yml LINTER_FLAGS invocations (default + wasm).

Metrics

Metric	Value
Serena tools	23 (stable)
Registry	55 (Δ +12 vs R60)
Findings	5
Issues filed	2 (#46977, #46978)
Duplicates skipped	0 open sergo issues pre-run
Success score	9 / 10

Historical Context

Memory had a gap: registry grew 43→55 across R61–R73 with no strategy entries recorded. This run reconciled state and re-established the new-linter audit checklist. Doc-sync drift is now traced to a structural test gap rather than repeated manual fixes.

Recommendations & Next-Run Focus (R75)

• Verify doc-sync guards never cross-check the analyzer registry — sprintfbool (55th, registered) is undocumented in doc.go/README/spec_t [Content truncated due to length] #46977 / sprintfbool (new 55th linter) enforce-readiness: clean, type-resolved, RWSF-verified, alias-safe, zero production violations — a [Content truncated due to length] #46978 landed (team closes fast — gh api reconcile FIRST).
• Audit the 12 un-reviewed new linters (appendoneelement, bytescomparestring, nilctxpassed, trimleftright, timenowsub, logfatallibrary, httprespbodyclose, sprintferrorsnew, httpstatuscode, osgetenvlibrary, mapclearloop, mapdeletecheck) against the correctness checklist.
• %v-on-bool is an intentional non-target (fixture goodOtherVerb) — do not file as a coverage gap.

References:

• §29802163588

Generated by 🤖 Sergo - Serena Go Expert · 419.4 AIC · ⌖ 11.5 AIC · ⊞ 5.8K · ◷

• expires on Jul 21, 2026, 9:02 PM UTC-08:00