[eslint-refiner] ESLint Refiner — Daily Report 2026-07-21

[github-actions[bot]]

Overview

The eslint-factory custom-rule set has grown from 12 rules (last review 2026-07-08) to 23 rules. This run reviewed all 11 newly-added rules (from require-mkdirsync-try-catch through require-execsync-try-catch) plus the shared core-method-resolve / core-aliases / try-catch-rule-utils helpers.

Key context: the target codebase actions/setup/js/** currently has no live sites for any of the newest rules — no process.exit, core.error, execSync/child_process, or console.* in non-test .cjs files. So the newest rules act purely as regression guards, and every finding this run is a rule-logic precision defect (false negative / false positive / unsafe autofix), not a violation in shipped code.

Metrics

Metric	Value
Rules registered	23 (was 12)
Newest rules reviewed	11
Rules judged sound	8
Issues filed	3
Open ESLint issues before run	0 (all prior closed)
Live violations in setup/js	0

Refinement tasks filed

1. require-return-after-core-setfailed — FN: bare switch-case fall-through where core.setFailed() is the last consequent statement is missed (the braced and if-wrapped variants are correctly flagged — an inconsistency). Plus a minor FP on a trailing hoisted function declaration. High confidence, reuses existing findContinuationOutsideBlock machinery.
2. no-core-error-then-process-exit — FN: detection is adjacency-only, so any statement between core.error(...) and process.exit(nonzero) (e.g. a core.summary write) defeats it. Proposed scan-forward that stops at an intervening core.setFailed or control-transfer to avoid false positives.
3. prefer-core-logging — Unsafe autofix: the suggestion rewrites console.log(obj) → core.info(obj), which coerces non-strings to "[object Object]". The report is correct; the suggestion should be restricted to statically-string arguments.

Rules judged sound / lower-priority items (unfiled)

Sound: require-execsync-try-catch (full scope-resolution incl. destructure/alias/namespace), require-spawnsync-error-check (thorough guard-alias analysis), no-exec-interpolated-command, require-new-url-try-catch, no-throw-plain-object, no-core-exportvariable-non-string, and the shared core-method-resolve/core-aliases helpers.

Lower-priority, ungrounded (deferred until live sites appear): niche missed shapes — new globalThis.URL(...) / new node:url.URL(...), inline require('fs').mkdirSync(...), spread-arg forms; a shadowing FP in no-github-request-interpolated-route for a parameter named github; and an if/else-both-transfer FP in require-return-after-core-setfailed.

Documentation debt

eslint-factory/README.md documents 20 of 23 rules. The three undocumented rules are exactly the three newest: require-execsync-try-catch, no-exec-interpolated-command, no-core-error-then-process-exit. Recommend adding their entries; if still absent next run, this will be filed as a dedicated doc issue.

Next actions

• Land tests for the 3 filed refinements (switch fall-through invalid case; trailing-function-decl valid case; intervening core.error→exit invalid case; console.log(obj) reported without a suggestion).
• Document the 3 newest rules in the README.
• Ground and file the deferred niche shapes only if they gain live sites.

References: §29806000813

Generated by 🤖 ESLint Refiner · 455.7 AIC · ⌖ 10.8 AIC · ⊞ 4.6K · ◷

• expires on Jul 21, 2026, 10:19 PM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by ESLint Refiner.

A newer discussion is available at Discussion #47213.