[daily-compiler-quality] Daily Compiler Code Quality Report - 2026-07-30

[github-actions[bot]]

Warning

threat detection engine error
The threat detection engine encountered an error and could not complete analysis. This is a tooling failure, not a security finding.

Details

The threat detection engine failed to produce results.

Review the workflow run logs for details.

🔍 Compiler Code Quality Analysis Report

Analysis Date: 2026-07-30
Files Analyzed: compiler.go, compiler_jobs.go, compiler_safe_outputs_job.go
Overall Status: ⚠️ Some files need attention

---

Executive Summary

pkg/workflow/ has been substantially restructured since the last cached analysis — many previously tracked files (e.g. compiler_orchestrator_workflow.go, compiler_activation_jobs.go) were split, renamed, or merged, and the file list is now ~53 files. All previously cached hashes are stale, so this run refreshed the file inventory and re-analyzed the top-priority core files.

compiler_jobs.go (585 lines) is solid: consistent fmt.Errorf(...%w...) wrapping (20 instances), no bare return err swallowing context, and a large 7.7x test-to-source ratio. compiler.go (584 lines) is readable but has zero %w-wrapped errors and two functions (CompileWorkflowData 172 lines, generateAndValidateYAML 123 lines) that are oversized. compiler_safe_outputs_job.go is the outlier at 1084 lines — well past the 800-line guidance — with a 238-line function (buildSafeOutputsHandlerOutputsAndActionSteps) and a 144-line function (buildJobLevelSafeOutputEnvVars) that should be decomposed.

---

Summary Table

File	Score	Rating	Top Issue
compiler_jobs.go	81/100	✅ Good	buildJobs at 85 lines
compiler.go	72/100	⚠️ Acceptable	No %w error wrapping; 2 oversized functions
compiler_safe_outputs_job.go	66/100	⚠️ Acceptable	File is 1084 lines; 238-line function

Avg score: 73/100 · Files meeting threshold (≥75): 1/3

📁 Detailed File Analysis

1. compiler_jobs.go — 81/100 ✅

• Size: 585 lines · Hash: 8d982ba
• Strengths: 20 fmt.Errorf(...%w...) wraps, zero bare return err, clear job-builder naming (buildJobs, buildMemoryManagementJobs), extensive test suite (4510 lines).
• Issues: buildJobs (85 lines) and buildPreActivationAndActivationJobs (58 lines) could be decomposed into smaller helpers; several exported Compiler methods lack godoc comments.

2. compiler.go — 72/100 ⚠️

• Size: 584 lines · Hash: 8d982ba
• Strengths: CompileWorkflow and CompileWorkflowData both carry clear godoc explaining their distinct entry-point roles; good separation between file-based and pre-parsed-data compilation paths.
• Issues: CompileWorkflowData (172 lines) and generateAndValidateYAML (123 lines) exceed the ~50-line guidance and should be split into focused steps (parse → validate → generate → write). Zero uses of fmt.Errorf with %w, and 7 bare return err statements lose call-site context.

3. compiler_safe_outputs_job.go — 66/100 ⚠️

• Size: 1084 lines · Hash: 8d982ba
• Strengths: Well-named helper functions per concern (steps, env vars, manifest upload); good comment density (247 comment lines).
• Issues: File significantly exceeds the 800-line guidance — candidate split points: step-building (buildSafeOutputsSetupAndDownloadSteps, buildSafeOutputsHandlerOutputsAndActionSteps) vs. env/condition logic (buildJobLevelSafeOutputEnvVars, buildSafeOutputsJobCondition). buildSafeOutputsHandlerOutputsAndActionSteps (238 lines) and buildJobLevelSafeOutputEnvVars (144 lines) are both well above the 50-line guidance. Only 5 %w-wrapped errors across 1084 lines.

---

Top 3 Issues

1. compiler_safe_outputs_job.go is 1084 lines with a 238-line function — split by concern (steps vs. env-var/condition building).
2. compiler.go has zero %w-wrapped errors and two functions over 120 lines (CompileWorkflowData, generateAndValidateYAML).
3. buildJobs in compiler_jobs.go (85 lines) and several exported methods across all three files lack godoc comments.

Recommended Action

Priority: split buildSafeOutputsHandlerOutputsAndActionSteps (238 lines) in compiler_safe_outputs_job.go into focused sub-steps — estimated 2-3 hours, highest-impact readability/maintainability win.

---

💾 Cache Memory Summary

Cache Location: /tmp/gh-aw/cache-memory/compiler-quality/

• The cached file inventory was stale (last update assumed a different pkg/workflow/ layout with ~24 files under old names). Refreshed to the current 53-file listing under rotation.json.
• All three analyzed files hashed to the current HEAD commit 8d982ba (repo-wide, single commit hash for all files — likely a squashed history in this environment).
• Files never yet analyzed in current form include most of the newly split files (e.g. compiler_activation_context.go, compiler_yaml_step_conversion.go, compiler_orchestrator_engine.go) — prioritized for upcoming runs.

Next Analysis Schedule: compiler_yaml.go, compiler_safe_outputs.go, compiler_orchestrator.go (all small/core files not yet re-analyzed under current structure).

---

Conclusion

Average score 73/100 — below the 75-point human-written-quality threshold, driven mainly by compiler_safe_outputs_job.go's size and function length. compiler_jobs.go demonstrates the target error-handling and testing standard for the package. Next steps: decompose the two oversized functions identified above and add %w error wrapping to compiler.go.

---

Report generated by Daily Compiler Quality Check workflow
Analysis powered by Serena MCP Server
Cache memory: /tmp/gh-aw/cache-memory/compiler-quality/

Generated by 📊 Daily Compiler Quality Check · aut00 · 33.6 AIC · ⊞ 14.1K · ◷

• expires on Jul 30, 2026, 7:38 PM UTC-08:00

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-07-31T03:38:12.765Z.

Closed by Workflow