[daily-compiler-quality] Daily Compiler Code Quality Report - 2026-08-03

[github-actions[bot]]

🔍 Compiler Code Quality Analysis Report

Analysis Date: 2026-08-03
Files Analyzed: compiler_workflow_call.go, compiler_safe_outputs_steps.go, compiler_yaml_prompt.go
Overall Status: ⚠️ Some files need attention

---

Executive Summary

Today's rotation covered three previously unanalyzed compiler files handling workflow_call I/O injection, safe-outputs step generation, and prompt assembly. compiler_workflow_call.go is a standout — clean single-purpose functions, thorough doc comments explaining edge cases (uniqueness guarantees, template-injection mitigations), and solid test coverage (447 test lines vs 353 source lines).

The other two files fall into the "Acceptable" band. compiler_safe_outputs_steps.go concentrates too much logic in one 250-line function (buildHandlerManagerStep) that mixes app-token minting, env-var assembly, and token-resolution concerns. compiler_yaml_prompt.go is well decomposed but has no dedicated test file, the most significant maintainability gap found today.

None of the three files use fmt.Errorf with %w wrapping, though compiler_safe_outputs_steps.go does propagate errors via plain return nil, err.

---

Summary Table

File	Score	Rating	Top Issue
compiler_workflow_call.go	86/100	✅ Good	No error wrapping (minor)
compiler_safe_outputs_steps.go	74/100	⚠️ Acceptable	buildHandlerManagerStep ~250 lines, low cohesion
compiler_yaml_prompt.go	70/100	⚠️ Acceptable	No _test.go file exists

Avg score: 77/100 · Files meeting threshold (≥75): 1/3

---

📁 Detailed File Analysis

1. compiler_workflow_call.go — 86/100 ✅

• Lines: 353 · Functions: 8 · Test file: compiler_workflow_call_test.go (447 lines)
• Strengths: Exceptional doc comments (explains uniqueness guarantees for artifact prefixes, security rationale for env-var-based input passing); clean, focused functions each with one job (injectWorkflowCallOutputs, injectWorkflowCallSecretsSection); graceful degradation on YAML parse errors (logs warning, returns original section).
• Issues: No fmt.Errorf/%w wrapping — errors are logged and swallowed rather than surfaced to callers, which could hide failures in CI. injectWorkflowCallSecretsSection has to handle multiple on: shorthand forms (map/string/slice), adding branching complexity.

2. compiler_safe_outputs_steps.go — 74/100 ⚠️

• Lines: 340 · Functions: 2 · Test file: compiler_safe_outputs_steps_test.go (587 lines, healthy ratio)
• Strengths: Excellent inline security/rationale comments (token precedence, credential persistence). Good test coverage.
• Issues: buildHandlerManagerStep is a single ~250-line function assembling app-token steps, a dozen conditional env vars, and the final script step — violates single-responsibility. Recommend extracting: addAppTokenMintingSteps, addSafeOutputEnvVars (many pieces already exist as c.addXxxEnvVars calls but the main function still orchestrates too much inline logic directly). Only 2 top-level functions for 340 lines signals functions are oversized rather than the file being over-scoped.

3. compiler_yaml_prompt.go — 70/100 ⚠️

• Lines: 336 · Functions: 11 · Test file: none found
• Strengths: Good decomposition — generatePrompt orchestrates small well-named helpers (enrichExpressionMappings, buildMainWorkflowPromptChunks, processOrderedPromptImports vs processLegacyPromptImports). Clear comments describing the "NEW APPROACH" migration rationale for runtime-import macros.
• Issues: No compiler_yaml_prompt_test.go — this is the most significant gap since prompt-chunking/import-interleaving logic is non-trivial (compile-time inlining vs runtime-import fallback, expression mapping merges) and currently relies entirely on indirect/integration coverage elsewhere.

---

Top 3 Issues

1. Missing test file for compiler_yaml_prompt.go — chunking/import logic untested in isolation.
2. Oversized function buildHandlerManagerStep (~250 lines) in compiler_safe_outputs_steps.go mixes multiple concerns.
3. No files analyzed today use fmt.Errorf(...%w...) error wrapping — errors are logged/swallowed instead of propagated with context.

Recommended Action

Priority: Add a compiler_yaml_prompt_test.go covering splitContentIntoChunks, processOrderedPromptImports, and processLegacyPromptImports (estimated 2-3 hours) — this is the highest-value gap since the file currently has zero direct unit tests.

---

💾 Cache Memory Summary

Cache Location: /tmp/gh-aw/cache-memory/compiler-quality/

• Files analyzed today: 3 (all first-time analyses)
• Total files tracked: 29
• Next priority files: compiler_activation_context.go, compiler_activation_outputs.go, compiler_yaml_checkout.go

---

Report generated by Daily Compiler Quality Check workflow · Cache memory: /tmp/gh-aw/cache-memory/compiler-quality/

Generated by 📊 Daily Compiler Quality Check · auto · 31.5 AIC · ⌖ 5.93 AIC · ⊞ 14.2K · ◷

• expires on Aug 3, 2026, 7:45 PM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by Daily Compiler Quality Check.

A newer discussion is available at Discussion #50161.