[delight] User Experience Analysis Report - 2026-08-04 #50298
Closed
Replies: 1 comment
|
This discussion has been marked as outdated by Delight. A newer discussion is available at Discussion #50588. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Executive Summary
Today's analysis focused on:
third-party-agent.md,ai-issue-triage.md)smoke-update-cross-repo-pr.md,discussion-task-miner.md)dangerous_permissions_validation_test.go/dangerous_permissions_validation.go)Overall Quality: Professional overall, with one confirmed broken documentation reference in a user-facing compiler error message.
Key Finding: The dangerous-permissions compile error points users to
docs/safe-outputs.md, a path that does not exist in this repository — every other validator in the codebase correctly links tohttps://github.github.com/gh-aw/reference/safe-outputs/.Quality Highlights ✅
Example 1: Third-party agent integration guide
docs/src/content/docs/guides/third-party-agent.mdshared/opencode.mdfor a vendored definition, orowner/repo/.github/workflows/opencode-engine.md@v1.2.14to import a published one — pin remote imports to a tag or SHA to control when you pick up new versions." — precise, actionable, and anticipates the security question of pinning.Example 2: Discussion Task Miner workflow messages
.github/workflows/discussion-task-miner.mdmessagesblock uses a consistent voice acrossrun-started/run-success/run-failure, sparingly uses one emoji per message tied to the workflow's purpose (⛏️/✅/run-failureexplicitly directs the user to "review the logs" — an actionable next step.Improvement Opportunities 💡
High Priority
Opportunity 1: Broken documentation link in dangerous-permissions error message
pkg/workflow/dangerous_permissions_validation.goformatDangerousPermissionsErrorreads:lines = append(lines, "which uses a scoped GitHub App token. See: docs/safe-outputs.md")docs/safe-outputs.mddoes not exist anywhere in the repository. Every comparable validator (e.g.strict_mode_permissions_validation.go:37,compiler_main_job_helpers.go:344,compiler_activation_permissions.go:246) links instead to the published reference URLhttps://github.github.com/gh-aw/reference/safe-outputs/. This is the only write-permission-related error in the codebase using a broken/inconsistent path instead of the canonical published URL.contents: writeetc. directly to a workflow) and clicks/copies the referenced path finds nothing — increasing friction exactly at a security-relevant decision point.Files Reviewed
Documentation
docs/src/content/docs/guides/third-party-agent.md- Rating: ✅docs/src/content/docs/guides/ai-issue-triage.md- Rating: ✅Workflow Messages
.github/workflows/smoke-update-cross-repo-pr.md- Rating: ✅ (internal smoke test, appropriately terse).github/workflows/discussion-task-miner.md- Rating: ✅Validation Code
pkg/workflow/dangerous_permissions_validation.go- Rating:Metrics
🎯 Actionable Tasks
Here is 1 targeted improvement task affecting a single file:
Task 1: Fix broken documentation link in write-permissions compile error
File to Modify:
pkg/workflow/dangerous_permissions_validation.goCurrent Experience
When a workflow author adds a write permission (e.g.
contents: write) directly to the agent job,gh aw compilefails with a formatted error (seeformatDangerousPermissionsError, lines 81-100) that tells the user to consultdocs/safe-outputs.mdfor the recommended safe-outputs pattern. That path does not exist in the repository or published docs site.Quality Issue
Design Principle: Trust and Reliability
Pointing users to a non-existent reference at the exact moment they need guidance to resolve a security-relevant compile error undermines trust in the tool's error messages and wastes the user's time searching for the right doc.
Proposed Improvement
Update line 85 to reference the canonical, working reference URL already used consistently elsewhere in the codebase (e.g.
strict_mode_permissions_validation.go:37).Before:
After:
Why This Matters
Success Criteria
docs/safe-outputs.mdreference replaced withhttps://github.github.com/gh-aw/reference/safe-outputs/inpkg/workflow/dangerous_permissions_validation.gopkg/workflow/dangerous_permissions_validation_test.gocontinues to pass (it does not assert on this specific substring, so no test update needed, but consider adding one)Scope Constraint
pkg/workflow/dangerous_permissions_validation.goWarning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
storage.googleapis.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.
All reactions