[terminal-stylist] Terminal Stylist: Console Output & Lipgloss/Huh Consistency Report

[github-actions[bot]]

Analysis of console output patterns across pkg/ (1,181 non-test .go files scanned).

Summary

The codebase has a mature, well-centralized pkg/console package (37 files) with 247 files consuming it. Lipgloss (via charm.land/lipgloss/v2) and Huh (via charm.land/huh/v2) are already wrapped behind this package with adaptive theming (pkg/styles/theme.go, pkg/styles/huh_theme.go). Only a handful of raw fmt.Print* calls remain, and they are justified.

Key Metrics

Pattern	Count
Files using console.*	247
Files using raw fmt.Print* (non-test, non-testdata, non-linter-source)	2
Files using lipgloss directly	10 (mostly inside pkg/console/pkg/styles, as expected)
Files using huh directly	15 (mostly interactive add/bootstrap CLI flows)
Manual ANSI escape sequences outside pkg/stringutil/pkg/console	0
Hardcoded (non-adaptive) lipgloss.Color(...) outside pkg/styles	0

Files using console formatters correctly (representative)

• pkg/console/console.go — central formatter API: FormatError, FormatSuccessMessage, FormatInfoMessage, FormatWarningMessage, FormatSectionHeader, RenderTable, RenderTitleBox, RenderErrorBox, all with *Stderr counterparts and TTY-aware variants.
• pkg/console/confirm.go, input.go, list.go, prompt_form.go — wrap Huh forms with a themed NewConfirmForm/NewInputForm, and gracefully fall back to plain text prompts via tty.IsStderrTerminal() when not in a TTY (showTextConfirm).
• pkg/console/accessibility.go — IsAccessibleMode() checks ACCESSIBLE, TERM=dumb, NO_COLOR and is designed to be consulted before enabling spinners/animations.
• pkg/styles/huh_theme.go — maps the same Dracula-inspired adaptive palette (lipgloss.LightDark) used elsewhere into Huh's ThemeFunc, giving forms visual parity with the rest of the CLI.
• pkg/cli/status_command.go, pkg/cli/view_command.go — use console.FormatInfoMessage/FormatWarningMessage for status/errors, reserving raw fmt.Print only for already-fully-rendered blocks (console.RenderStruct(...), a pre-rendered timeline stream) — this is an acceptable pattern since the styling decision was already made upstream.

Files/areas needing improvement

1. pkg/cli/logs_format_compact.go — uses text/tabwriter for two aligned tables (lines ~113, ~286) instead of console.RenderTable/lipgloss/table. This bypasses the adaptive color/TTY-degradation logic that console.RenderTable already provides (see pkg/console/console.go:245 RenderTable, pkg/console/console.go:289 renderTableWithTTY). Recommend migrating these two tables to console.TableConfig + console.RenderTable for consistent borders/coloring and automatic plain-text degradation on non-TTY output (CI logs, pipes).
2. No interactive Huh forms outside pkg/console and pkg/cli/add_interactive_*/bootstrap_profile_*/run_interactive.go/engine_secrets.go/interactive.go were found still using bare fmt.Scan/manual prompts, so there is no consolidation work needed there — all interactive prompts already route through the shared console wrappers.
3. pkg/linters/hardcodedfilepath/hardcodedfilepath.go contains fmt.Print* only in a comment referencing fmt.Println as an example of what the linter flags — not an actual violation.

Lipgloss-specific notes

• Adaptive colors are used consistently: all color vars in pkg/styles/theme.go and huh_theme.go are defined as light/dark pairs combined via lipgloss.LightDark(isDark), not hardcoded ANSI/hex values baked into call sites.
• TTY detection is centralized in pkg/console/console.go (isTTY, isStderrTTY, applyStyleWithTTY) and consistently used before styling is applied — every Format* function has a TTY-aware code path and most have a *Stderr variant, avoiding stray ANSI codes leaking into piped/redirected output.
• Table rendering already centralized via console.RenderTable/TableConfig with per-cell style functions (buildTableStyleFunc) and TTY degradation (renderTableWithTTY), except for the two tabwriter usages noted above.
• No manual ANSI escape sequences found outside the two dedicated low-level files (pkg/stringutil/ansi.go for text width calculations, pkg/console/terminal.go for terminal capability probing) — both legitimate, low-level use cases rather than app-level styling.

Huh-specific notes

• Field validation is present (e.g. PromptSecretInput in pkg/console/input.go validates non-empty input).
• Accessibility: IsAccessibleMode() exists but its usages should be double-checked for coverage across all spinner/animation call sites in a follow-up (not verified line-by-line here due to scope) — recommend a dedicated pass confirming every console spinner/progress component consults IsAccessibleMode() before animating.
• Non-TTY fallback: ConfirmAction/PromptSecretInput correctly detect non-TTY environments and either fall back to plain text (confirm.go) or return a clear error (input.go) rather than hanging or corrupting output.

Recommendations

1. Migrate the two tabwriter-based tables in pkg/cli/logs_format_compact.go to console.RenderTable for consistent styling and TTY degradation.
2. Follow up with a targeted audit confirming all console spinner/progress/animation code paths check console.IsAccessibleMode() before rendering.
3. No other action needed — current fmt.Print* usages are limited to two call sites that print already-fully-rendered console-produced strings, which is an acceptable pattern.

References: Analysis performed via static grep across pkg/ in workflow run §30993424579.

Generated by 💄 Terminal Stylist · auto · 26.4 AIC · ⌖ 3.67 AIC · ⊞ 8.2K · ◷

• expires on Aug 6, 2026, 1:34 AM UTC-08:00

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-08-06T09:34:03.426Z.

Closed by Workflow