Repository navigation
[daily-compiler-quality] Daily Compiler Code Quality Report - 2026-08-17 #53272
Closed
Replies: 1 comment
|
This discussion has been marked as outdated by Daily Compiler Quality Check. A newer discussion is available at Discussion #53563. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Compiler Code Quality Analysis Report
Analysis Date: 2026-08-17
Files Analyzed: compiler.go, compiler_jobs.go, compiler_safe_outputs_job.go
Overall Status: Some files need attention.
Executive Summary
We analyzed three compiler files. Each file has a test file. Each test file is large. Error handling looks solid in two files.
The
compiler.gofile has one large function.CompileWorkflowDatais 186 lines long. This function should split into smaller helper functions.compiler_safe_outputs_job.gois the largest file. It has 1065 lines and 31 functions. One function,buildJobLevelSafeOutputEnvVars, is 144 lines long.Detailed File Analysis
1.
compiler.go- Score: 74/100Size: 605 lines, 8 functions
Test file:
compiler_test.go(1095 lines)CompileWorkflowDatais 186 lines. This is too long.%werror wraps. Add error wrapping for clearer context.Top issues: one 186-line function; no error wrapping with
%w.2.
compiler_jobs.go- Score: 80/100Size: 703 lines, 24 functions
Test file:
compiler_jobs_test.go(4511 lines)%werror wraps. This is good practice.buildJobsis 91 lines. Consider splitting.Top issues:
buildJobsfunction is 91 lines long.3.
compiler_safe_outputs_job.go- Score: 71/100Size: 1065 lines, 31 functions
Test file:
compiler_safe_outputs_job_test.go(1730 lines)buildJobLevelSafeOutputEnvVarsis 144 lines long.%werror wraps for 31 functions.Top issues: file size over 1000 lines; one function is 144 lines; low error-wrap ratio.
Summary Table
buildJobsfunction is 91 lines longAvg score: 75/100 · Files meeting threshold (≥75): 1/3
Top 3 Issues
CompileWorkflowDatain compiler.go is 186 lines long. Split it into smaller functions.compiler_safe_outputs_job.gohas 1065 lines. Split it into two or three files.compiler.gohas zero error wraps with%w. Add error context to failures.Recommended Action
Split
CompileWorkflowDatainto smaller functions. This takes about 2 hours.Cache Memory Summary
Cache Location:
/tmp/gh-aw/cache-memory/compiler-quality/Next run should prioritize the 6 remaining files, since they have never been analyzed.
Conclusion
The three files average 75/100. One file meets the quality threshold. The other two files need refactoring for size and error handling.
Next Steps:
CompileWorkflowDatain compiler.go.compiler_safe_outputs_job.gointo smaller files.%werror wrapping in compiler.go.Report generated by Daily Compiler Quality Check workflow
Analysis powered by Serena MCP Server and static Go metrics
Cache memory:
/tmp/gh-aw/cache-memory/compiler-quality/All reactions