[terminal-stylist] Terminal Stylist: Console Output Consistency Review

[github-actions[bot]]

Summary

Analyzed all non-test .go files in pkg/ for console output patterns (fmt.Print*, console.*, Lipgloss, Huh). Overall the codebase is highly consistent and follows Charmbracelet ecosystem best practices well.

Findings

✅ Consistent usage

• pkg/console (257 call sites across the repo) is the standard output layer, wrapping fmt.Fprintln/Fprintf to stdout/stderr with console.FormatInfoMessage, FormatWarningMessage, FormatErrorMessage, RenderStruct, etc. No ad-hoc message formatting was found outside this package.
• All Lipgloss usage (pkg/styles/theme.go, pkg/styles/huh_theme.go, pkg/console/{render,console,banner}.go, pkg/cli/{engine_secrets,compile_schedule_calendar}.go, pkg/logger/logger.go) relies on adaptive colors (adaptiveColor / lipgloss.LightDark) — no hardcoded hex colors were found leaking outside pkg/styles.
• Huh forms are centralized via console.NewForm/NewSelectForm/NewInputForm/NewConfirmForm (pkg/console/{prompt_form,input,list,confirm}.go), which apply styles.HuhTheme and WithAccessible(IsAccessibleMode()) uniformly — every call site in pkg/cli (interactive.go, add_interactive_.go, run_interactive.go, engine_secrets.go, bootstrap_profile_.go) goes through these wrappers, so accessibility mode and theming are applied consistently.
• TTY/terminal detection is centralized in pkg/console/terminal.go and consumed via console.* helpers rather than ad-hoc isatty checks scattered through business logic.

🟡 Minor / acceptable exceptions

• pkg/cli/status_command.go:295 and pkg/cli/view_command.go:168 use raw fmt.Print — both print output that was already rendered by console.RenderStruct / renderUnifiedTimelineStream, so this is a reasonable exception (avoids adding a trailing newline) rather than an inconsistency.
• pkg/console/terminal.go contains two raw ANSI escape sequences (\033[H\033[2J, \033[K") for clear-screen/clear-line. These are low-level terminal control operations without a direct Lipgloss equivalent, so keeping them as raw escapes here is appropriate — but they are isolated to this single file, which is good encapsulation.
• Remaining fmt.Print* hits are all in test fixtures/linter testdata (pkg/linters/**/testdata), not production code, so they don't affect real CLI output.

No issues found in:

• Color hardcoding outside pkg/styles
• Manual ANSI styling in place of Lipgloss
• Missing TTY detection before styled output
• Table formatting inconsistency (all funnel through console.RenderStruct)

Recommendations

1. No urgent changes needed — the console/Lipgloss/Huh architecture is already centralized and consistent.
2. Optionally, add a short doc comment at the two fmt.Print call sites (status_command.go, view_command.go) noting why raw fmt.Print is used instead of a console.* helper, to prevent future contributors from "fixing" it inconsistently.
3. Consider consolidating the two raw ANSI sequences in terminal.go behind named helper functions (e.g., ClearScreen(), ClearLine()) if not already exposed, for discoverability — quick check showed they're already scoped as package constants, so this is a nice-to-have only.

No functional defects were identified; this is a maintenance/consistency review only.

Generated by 💄 Terminal Stylist · auto · 21.4 AIC · ⌖ 2.26 AIC · ⊞ 8.2K · ◷

• expires on Aug 20, 2026, 12:56 AM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by Terminal Stylist.

A newer discussion is available at Discussion #54198.