[terminal-stylist] Console output audit for gh-aw #55722
Closed
Replies: 1 comment
|
This discussion was automatically closed because it expired on 2026-08-26T09:00:12.192Z.
|
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Summary
The repo already has a strong terminal presentation layer.
pkg/consoleprovides TTY-aware message formatting, accessibility-aware rendering, themedhuhforms, and spinner/progress components, and the interactive CLI flows are using them in the right places.What is working well
pkg/logger/logger.gouseslipglossand adaptive colors for debug output, withDEBUG/ACTIONS_RUNNER_DEBUGgating and stderr-safe logging.pkg/cli/run_interactive.go,pkg/cli/add_interactive_git.go,pkg/cli/add_interactive_auth.go, and related files consistently useconsole.NewSelectForm,console.NewInputForm, andconsole.NewConfirmFormrather than ad-hoc prompts.pkg/consolealready handles non-TTY fallback behavior, ANSI degradation, and accessible mode, which aligns well with the Charmbracelet ecosystem guidance.Remaining gaps
fmt.Fprintf/fmt.Fprintlnoutput in places such ascmd/gh-aw/main.gofor version/help paths andpkg/cli/run_interactive.gofor non-TTY menu text. These are functional, but they bypass the repo’s styling conventions and make the UX less consistent.pkg/cli/add_interactive_git.goand the text-selection prompt inpkg/cli/run_interactive.go. These would benefit from section/list helpers or a dedicated console rendering helper.internal/toolsand the standalone lint script inscripts/use plainfmtoutput for basic CLI help and status lines. Those are lower priority, but they would still benefit from a common style wrapper if the project wants a single terminal UX standard.Recommended next steps
cmd/gh-aw/main.goaroundconsole.Format*helpers instead of rawfmtwrites.consolesection/list helpers where possible, while preserving the existing non-TTY fallback behavior.fmt.Fprint*calls on stderr/stdout outsidepkg/consoleare easier to spot.Bottom line
The console experience is already strong, especially for interactive flows and debug logging. The main opportunity is to reduce the remaining hand-rolled text output so the CLI feels more uniform and easier to maintain.
All reactions