[eslint-refiner] ESLint Refiner Daily Report 2026-09-20: 3rd consecutive 0-issue run, all 62 rules reviewed #62127
Closed
Replies: 1 comment
|
This discussion was automatically closed because it expired on 2026-09-21T05:29:44.080Z.
|
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Overview
Day 20 of the ESLint Refiner sweep. No new refinement issues were filed today — the third consecutive 0-issue run — after closing out the two theories carried over from yesterday. All 62 registered
gh-aw-custom/*rules have now been reviewed at least once.Key metrics
What was reviewed
Closed out the two rules carried from yesterday's
nextPriorities:no-misplaced-error-code-definition— tested three hypotheses, all zero-grounded against the liveactions/setup/jscorpus:_ERROR_CODE/_REASON_CODEsuffix-only match missing other*_CODEnames) — every other_CODE-suffixed constant found (SIGNAL_TERMINATION_EXIT_CODES,CODE_PUSH_TYPES, etc.) is an unrelated concept, not a misplaced error/reason code.require(...).Xmember access could be wrongly flagged as a local definition) — zero live occurrences; the only two files destructuring the one existing centralized code (POLICY_FILE_PROTECTION_DENIED_REASON_CODE) consume it internally, never re-export it.const { X_ERROR_CODE } = require(...)isn't tracked by the rule'sVariableDeclarationvisitor, since it only matches simpleIdentifierbindings) — a real structural gap, but the registry currently has only one code total, so there's no live case of a destructured-then-re-exported code to trigger it.require-error-code-for-github-api-throw— thecatchClauseRethrowsindirect-rethrow-via-helper-function theory (acatchblock that delegates to a throwing helper instead of a literalthrow, which the rule's reachability logic can't see into). Sampled roughly ten files that both importerror_codes.cjsand use thewithRetrywrapper-call shape. Every livecatchnear a GitHub API call either literally throws (correctly detected) or swallows viacore.warning/core.info(correctly excluded) — no helper-mediated rethrow sites found.Both theories are now retired per the project's established diminishing-returns practice (two dedicated passes each, no fresh angle).
Full investigation notes and grep evidence
no-misplaced-error-code-definition — grepped every top-level
^const [A-Z_]*CODE[A-Z_]* =declaration acrossactions/setup/js/*.cjs. Candidates likeERROR_CODE_PREFIX_RE,SUMMARY_SAFE_ERROR_CODES,SIGNAL_TERMINATION_EXIT_CODES,CODE_PUSH_TYPES,AGENT_EXECUTION_EXIT_CODE_PATH, andCRASH_SIGNAL_EXIT_CODESwere all inspected — none are error/reason codes that should be centralized. The only genuine registry code,POLICY_FILE_PROTECTION_DENIED_REASON_CODE, is destructured fromerror_codes.cjsinapprove_workflow_run.cjsandpush_to_pull_request_branch.cjs, both consuming it as an internalreasonCode:property value rather than re-exporting it — so neither the FP nor FN theory has a live trigger today.require-error-code-for-github-api-throw — sampled
create_pull_request.cjs,push_to_pull_request_branch.cjs, and the other files intersecting thewithRetry-user set witherror_codes.cjsimporters. Representative catch shapes found:throw error;(literal, correctly attributed),core.warning(...)swallow-and-continue (correctly excluded — no rethrow), and nested fallback retries via direct recursive calls (also literal throws at the base). No case where a catch handler calls out to a separate named helper function whose body contains the actualthrow.Corpus-change detection revisited — the 2026-09-19 squash commit
ff2eccd(#61938) touches nearly all ofactions/setup/jsbut is a shallow-clone base snapshot, not incremental churn, reconfirming that git log/diff cannot be used to detect "what's new since last run" in this repository.Next actions
.cjsfiles) over re-deriving retired theories.try-catch-rule-utils.tsVariableDeclaration-suggestion gap (affects ~14 fs-sync/child-process-family rules, twice filed and expired as eslint-factory: shared try/catch suggestion builder silently skips VariableDeclaration call sites #57868 with no fix uptake) is a source-level fix, not an issue-filing target — but this workflow has nocreate_pull_requestsafe-output tool, so it can only be flagged here for a human or a PR-capable workflow to pick up.memory/eslint-refinerbranch) updated with this run's findings; validated at 33 KB total / well under the 12 KB patch limit.Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
api.anthropic.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.
All reactions