[repository-quality] Repository Quality: Uncancellable Subprocess Execution (exec.Command Without Context)

[github-actions[bot]]

🎯 Repository Quality Improvement Report - Uncancellable Subprocess Execution (exec.Command Without Context)

Analysis Date: 2026-09-29
Focus Area: Uncancellable Subprocess Execution
Strategy Type: Custom
Custom Area: Yes — the repo already ships an execcommandwithoutcontext linter that is enabled in CI, but it only flags calls inside functions that already take a context.Context. The debt lives in functions that have no ctx at all, which the linter cannot see.

Executive Summary

Non-test code under pkg/ contains 93 exec.Command( calls (83 in pkg/cli, 10 in pkg/workflow/pkg/gitutil/pkg/parser) versus only 41 exec.CommandContext( calls in pkg/cli. About 67 of the calls run git. Many are network-bound operations (git pull --rebase, git push --force, git fetch, git ls-remote, docker pull, npm view, pip index versions) with no cancellation or timeout, so Ctrl-C and command timeouts cannot stop a hung child process.

The CI linter gate is green because the analyzer requires an enclosing ctx parameter. The real gap is ctx not being threaded through helper layers such as pkg/cli/git.go, pr_command.go, trial_repository.go, trial_helpers.go and add_interactive_git.go. Prioritise network-bound git/docker/npm/pip calls first, then thread ctx through the helpers.

Full Analysis Report

Focus Area: Uncancellable Subprocess Execution

Current State Assessment

Metrics Collected:

Metric	Value	Status
exec.Command( in non-test pkg/ code (excl. linter testdata)	93	❌
exec.CommandContext( in pkg/cli non-test	41	⚠️
exec.Command("git"...) calls	~67	❌
Hot files: cli/pr_command.go, cli/git.go	20 each	❌
cli/trial_repository.go / trial_helpers.go / add_interactive_git.go	8 / 5 / 4	⚠️
pkg/workflow validators (docker, npm, pip)	5	⚠️
context.Background() in non-test code	53	⚠️
execcommandwithoutcontext linter in CI (cgo.yml)	enabled	✅

Findings

Strengths

• Linters execcommandwithoutcontext, ctxbackground, nilctxpassed and timesleepnocontext exist and are gated in CI.
• Linter has a SuggestedFix.

Areas for Improvement

• (High) Network-bound git operations without ctx: pkg/cli/trial_repository.go:635-700, trial_helpers.go:473-480, add_interactive_git.go:258-309, pr_command.go:289-294.
• (High) Destructive git commands (reset --hard, clean -fd, push --force) at pr_command.go:264-267, trial_repository.go:700 run non-cancellably.
• (Medium) External-tool validators in pkg/workflow/{docker,npm,pip}_validation.go hit the network with no timeout.
• (Medium) Linter blind spot: no signal for ctx-less functions that shell out.
• (Low) pkg/cli/git.go has 20 wrappers that should be the ctx-aware choke point.

Detailed Analysis

Because the analyzer only walks Enclosing(FuncDecl, FuncLit) to find a ctx parameter, exec calls in ctx-less helpers are never reported. Threading ctx from cobra cmd.Context() down through helpers fixes this and lets the existing linter enforce it thereafter.

---

🤖 Tasks for Copilot Agent

NOTE TO PLANNER AGENT: Split the following tasks into individual work items.

Improvement Tasks

Task 1: Thread context through pkg/cli/git.go wrappers

Priority: High
Estimated Effort: Medium
Focus Area: Uncancellable Subprocess Execution

Description: Convert the 20 exec.Command git wrappers to accept ctx context.Context and use exec.CommandContext; update callers.

Acceptance Criteria:

• No exec.Command( remains in pkg/cli/git.go
• Callers pass cmd.Context() or an existing ctx
• make test-unit passes

Code Region: pkg/cli/git.go

Refactor pkg/cli/git.go so every function that runs git takes ctx context.Context as its first parameter and uses exec.CommandContext. Update all callers, propagating the ctx from cobra commands. Keep behavior unchanged.

---

Task 2: Context-aware network git operations in trial/add-interactive/pr flows

Priority: High
Estimated Effort: Medium
Focus Area: Uncancellable Subprocess Execution

Description: Convert pull/push/fetch/ls-remote/checkout calls to CommandContext.

Acceptance Criteria:

• Zero exec.Command( in the four files below
• Tests updated and passing

Code Region: pkg/cli/trial_repository.go, pkg/cli/trial_helpers.go, pkg/cli/add_interactive_git.go, pkg/cli/pr_command.go

In the listed files replace exec.Command with exec.CommandContext, threading ctx through the helper signatures from the command entry points. Do not change command arguments.

---

Task 3: Add timeouts/ctx to external-tool validators

Priority: Medium
Estimated Effort: Small
Focus Area: Uncancellable Subprocess Execution

Description: docker image inspect/pull, npm view, pip index versions, uv pip show should use CommandContext with a bounded timeout.

Acceptance Criteria:

• Each call uses CommandContext with a timeout derived from a caller ctx
• Timeout errors produce actionable messages

Code Region: pkg/workflow/docker_validation.go, npm_validation.go, pip_validation.go

Update the validators to accept a context, wrap with context.WithTimeout (constants for durations), and use exec.CommandContext. Ensure errors on timeout are actionable.

---

Task 4: Close the linter blind spot

Priority: Medium
Estimated Effort: Medium
Focus Area: Uncancellable Subprocess Execution

Description: Add an opt-in mode (or new analyzer) reporting exec.Command in non-test production code even without a ctx parameter, in packages already migrated, so regressions are caught.

Acceptance Criteria:

• Analyzer flags ctx-less exec.Command with testdata
• Enabled in cgo.yml LINTER_FLAGS for migrated packages only

Code Region: pkg/linters/execcommandwithoutcontext/, .github/workflows/cgo.yml

Extend execcommandwithoutcontext with a flag (default off) `-execcommandwithoutcontext.strict` that flags any exec.Command in non-test code. Add testdata and enable it in cgo.yml for migrated packages.

---

📊 Historical Context

Previous Focus Areas

Date	Focus Area	Type	Custom	Key Outcomes
2026-09-25	CLI Sibling-Command Flag Parity	Custom	Y	Flag/safety guard gaps
2026-09-28	Skill Documentation Drift (3rd audit)	Custom	Y	Stale JS location refs

---

🎯 Recommendations

Immediate Actions (This Week)

1. Migrate pkg/cli/git.go and network git flows — Priority: High

Short-term Actions (This Month)

1. Validator timeouts — Priority: Medium

Long-term Actions (This Quarter)

1. Strict linter mode in CI — Priority: Low

---

📈 Success Metrics

• Non-test exec.Command( in pkg/: 93 → 0 (excluding intentional cases)
• Network subprocesses with cancellation: partial → 100%

---

Next Steps

1. Review and prioritise the tasks above
2. Assign tasks to Copilot coding agent via planner agent
3. Track progress on improvement items
4. Re-evaluate this focus area in one month

---

Generated by Repository Quality Improvement Agent
Next analysis: 2026-09-30 — Focus area selected by diversity algorithm

Generated by ⚡ Repository Quality Improvement Agent · copilot · auto · 25 AIC · ⌖ 5.85 AIC · ⊞ 9.7K · ◷

• expires on Sep 30, 2026, 5:07 AM UTC-08:00