[sergo] Sergo Report: Mass-Landed-Fix Reconcile - 2026-10-04

[github-actions[bot]]

Executive Summary

Registry stable at 76 analyzers (no new linter since R85 / fprintferrorunchecked). The gh api reconcile matched memory exact expectations (14 open sergo issues), but reading the CODE behind each one instead of trusting the open label revealed something unusual: 13 of the 14 opens are already fixed in the codebase. This is the largest landed-fix-rate reconcile in sergo run history. Only timenowsub remains genuinely broken and has been refiled.

Tool and Registry Status

• Serena: 24 tools, stable (not re-tested live this run; Read/Grep/gh api were sufficient).
• pkg/linters/registry.go: 76 analyzers (Analyzer,$ count), no delta since R85.

Strategy: 50/50 Cached Reuse + New Exploration

Cached component: reconciled all 14 open sergo issues against current code rather than only against GitHub state, since prior runs established that issues are rarely closed even when fixed (phantom_reconcile pattern).

New-explore component: swept three candidate veins for undiscovered bugs - AssignStmt-only nodeFilter shapes, sameExpr-style equality helpers, and nolint-wiring parity across all 76 linters. All three came back clean; these veins are now exhausted per standing memory notes.

Findings

1. New issue filed - timenowsub (pkg/linters/timenowsub/timenowsub.go lines 50 and 103) still has zero UnwrapParenExpr calls before two bare type assertions, so a parenthesized time.Now() receiver or qualifier escapes detection. This is CI-enforced (native and wasm) with no test coverage for either shape. 3rd occurrence of this exact lineage (sg77a3, then timenowsub misses parenthesized time.Now() call: (time.Now()).Sub(t) escapes this CI-enforced linter #63344, now refiled).

2. 13 issues confirmed fixed in code since R85, all still open on GitHub:

• fprintferrorunchecked (fprintferrorunchecked (76th linter): AssignStmt-only filter misses 938 bare ExprStmt call sites #65225): nodeFilter now covers both AssignStmt and ExprStmt, plus a console-output exclusion.
• typeassertionnil (typeassertionnil (75th linter): syntactic-only StarExpr gate misses pointer type aliases and parenthesized pointer types #64905): now resolves pointer type aliases and parens via pass.TypesInfo + types.Unalias.
• internal/nolint space-prefix (internal/nolint: space-prefixed "// nolint:" directive still silently ignored (issue 62861 auto-expired, 5th reverse-phantom) #64680): TrimSpace added, 6th-generation lineage finally closed.
• blankassigncomma (blankassigncomma: still re-flags 14+ deliberate idiomatic error-discards (issue 62862 auto-expired, 3rd reverse-phantom) #64681): an allow-list check (isHashWriteString) now excludes the established idiom.
• uncheckedsliceindex (uncheckedsliceindex: selector-based sameExpr blind spot still unfixed (issue 62540 auto-expired) #64399): sameExpr now unwraps parens and handles SelectorExpr bases.
• bufioscannererunchecked (bufioscannererunchecked: block scope Err() gap still unfixed (issue 62541 auto-expired, 2nd reverse phantom for this lineage) #64398): error-check search now threads a following-statements parameter across nested blocks.
• closeerrorunchecked (closeerrorunchecked (74th linter): parenthesized Close() discards escape both assign patterns #64397): both assignment patterns now unwrap parens before the CallExpr assertion.
• resourcetracker shared framework (resourcetracker: sibling if/else branches still merge into one state entry, masking manual-cleanup violations (issue 62304 auto- #64164, covers manualmutexunlock/fileclosenotdeferred/contextcancelnotdeferred): state is now keyed per acquisition position, not merged across sibling branches.
• tolowerequalfold (tolowerequalfold: collectCaseConvAliases is position-blind, causing false negatives on reassigned aliases #63919): alias collection now snapshots state per comparison position.
• httprespbodyclose (httprespbodyclose: branch_state_merge gap still unfixed (issue 62115 auto-expired, 10th reverse-phantom) #63918): same per-position fix as resourcetracker.
• lenstringzero (lenstringzero: alias table is a single whole-package snapshot with no position tracking, causing false negatives #63768): same per-position alias-snapshot fix.
• astutil.StringLitValue and IsStringLiteral (astutil.StringLitValue/IsStringLiteral still skip ParenExpr unwrap (issue 61948 auto-expired, 2nd reverse-phantom) #63767): both now unwrap parens, fixing five call sites at once.
• bufferresetbeforereuse (bufferresetbeforereuse: per-block state isolation still unfixed (issue 61947 auto-expired, 6th reverse-phantom) #63766): branch state is now merged back into the parent scope instead of being reset per block.

Generated Tasks

• Fix the timenowsub paren-unwrap gap per the validation checklist in the new issue (small effort, two-line fix plus two testdata cases).

Recommendation for Maintainers

This workflow has no close-issue capability in its safe-output tools, so the 13 landed issues above remain open despite being fixed. Please bulk-close them when convenient. Separately, an issue titled sergo test probe 2 was created by mistake this run while diagnosing a tooling gotcha - please close that one too, it has no real content.

Metrics

• Issues filed this run: 1 real (timenowsub refile) plus 1 accidental test probe (flagged above for cleanup)
• Landed-fix verifications: 13
• Success score: 9/10

Historical Context

Total runs: 86. Total findings across all runs: 533. Running average success score: 8.74.

Next Run Focus (R87)

Verify the timenowsub refile lands. Re-tally open issues once the 13 landed fixes are bulk-closed - the open count should drop sharply. Since most standing bug veins (paren_unwrap_gap, branch_state_merge, presnapshot_position_blind, idiom_reflag_no_allowlist, block_scope_state_reset, ident_only_equality_gap) just closed out in this one sweep, R87 is a good point to pick an entirely fresh exploration target rather than continuing to probe exhausted veins. If the registry grows to a 77th analyzer, audit it fresh with the standing day-one checks.

References:

• §37179192683

Generated by 🤖 Sergo - Serena Go Expert · claude · agent · 259.8 AIC · ⌖ 4.33 AIC · ⊞ 5.2K · ◷

• expires on Oct 4, 2026, 9:21 PM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by Sergo - Serena Go Expert.

A newer discussion is available at Discussion #65754.