[repository-quality] Repository Quality: Context Propagation & Cancellation Hygiene

[github-actions[bot]]

🎯 Repository Quality Improvement Report - Context Propagation & Cancellation Hygiene

Analysis Date: 2026-10-06
Focus Area: Context propagation & cancellation hygiene (Go)
Strategy Type: Custom
Custom Area: Yes — the repo already ships linters (ctxbackground, execcommandwithoutcontext, timesleepnocontext, httpnoctx), so the question is how much real code still bypasses cancellation.

Executive Summary

Non-test, non-linter code has ~92 exec.Command( call sites (vs ~56 exec.CommandContext(), concentrated in pkg/cli/git.go (20), pkg/cli/pr_command.go (20), trial_repository.go (8), trial_helpers.go (5), shell_completion.go (4). Ctrl-C or timeouts cannot stop these subprocesses.

About 30 production context.Background() calls remain. Some are legitimate roots (forecast.go signal context, shutdown timeouts), but others sit in call chains that could accept a ctx: logs_parsing_javascript.go:65-76, logs_parsing_persisted.go:40,52, copilot_agents.go:202, experiments_command.go:335, branch_file_reader.go:19, workflow/github_cli.go:105,190,212 (non-context wrappers).

Four time.Sleep calls remain in production code: run_workflow_tracking.go:73, trial_repository.go:199, update_extension_check.go:412, docker_validation.go:220. No http.Get/NewRequest violations found outside linter testdata.

Full Analysis Report

Focus Area: Context propagation

Current State Assessment

Metric	Value	Status
exec.Command( (prod)	~92	❌
exec.CommandContext( (prod)	~56	⚠️
context.Background() (prod, excl. linters)	~30	⚠️
time.Sleep (prod)	4	⚠️
Raw http.Get/NewRequest (prod)	0	✅
Context-related linters present	4	✅

Findings

Strengths

• Dedicated linters exist and ctxutil helper centralises nil-ctx handling.
• HTTP paths are clean.

Areas for Improvement

• High: git/PR helpers in pkg/cli spawn uncancellable subprocesses.
• Medium: non-context wrapper functions hide context.Background() (github_cli.go).
• Medium: log parsing chain roots its own ctx.
• Low: remaining time.Sleep calls.
• Medium: the linters appear not to flag all these sites (or they are suppressed/not enforced in CI) — verify the lint gate.

Detailed Analysis

The context-aware variants (RunGHContext, readRemoteRepoBranchFileContext) already exist, so most fixes are plumbing a ctx parameter to callers rather than new design.

---

🤖 Tasks for Copilot Agent

NOTE TO PLANNER AGENT: Split the following tasks into individual work items.

Improvement Tasks

Task 1: Convert exec.Command in git/PR helpers to CommandContext

Priority: High
Estimated Effort: Medium
Focus Area: Context propagation

Description: Thread ctx through pkg/cli/git.go and pkg/cli/pr_command.go subprocess calls.

Acceptance Criteria:

• No exec.Command( remains in these two files
• Callers pass their ctx; make test-unit passes

Code Region: pkg/cli/git.go, pkg/cli/pr_command.go

Replace exec.Command with exec.CommandContext in pkg/cli/git.go and pkg/cli/pr_command.go, adding a ctx context.Context first parameter to affected functions and updating callers. Run make fmt and make test-unit.

---

Task 2: Convert trial helpers and misc CLI subprocesses

Priority: Medium
Estimated Effort: Medium
Focus Area: Context propagation

Description: Same conversion for trial_repository.go, trial_helpers.go, shell_completion.go, add_interactive_git.go, poutine.go, shellcheck.go, update_merge.go, repo.go, experiments_state.go.

Acceptance Criteria:

• No exec.Command( in these files
• Tests pass

Code Region: pkg/cli/trial_*.go, pkg/cli/shell_completion.go, pkg/cli/poutine.go, pkg/cli/shellcheck.go

Convert remaining exec.Command calls in the listed pkg/cli files to exec.CommandContext with a propagated ctx.

---

Task 3: Remove hidden context.Background() in wrappers and log parsing

Priority: Medium
Estimated Effort: Small
Focus Area: Context propagation

Description: Plumb ctx into logs_parsing_javascript.go, logs_parsing_persisted.go, copilot_agents.go:202, experiments_command.go:335, branch_file_reader.go:19; deprecate/remove non-context wrappers in pkg/workflow/github_cli.go.

Acceptance Criteria:

• Listed sites accept ctx from callers
• Wrapper usage count reduced

Code Region: pkg/cli/logs_parsing_*.go, pkg/workflow/github_cli.go

Add ctx parameters and thread from command RunE (cmd.Context()) down to these call sites; migrate callers of non-context gh wrappers to the *Context variants.

---

Task 4: Replace production time.Sleep with ctx-aware waits

Priority: Low
Estimated Effort: Small
Focus Area: Context propagation

Description: Use select { case <-ctx.Done(): ... case <-time.After(d): } at run_workflow_tracking.go:73, trial_repository.go:199, update_extension_check.go:412, docker_validation.go:220.

Acceptance Criteria:

• No unannotated time.Sleep in prod code
• Tests pass

Code Region: files listed above

Replace time.Sleep with a ctx-aware select wait in the four listed locations.

---

Task 5: Verify linter enforcement in CI

Priority: Medium
Estimated Effort: Small
Focus Area: Linting

Description: Confirm execcommandwithoutcontext and ctxbackground run against pkg/cli in CI; if exempted, document and track a baseline that shrinks.

Acceptance Criteria:

• Linters enforced on production code or baseline documented

Code Region: pkg/linters/registry.go, Makefile

Investigate why ~92 exec.Command sites are not failing the execcommandwithoutcontext linter and fix the configuration or document the baseline.

---

📊 Historical Context

Previous Focus Areas

Date	Focus Area	Type	Custom	Key Outcomes
2026-10-05	Error-handling contract consistency	Custom	Y	4 tasks
2026-10-06	Context propagation & cancellation	Custom	Y	5 tasks

---

🎯 Recommendations

Immediate Actions (This Week)

1. Task 1 — Priority: High

Short-term Actions (This Month)

1. Tasks 2, 3, 5 — Priority: Medium

Long-term Actions (This Quarter)

1. Task 4 — Priority: Low

---

📈 Success Metrics

• Prod exec.Command: 92 → 0
• Prod time.Sleep: 4 → 0

---

Next Steps

1. Review and prioritise the tasks above
2. Assign tasks to Copilot coding agent via planner agent
3. Track progress
4. Re-evaluate in 1 month

---

Generated by Repository Quality Improvement Agent
Next analysis: 2026-10-07 — Focus area selected by diversity algorithm

Generated by ⚡ Repository Quality Improvement Agent · copilot · auto · 22.6 AIC · ⌖ 17.4 AIC · ⊞ 9.9K · ◷

• expires on Oct 7, 2026, 5:04 AM UTC-08:00